devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yu Tu <yu.tu@amlogic.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: kelvin.zhang@amlogic.com, qi.duan@amlogic.com
Subject: Re: [PATCH V10 1/4] dt-bindings: clock: document Amlogic S4 SoC PLL clock controller
Date: Wed, 23 Aug 2023 07:43:14 +0200	[thread overview]
Message-ID: <c2faccd6-1d77-9b81-d8d9-830e95e804af@linaro.org> (raw)
In-Reply-To: <e9932f90-a011-ee9b-ef09-f2e2475bdd0d@amlogic.com>

On 23/08/2023 04:24, Yu Tu wrote:
> 
> 
> On 2023/8/23 0:32, Krzysztof Kozlowski wrote:
>> [ EXTERNAL EMAIL ]
>>> On 22/08/2023 10:27, Yu Tu wrote:
>>> Add the S4 PLL clock controller dt-bindings in the S4 SoC family.
>>>
>>> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
>>
>> Lovely. I sent youa  friendly reminder at v8 which turns our you
>> ignored. You keep ignoring, I will start ignoring as well from now on.
> 
> Hi Krzysztof,
> 
> Sorry. I did not forget the friendly reminder in v8, I consulted you for 
> this at the time, so I re-sent V9 after adding the tag. Because it was 
> just "meson" that was removed. But V10 is based on Neil's patch, which I 
> think is a bit of a change. So I didn't dare add it. Instead of 
> forgetting your reminder.
> 
> So what should I do, I'll follow your advice exactly.

I don't think there was much difference between the version, which
received the review, and the current patch. Otherwise your changelog
should say that you drop Rb tag. Rebasing of something somewhere is not
the reason, so please describe what are the differences in the patch?

Best regards,
Krzysztof


  reply	other threads:[~2023-08-23  5:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22  8:27 [PATCH V10 0/4] Add S4 SoC PLLs and Peripheral clock Yu Tu
2023-08-22  8:27 ` [PATCH V10 1/4] dt-bindings: clock: document Amlogic S4 SoC PLL clock controller Yu Tu
2023-08-22 16:32   ` Krzysztof Kozlowski
2023-08-23  2:24     ` Yu Tu
2023-08-23  5:43       ` Krzysztof Kozlowski [this message]
2023-08-23  6:20         ` Yu Tu
2023-08-23  6:27           ` Krzysztof Kozlowski
2023-08-23  6:35             ` Yu Tu
2023-08-22  8:27 ` [PATCH V10 2/4] dt-bindings: clock: document Amlogic S4 SoC peripherals " Yu Tu
2023-08-22 16:33   ` Krzysztof Kozlowski
2023-08-23  2:29     ` Yu Tu
2023-08-23  8:01   ` Jerome Brunet
2023-08-23  8:32     ` Yu Tu
2023-08-23  9:14       ` Jerome Brunet
2023-08-24  2:35         ` Yu Tu
2023-08-22  8:27 ` [PATCH V10 3/4] clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver Yu Tu
2023-08-22  8:27 ` [PATCH V10 4/4] clk: meson: S4: add support for Amlogic S4 SoC peripheral clock controller Yu Tu
2023-08-23  8:13   ` Jerome Brunet
2023-08-23  8:41     ` Yu Tu
2023-08-27 17:04 ` [PATCH V10 0/4] Add S4 SoC PLLs and Peripheral clock Lucas Tanure
2023-08-28  2:24   ` Keguang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2faccd6-1d77-9b81-d8d9-830e95e804af@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=kelvin.zhang@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=qi.duan@amlogic.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=yu.tu@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).