From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 87515322A3B; Fri, 29 Aug 2025 15:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756482484; cv=none; b=MFLfm4PZwKu7vlGYob1HzoVAuAhd5ywEY1jmSZXp03EeA1HTfeEGsTM25t3qOHx1kdsDekRxIKhvlheR00mQeMXLd3ldpv40OBdMULZ1nUt0Q/vJYbhDyLaUgMppLeaAopwndJ4vT9V5St8mme3fqH1IUrxNWX2m3k9Ggzz/Qxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756482484; c=relaxed/simple; bh=qEcJN/BqmAPsdwnHlhKS574vvXK0JpD9t5oydKxd4YA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MWrO71atKXbCUU7PcDXLw7jIil//eA/UN+dSmlugOKjkWGXB/ijDX8BqO8C17L3b//HnKJ64A7W/58r7YtJIDjsZNkLRWY7LcCNf9P6eS5ufMjr2FjYYXFK8ZLHT9w6+6W1Y7jETF400sK1C27Sd/Lt1D664E0LXCdWosvPLG2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 62A4A19F0; Fri, 29 Aug 2025 08:47:52 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CF3513F738; Fri, 29 Aug 2025 08:47:54 -0700 (PDT) Message-ID: Date: Fri, 29 Aug 2025 16:47:53 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 26/33] arm_mpam: Add helpers to allocate monitors To: James Morse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org Cc: shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250822153048.2287-1-james.morse@arm.com> <20250822153048.2287-27-james.morse@arm.com> From: Ben Horgan Content-Language: en-US In-Reply-To: <20250822153048.2287-27-james.morse@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi James, On 8/22/25 16:30, James Morse wrote: > MPAM's MSC support a number of monitors, each of which supports > bandwidth counters, or cache-storage-utilisation counters. To use > a counter, a monitor needs to be configured. Add helpers to allocate > and free CSU or MBWU monitors. > > Signed-off-by: James Morse > --- > drivers/resctrl/mpam_devices.c | 2 ++ > drivers/resctrl/mpam_internal.h | 35 +++++++++++++++++++++++++++++++++ > 2 files changed, 37 insertions(+) This looks good to me. Reviewed-by: Ben Horgan Thanks, Ben