From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: "Heiko Stübner" <heiko@sntech.de>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Sugar Zhang" <sugar.zhang@rock-chips.com>,
"Shreeya Patel" <shreeya.patel@collabora.com>,
"Kever Yang" <kever.yang@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH 1/3] dt-bindings: timer: rockchip: Drop superfluous rk3288 compatible
Date: Tue, 18 Apr 2023 13:34:15 +0300 [thread overview]
Message-ID: <c2fe7e09-024c-b3f7-c7a6-0c2981cb3ba3@collabora.com> (raw)
In-Reply-To: <2436573.fIoEIV5pvu@diego>
On 4/18/23 13:26, Heiko Stübner wrote:
> Am Dienstag, 18. April 2023, 11:53:42 CEST schrieb Cristian Ciocaltea:
>> The compatible string for Rockchip RK3288 is provided in both the 'enum'
>> and the subsequent 'const' item. Drop the unnecessary entry from the
>> enum.
>
> And the actual rk3288-timer case is handled in the separate
> - const: rockchip,rk3288-timer
> at the top of the list too.
Right, in total there were 3 occurrences of this compatible string.
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
Thanks for the quick review!
Regards,
Cristian
next prev parent reply other threads:[~2023-04-18 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 9:53 [PATCH 0/3] Enable rk3588 timer support Cristian Ciocaltea
2023-04-18 9:53 ` [PATCH 1/3] dt-bindings: timer: rockchip: Drop superfluous rk3288 compatible Cristian Ciocaltea
2023-04-18 10:26 ` Heiko Stübner
2023-04-18 10:34 ` Cristian Ciocaltea [this message]
2023-04-18 9:53 ` [PATCH 2/3] dt-bindings: timer: rockchip: Add rk3588 compatible Cristian Ciocaltea
2023-04-18 10:26 ` Heiko Stübner
2023-04-18 9:53 ` [PATCH 3/3] arm64: dts: rockchip: Add rk3588 timer Cristian Ciocaltea
2023-04-18 11:29 ` Johan Jonker
2023-04-18 11:53 ` Cristian Ciocaltea
2023-04-18 14:12 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2fe7e09-024c-b3f7-c7a6-0c2981cb3ba3@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shreeya.patel@collabora.com \
--cc=sugar.zhang@rock-chips.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).