* [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
@ 2025-09-04 7:22 Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 1/6] dt-bindings: display/msm: Document the DPU for QCS8300 Yongxing Mou
` (4 more replies)
0 siblings, 5 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-04 7:22 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou, Krzysztof Kozlowski, Dmitry Baryshkov
This series introduces support to enable the Mobile Display Subsystem (MDSS)
, Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
QCS8300 target. It includes the addition of the hardware catalog, compatible
string, and their YAML bindings.
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
Changes in v11: Fixed review comments from Dmitry.
- Rebase to MST bindings V8.
- Update the clocks-name for QCS8300 in dp-controller.
- Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
Changes in v10:
- Rebase to MST bindings V7.
- Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
- Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
Changes in v9: Fixed review comments from Dmitry.
- Updated the description of dp-controller DT binding.
- Add new clause only work for QCS8300(one DP controller with 4 streams).
- Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
Changes in v8: Fixed review comments from Krzysztof, Dmitry.
- Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
- Fixed incorrect description for ubwc change.[Dmitry]
- Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
Changes in v7: Fixed review comments from Dmitry.
- Rebase to next-20250818 and 4 pixel stream series V6.
- Add more description for the dp-controller dt-bingding change.[Dmitry]
- Reorder the MDSS change and UBWC change.[Dmitry]
- Switch to the OSS email.
- Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
Changes in v6: Fixed review comments from Konrad, Dmitry.
- Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
- Optimize the description in MDSS dt-binding.[Dmitry]
- Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
- Add the DP controller driver change.
- Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
Changes in v5:Fixed review comments from Krzysztof, Dmitry.
- Rebase to next-20250717.
- Change DP compatible to qcs8300-dp due to add 4 streams support.
- Add QCS8300 UBWC config change due to rebase.
- Add 4 streams clk and phy in the mdss yaml.
- Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
Changes in v4:Fixed review comments from Krzysztof, Dmitry.
- Use the common style for the dt-bindings commits.[Dmitry]
- Update the commits msg for the mdss binding patch, explain why they
reuse different platform drivers.[Krzysztof]
- Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
Changes in v3:Fixed review comments from Krzysztof, Dmitry.
- Fix the missing space issue in commit message.[Krzysztof]
- Separate the patch for the phy from this series.[Dmitry]
- Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
- Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
- Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
- Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
- Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
- Correct formatting errors and remove unnecessary status in MDSS
bindings.[Krzysztof]
- Add the the necessary information in MDSS changes commit msg.[Dmitry]
- Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
- Package the DisplayPort controller and eDP PHY bindings document to
this patch series.
- Collecting MDSS changes reviewd-by Dmitry.
- Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
- Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
- Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
---
This series depend on 4 pixel streams dt-binding series:
https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
and separate eDP PHY binding:
https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
---
Yongxing Mou (6):
dt-bindings: display/msm: Document the DPU for QCS8300
dt-bindings: display/msm: dp-controller: document QCS8300 compatible
dt-bindings: display/msm: Document MDSS on QCS8300
soc: qcom: ubwc: Add QCS8300 UBWC cfg
drm/msm: mdss: Add QCS8300 support
drm/msm/dp: Add DisplayPort controller for QCS8300
.../bindings/display/msm/dp-controller.yaml | 22 ++
.../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
.../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
drivers/gpu/drm/msm/dp/dp_display.c | 1 +
drivers/gpu/drm/msm/msm_mdss.c | 1 +
drivers/soc/qcom/ubwc_config.c | 1 +
6 files changed, 321 insertions(+), 5 deletions(-)
---
base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
Best regards,
--
Yongxing Mou <yongxing.mou@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v11 1/6] dt-bindings: display/msm: Document the DPU for QCS8300
2025-09-04 7:22 [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
@ 2025-09-04 7:22 ` Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible Yongxing Mou
` (3 subsequent siblings)
4 siblings, 0 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-04 7:22 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou, Krzysztof Kozlowski
Document the DPU for Qualcomm QCS8300 platform. It use the same DPU
hardware with SA8775P and reuse it's driver.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
.../devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
index 0a46120dd8680371ed031f7773859716f49c3aa1..d9b980a897229860dae76f25bd947405e3910925 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
@@ -13,11 +13,16 @@ $ref: /schemas/display/msm/dpu-common.yaml#
properties:
compatible:
- enum:
- - qcom,sa8775p-dpu
- - qcom,sm8650-dpu
- - qcom,sm8750-dpu
- - qcom,x1e80100-dpu
+ oneOf:
+ - enum:
+ - qcom,sa8775p-dpu
+ - qcom,sm8650-dpu
+ - qcom,sm8750-dpu
+ - qcom,x1e80100-dpu
+ - items:
+ - enum:
+ - qcom,qcs8300-dpu
+ - const: qcom,sa8775p-dpu
reg:
items:
--
2.34.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-04 7:22 [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 1/6] dt-bindings: display/msm: Document the DPU for QCS8300 Yongxing Mou
@ 2025-09-04 7:22 ` Yongxing Mou
2025-09-04 13:43 ` Dmitry Baryshkov
2025-09-04 7:22 ` [PATCH v11 3/6] dt-bindings: display/msm: Document MDSS on QCS8300 Yongxing Mou
` (2 subsequent siblings)
4 siblings, 1 reply; 22+ messages in thread
From: Yongxing Mou @ 2025-09-04 7:22 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou
Add compatible string for the DisplayPort controller found on the
Qualcomm QCS8300 SoC.
The Qualcomm QCS8300 platform comes with one DisplayPort controller
that supports 4 MST streams.
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
.../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -18,6 +18,7 @@ properties:
compatible:
oneOf:
- enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,sc7180-dp
- qcom,sc7280-dp
@@ -195,6 +196,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,x1e80100-dp
then:
@@ -295,6 +297,26 @@ allOf:
minItems: 6
maxItems: 8
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ # QCS8300 only has one DP controller that supports 4
+ # streams MST.
+ - qcom,qcs8300-dp
+ then:
+ properties:
+ reg:
+ minItems: 9
+ maxItems: 9
+ clocks:
+ minItems: 8
+ maxItems: 8
+ clocks-names:
+ minItems: 8
+ maxItems: 8
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v11 3/6] dt-bindings: display/msm: Document MDSS on QCS8300
2025-09-04 7:22 [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 1/6] dt-bindings: display/msm: Document the DPU for QCS8300 Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible Yongxing Mou
@ 2025-09-04 7:22 ` Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 4/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg Yongxing Mou
2025-09-04 7:55 ` [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
4 siblings, 0 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-04 7:22 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou, Krzysztof Kozlowski
Document the MDSS hardware found on the Qualcomm QCS8300 platform.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
.../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
1 file changed, 286 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..06b16e35a350d24a09e0e8623b743475061dcfe3
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
@@ -0,0 +1,286 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/qcom,qcs8300-mdss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. QCS8300 Display MDSS
+
+maintainers:
+ - Yongxing Mou <yongxing.mou@oss.qualcomm.com>
+
+description:
+ QCS8300 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
+ DPU display controller, DP interfaces and EDP etc.
+
+$ref: /schemas/display/msm/mdss-common.yaml#
+
+properties:
+ compatible:
+ const: qcom,qcs8300-mdss
+
+ clocks:
+ items:
+ - description: Display AHB
+ - description: Display hf AXI
+ - description: Display core
+
+ iommus:
+ maxItems: 1
+
+ interconnects:
+ maxItems: 3
+
+ interconnect-names:
+ maxItems: 3
+
+patternProperties:
+ "^display-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcs8300-dpu
+
+ "^displayport-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+
+ properties:
+ compatible:
+ items:
+ - const: qcom,qcs8300-dp
+
+ "^phy@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcs8300-edp-phy
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interconnect/qcom,icc.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/qcom,qcs8300-gcc.h>
+ #include <dt-bindings/clock/qcom,sa8775p-dispcc.h>
+ #include <dt-bindings/interconnect/qcom,qcs8300-rpmh.h>
+ #include <dt-bindings/power/qcom,rpmhpd.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+
+ mdss: display-subsystem@ae00000 {
+ compatible = "qcom,qcs8300-mdss";
+ reg = <0x0ae00000 0x1000>;
+ reg-names = "mdss";
+
+ interconnects = <&mmss_noc MASTER_MDP0 QCOM_ICC_TAG_ACTIVE_ONLY
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&mmss_noc MASTER_MDP1 QCOM_ICC_TAG_ACTIVE_ONLY
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>;
+ interconnect-names = "mdp0-mem",
+ "mdp1-mem",
+ "cpu-cfg";
+
+ resets = <&dispcc_core_bcr>;
+ power-domains = <&dispcc_gdsc>;
+
+ clocks = <&dispcc_ahb_clk>,
+ <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc_mdp_clk>;
+
+ interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ iommus = <&apps_smmu 0x1000 0x402>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ display-controller@ae01000 {
+ compatible = "qcom,qcs8300-dpu", "qcom,sa8775p-dpu";
+ reg = <0x0ae01000 0x8f000>,
+ <0x0aeb0000 0x2008>;
+ reg-names = "mdp", "vbif";
+
+ clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
+ clock-names = "nrt_bus",
+ "iface",
+ "lut",
+ "core",
+ "vsync";
+
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
+ assigned-clock-rates = <19200000>;
+ operating-points-v2 = <&mdp_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <0>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+
+ dpu_intf0_out: endpoint {
+ remote-endpoint = <&mdss_dp0_in>;
+ };
+ };
+ };
+
+ mdp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-375000000 {
+ opp-hz = /bits/ 64 <375000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-500000000 {
+ opp-hz = /bits/ 64 <500000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+
+ opp-575000000 {
+ opp-hz = /bits/ 64 <575000000>;
+ required-opps = <&rpmhpd_opp_turbo>;
+ };
+
+ opp-650000000 {
+ opp-hz = /bits/ 64 <650000000>;
+ required-opps = <&rpmhpd_opp_turbo_l1>;
+ };
+ };
+ };
+
+ mdss_dp0_phy: phy@aec2a00 {
+ compatible = "qcom,qcs8300-edp-phy", "qcom,sa8775p-edp-phy";
+
+ reg = <0x0aec2a00 0x200>,
+ <0x0aec2200 0xd0>,
+ <0x0aec2600 0xd0>,
+ <0x0aec2000 0x1c8>;
+
+ clocks = <&dispcc MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc MDSS_DISP_CC_MDSS_AHB_CLK>;
+ clock-names = "aux",
+ "cfg_ahb";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ vdda-phy-supply = <&vreg_l1c>;
+ vdda-pll-supply = <&vreg_l4a>;
+ };
+
+ displayport-controller@af54000 {
+ compatible = "qcom,qcs8300-dp";
+
+ pinctrl-0 = <&dp_hot_plug_det>;
+ pinctrl-names = "default";
+
+ reg = <0xaf54000 0x104>,
+ <0xaf54200 0x0c0>,
+ <0xaf55000 0x770>,
+ <0xaf56000 0x09c>,
+ <0xaf57000 0x09c>,
+ <0xaf58000 0x09c>,
+ <0xaf59000 0x09c>,
+ <0xaf5a000 0x23c>,
+ <0xaf5b000 0x23c>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <12>;
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL2_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL3_CLK>;
+ clock-names = "core_iface",
+ "core_aux",
+ "ctrl_link",
+ "ctrl_link_iface",
+ "stream_pixel",
+ "stream_1_pixel",
+ "stream_2_pixel",
+ "stream_3_pixel";
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL2_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL3_CLK_SRC>;
+ assigned-clock-parents = <&mdss_dp0_phy 0>,
+ <&mdss_dp0_phy 1>,
+ <&mdss_dp0_phy 1>,
+ <&mdss_dp0_phy 1>;
+ phys = <&mdss_dp0_phy>;
+ phy-names = "dp";
+ operating-points-v2 = <&dp_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ #sound-dai-cells = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ mdss_dp0_in: endpoint {
+ remote-endpoint = <&dpu_intf0_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ mdss_dp_out: endpoint { };
+ };
+ };
+
+ dp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+ };
+...
--
2.34.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v11 4/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg
2025-09-04 7:22 [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
` (2 preceding siblings ...)
2025-09-04 7:22 ` [PATCH v11 3/6] dt-bindings: display/msm: Document MDSS on QCS8300 Yongxing Mou
@ 2025-09-04 7:22 ` Yongxing Mou
2025-09-04 7:55 ` [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
4 siblings, 0 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-04 7:22 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou, Dmitry Baryshkov
The QCS8300 supports UBWC 4.0 and 4 channels LP5 memory interface. Use
the SC8280XP data structure for QCS8300 according to the specification.
Acked-by: Bjorn Andersson <andersson@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
drivers/soc/qcom/ubwc_config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
index 1490a7f63767bba176e8e2e76891d7d2c424bb7f..b70627d40dc4c671b8a855a17d4b8ca2dd9952d5 100644
--- a/drivers/soc/qcom/ubwc_config.c
+++ b/drivers/soc/qcom/ubwc_config.c
@@ -236,6 +236,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
{ .compatible = "qcom,msm8998", .data = &msm8998_data },
{ .compatible = "qcom,qcm2290", .data = &qcm2290_data, },
{ .compatible = "qcom,qcm6490", .data = &sc7280_data, },
+ { .compatible = "qcom,qcs8300", .data = &sc8280xp_data, },
{ .compatible = "qcom,sa8155p", .data = &sm8150_data, },
{ .compatible = "qcom,sa8540p", .data = &sc8280xp_data, },
{ .compatible = "qcom,sa8775p", .data = &sa8775p_data, },
--
2.34.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-04 7:22 [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
` (3 preceding siblings ...)
2025-09-04 7:22 ` [PATCH v11 4/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg Yongxing Mou
@ 2025-09-04 7:55 ` Yongxing Mou
2025-09-04 8:21 ` Konrad Dybcio
4 siblings, 1 reply; 22+ messages in thread
From: Yongxing Mou @ 2025-09-04 7:55 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski, Dmitry Baryshkov
On 9/4/2025 3:22 PM, Yongxing Mou wrote:
> This series introduces support to enable the Mobile Display Subsystem (MDSS)
> , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
> QCS8300 target. It includes the addition of the hardware catalog, compatible
> string, and their YAML bindings.
>
> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> ---
> Changes in v11: Fixed review comments from Dmitry.
> - Rebase to MST bindings V8.
> - Update the clocks-name for QCS8300 in dp-controller.
> - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
>
> Changes in v10:
> - Rebase to MST bindings V7.
> - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
> - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
>
> Changes in v9: Fixed review comments from Dmitry.
> - Updated the description of dp-controller DT binding.
> - Add new clause only work for QCS8300(one DP controller with 4 streams).
> - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
>
> Changes in v8: Fixed review comments from Krzysztof, Dmitry.
> - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
> - Fixed incorrect description for ubwc change.[Dmitry]
> - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
>
> Changes in v7: Fixed review comments from Dmitry.
> - Rebase to next-20250818 and 4 pixel stream series V6.
> - Add more description for the dp-controller dt-bingding change.[Dmitry]
> - Reorder the MDSS change and UBWC change.[Dmitry]
> - Switch to the OSS email.
> - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
>
> Changes in v6: Fixed review comments from Konrad, Dmitry.
> - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
> - Optimize the description in MDSS dt-binding.[Dmitry]
> - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
> - Add the DP controller driver change.
> - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
>
> Changes in v5:Fixed review comments from Krzysztof, Dmitry.
> - Rebase to next-20250717.
> - Change DP compatible to qcs8300-dp due to add 4 streams support.
> - Add QCS8300 UBWC config change due to rebase.
> - Add 4 streams clk and phy in the mdss yaml.
> - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
>
> Changes in v4:Fixed review comments from Krzysztof, Dmitry.
> - Use the common style for the dt-bindings commits.[Dmitry]
> - Update the commits msg for the mdss binding patch, explain why they
> reuse different platform drivers.[Krzysztof]
> - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
>
> Changes in v3:Fixed review comments from Krzysztof, Dmitry.
> - Fix the missing space issue in commit message.[Krzysztof]
> - Separate the patch for the phy from this series.[Dmitry]
> - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
> - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
>
> Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
> - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
> - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
> - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
> - Correct formatting errors and remove unnecessary status in MDSS
> bindings.[Krzysztof]
> - Add the the necessary information in MDSS changes commit msg.[Dmitry]
> - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
> 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
> - Package the DisplayPort controller and eDP PHY bindings document to
> this patch series.
> - Collecting MDSS changes reviewd-by Dmitry.
> - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
> - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
> - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
> ---
> This series depend on 4 pixel streams dt-binding series:
> https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
>
> and separate eDP PHY binding:
> https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
>
> ---
> Yongxing Mou (6):
> dt-bindings: display/msm: Document the DPU for QCS8300
> dt-bindings: display/msm: dp-controller: document QCS8300 compatible
> dt-bindings: display/msm: Document MDSS on QCS8300
> soc: qcom: ubwc: Add QCS8300 UBWC cfg
> drm/msm: mdss: Add QCS8300 support
> drm/msm/dp: Add DisplayPort controller for QCS8300
>
> .../bindings/display/msm/dp-controller.yaml | 22 ++
> .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
> .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> drivers/gpu/drm/msm/msm_mdss.c | 1 +
> drivers/soc/qcom/ubwc_config.c | 1 +
> 6 files changed, 321 insertions(+), 5 deletions(-)
> ---
> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
> change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
> prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
> prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
> prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
> prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
> prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
> prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
> prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
> prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
> prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
> prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
> prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
> prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
>
> Best regards,
Hi, maintainers:
sorry for the inconvenience caused. This series is missing patch 5 and
patch 6 due to network issues. May I resend it? The missed two changes
are identical to V10.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-04 7:55 ` [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
@ 2025-09-04 8:21 ` Konrad Dybcio
2025-09-04 9:31 ` Yongxing Mou
0 siblings, 1 reply; 22+ messages in thread
From: Konrad Dybcio @ 2025-09-04 8:21 UTC (permalink / raw)
To: Yongxing Mou, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski, Dmitry Baryshkov
On 9/4/25 9:55 AM, Yongxing Mou wrote:
>
>
> On 9/4/2025 3:22 PM, Yongxing Mou wrote:
>> This series introduces support to enable the Mobile Display Subsystem (MDSS)
>> , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
>> QCS8300 target. It includes the addition of the hardware catalog, compatible
>> string, and their YAML bindings.
>>
>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>> ---
>> Changes in v11: Fixed review comments from Dmitry.
>> - Rebase to MST bindings V8.
>> - Update the clocks-name for QCS8300 in dp-controller.
>> - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
>>
>> Changes in v10:
>> - Rebase to MST bindings V7.
>> - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
>> - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
>>
>> Changes in v9: Fixed review comments from Dmitry.
>> - Updated the description of dp-controller DT binding.
>> - Add new clause only work for QCS8300(one DP controller with 4 streams).
>> - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
>>
>> Changes in v8: Fixed review comments from Krzysztof, Dmitry.
>> - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
>> - Fixed incorrect description for ubwc change.[Dmitry]
>> - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
>>
>> Changes in v7: Fixed review comments from Dmitry.
>> - Rebase to next-20250818 and 4 pixel stream series V6.
>> - Add more description for the dp-controller dt-bingding change.[Dmitry]
>> - Reorder the MDSS change and UBWC change.[Dmitry]
>> - Switch to the OSS email.
>> - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
>>
>> Changes in v6: Fixed review comments from Konrad, Dmitry.
>> - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
>> - Optimize the description in MDSS dt-binding.[Dmitry]
>> - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
>> - Add the DP controller driver change.
>> - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
>>
>> Changes in v5:Fixed review comments from Krzysztof, Dmitry.
>> - Rebase to next-20250717.
>> - Change DP compatible to qcs8300-dp due to add 4 streams support.
>> - Add QCS8300 UBWC config change due to rebase.
>> - Add 4 streams clk and phy in the mdss yaml.
>> - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
>>
>> Changes in v4:Fixed review comments from Krzysztof, Dmitry.
>> - Use the common style for the dt-bindings commits.[Dmitry]
>> - Update the commits msg for the mdss binding patch, explain why they
>> reuse different platform drivers.[Krzysztof]
>> - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
>>
>> Changes in v3:Fixed review comments from Krzysztof, Dmitry.
>> - Fix the missing space issue in commit message.[Krzysztof]
>> - Separate the patch for the phy from this series.[Dmitry]
>> - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
>> - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
>>
>> Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
>> - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
>> - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
>> - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
>> - Correct formatting errors and remove unnecessary status in MDSS
>> bindings.[Krzysztof]
>> - Add the the necessary information in MDSS changes commit msg.[Dmitry]
>> - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
>> 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
>> - Package the DisplayPort controller and eDP PHY bindings document to
>> this patch series.
>> - Collecting MDSS changes reviewd-by Dmitry.
>> - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
>> - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
>> - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
>> ---
>> This series depend on 4 pixel streams dt-binding series:
>> https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
>>
>> and separate eDP PHY binding:
>> https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
>>
>> ---
>> Yongxing Mou (6):
>> dt-bindings: display/msm: Document the DPU for QCS8300
>> dt-bindings: display/msm: dp-controller: document QCS8300 compatible
>> dt-bindings: display/msm: Document MDSS on QCS8300
>> soc: qcom: ubwc: Add QCS8300 UBWC cfg
>> drm/msm: mdss: Add QCS8300 support
>> drm/msm/dp: Add DisplayPort controller for QCS8300
>>
>> .../bindings/display/msm/dp-controller.yaml | 22 ++
>> .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
>> .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
>> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
>> drivers/gpu/drm/msm/msm_mdss.c | 1 +
>> drivers/soc/qcom/ubwc_config.c | 1 +
>> 6 files changed, 321 insertions(+), 5 deletions(-)
>> ---
>> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
>> change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
>> prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
>> prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
>> prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
>> prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
>> prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
>> prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
>> prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
>> prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
>> prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
>> prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
>> prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
>> prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
>>
>> Best regards,
>
> Hi, maintainers:
> sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
You can fix that manually by sending them both through
b4 send -o /tmp/
git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
Konrad
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-04 8:21 ` Konrad Dybcio
@ 2025-09-04 9:31 ` Yongxing Mou
2025-09-04 9:44 ` Konrad Dybcio
2025-09-04 13:41 ` Dmitry Baryshkov
0 siblings, 2 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-04 9:31 UTC (permalink / raw)
To: Konrad Dybcio, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski, Dmitry Baryshkov
On 9/4/2025 4:21 PM, Konrad Dybcio wrote:
> On 9/4/25 9:55 AM, Yongxing Mou wrote:
>>
>>
>> On 9/4/2025 3:22 PM, Yongxing Mou wrote:
>>> This series introduces support to enable the Mobile Display Subsystem (MDSS)
>>> , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
>>> QCS8300 target. It includes the addition of the hardware catalog, compatible
>>> string, and their YAML bindings.
>>>
>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>> ---
>>> Changes in v11: Fixed review comments from Dmitry.
>>> - Rebase to MST bindings V8.
>>> - Update the clocks-name for QCS8300 in dp-controller.
>>> - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
>>>
>>> Changes in v10:
>>> - Rebase to MST bindings V7.
>>> - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
>>> - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
>>>
>>> Changes in v9: Fixed review comments from Dmitry.
>>> - Updated the description of dp-controller DT binding.
>>> - Add new clause only work for QCS8300(one DP controller with 4 streams).
>>> - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
>>>
>>> Changes in v8: Fixed review comments from Krzysztof, Dmitry.
>>> - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
>>> - Fixed incorrect description for ubwc change.[Dmitry]
>>> - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
>>>
>>> Changes in v7: Fixed review comments from Dmitry.
>>> - Rebase to next-20250818 and 4 pixel stream series V6.
>>> - Add more description for the dp-controller dt-bingding change.[Dmitry]
>>> - Reorder the MDSS change and UBWC change.[Dmitry]
>>> - Switch to the OSS email.
>>> - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
>>>
>>> Changes in v6: Fixed review comments from Konrad, Dmitry.
>>> - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
>>> - Optimize the description in MDSS dt-binding.[Dmitry]
>>> - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
>>> - Add the DP controller driver change.
>>> - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
>>>
>>> Changes in v5:Fixed review comments from Krzysztof, Dmitry.
>>> - Rebase to next-20250717.
>>> - Change DP compatible to qcs8300-dp due to add 4 streams support.
>>> - Add QCS8300 UBWC config change due to rebase.
>>> - Add 4 streams clk and phy in the mdss yaml.
>>> - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
>>>
>>> Changes in v4:Fixed review comments from Krzysztof, Dmitry.
>>> - Use the common style for the dt-bindings commits.[Dmitry]
>>> - Update the commits msg for the mdss binding patch, explain why they
>>> reuse different platform drivers.[Krzysztof]
>>> - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
>>>
>>> Changes in v3:Fixed review comments from Krzysztof, Dmitry.
>>> - Fix the missing space issue in commit message.[Krzysztof]
>>> - Separate the patch for the phy from this series.[Dmitry]
>>> - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
>>> - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
>>>
>>> Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
>>> - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
>>> - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
>>> - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
>>> - Correct formatting errors and remove unnecessary status in MDSS
>>> bindings.[Krzysztof]
>>> - Add the the necessary information in MDSS changes commit msg.[Dmitry]
>>> - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
>>> 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
>>> - Package the DisplayPort controller and eDP PHY bindings document to
>>> this patch series.
>>> - Collecting MDSS changes reviewd-by Dmitry.
>>> - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
>>> - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
>>> - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
>>> ---
>>> This series depend on 4 pixel streams dt-binding series:
>>> https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
>>>
>>> and separate eDP PHY binding:
>>> https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
>>>
>>> ---
>>> Yongxing Mou (6):
>>> dt-bindings: display/msm: Document the DPU for QCS8300
>>> dt-bindings: display/msm: dp-controller: document QCS8300 compatible
>>> dt-bindings: display/msm: Document MDSS on QCS8300
>>> soc: qcom: ubwc: Add QCS8300 UBWC cfg
>>> drm/msm: mdss: Add QCS8300 support
>>> drm/msm/dp: Add DisplayPort controller for QCS8300
>>>
>>> .../bindings/display/msm/dp-controller.yaml | 22 ++
>>> .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
>>> .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
>>> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
>>> drivers/gpu/drm/msm/msm_mdss.c | 1 +
>>> drivers/soc/qcom/ubwc_config.c | 1 +
>>> 6 files changed, 321 insertions(+), 5 deletions(-)
>>> ---
>>> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
>>> change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
>>> prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
>>> prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
>>> prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
>>> prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
>>> prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
>>> prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
>>> prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
>>> prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
>>> prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
>>> prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
>>> prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
>>> prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
>>>
>>> Best regards,
>>
>> Hi, maintainers:
>> sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
>
> You can fix that manually by sending them both through
>
> b4 send -o /tmp/
> git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
> git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
>
> Konrad
Thanks for guide, when i use cmd "git send-email
--in-reply-to="20250904-qcs8300_mdss-v11-0-bc8761964d76@oss.qualcomm.com"
~/tmpyongmou/0005-drm-msm-mdss-add-qcs8300-support.eml", seems something
wrong, error log:
mou@oss.qualcomm.com>, Dmitry Baryshkov
<dmitry.baryshkov@oss.qualcomm.com>'
(body) Adding cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
from line 'Reviewed-by: Dmitry Baryshkov
<dmitry.baryshkov@oss.qualcomm.com>'
5.1.3 The recipient address <y> is not a valid RFC 5321 address. For more
5.1.3 information, go to
5.1.3 https://support.google.com/a/answer/3221692 and review RFC 5321
5.1.3 specifications. d9443c01a7336-24b1ba1718bsm64512315ad.39 -
gsmtpWould you mind sharing some suggestions for this? Thanks~~
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-04 9:31 ` Yongxing Mou
@ 2025-09-04 9:44 ` Konrad Dybcio
2025-09-05 3:48 ` Yongxing Mou
2025-09-04 13:41 ` Dmitry Baryshkov
1 sibling, 1 reply; 22+ messages in thread
From: Konrad Dybcio @ 2025-09-04 9:44 UTC (permalink / raw)
To: Yongxing Mou, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski, Dmitry Baryshkov
On 9/4/25 11:31 AM, Yongxing Mou wrote:
>
>
> On 9/4/2025 4:21 PM, Konrad Dybcio wrote:
>> On 9/4/25 9:55 AM, Yongxing Mou wrote:
>>>
>>>
>>> On 9/4/2025 3:22 PM, Yongxing Mou wrote:
>>>> This series introduces support to enable the Mobile Display Subsystem (MDSS)
>>>> , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
>>>> QCS8300 target. It includes the addition of the hardware catalog, compatible
>>>> string, and their YAML bindings.
>>>>
>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>> ---
>>>> Changes in v11: Fixed review comments from Dmitry.
>>>> - Rebase to MST bindings V8.
>>>> - Update the clocks-name for QCS8300 in dp-controller.
>>>> - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
>>>>
>>>> Changes in v10:
>>>> - Rebase to MST bindings V7.
>>>> - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
>>>> - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
>>>>
>>>> Changes in v9: Fixed review comments from Dmitry.
>>>> - Updated the description of dp-controller DT binding.
>>>> - Add new clause only work for QCS8300(one DP controller with 4 streams).
>>>> - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
>>>>
>>>> Changes in v8: Fixed review comments from Krzysztof, Dmitry.
>>>> - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
>>>> - Fixed incorrect description for ubwc change.[Dmitry]
>>>> - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
>>>>
>>>> Changes in v7: Fixed review comments from Dmitry.
>>>> - Rebase to next-20250818 and 4 pixel stream series V6.
>>>> - Add more description for the dp-controller dt-bingding change.[Dmitry]
>>>> - Reorder the MDSS change and UBWC change.[Dmitry]
>>>> - Switch to the OSS email.
>>>> - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
>>>>
>>>> Changes in v6: Fixed review comments from Konrad, Dmitry.
>>>> - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
>>>> - Optimize the description in MDSS dt-binding.[Dmitry]
>>>> - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
>>>> - Add the DP controller driver change.
>>>> - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
>>>>
>>>> Changes in v5:Fixed review comments from Krzysztof, Dmitry.
>>>> - Rebase to next-20250717.
>>>> - Change DP compatible to qcs8300-dp due to add 4 streams support.
>>>> - Add QCS8300 UBWC config change due to rebase.
>>>> - Add 4 streams clk and phy in the mdss yaml.
>>>> - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
>>>>
>>>> Changes in v4:Fixed review comments from Krzysztof, Dmitry.
>>>> - Use the common style for the dt-bindings commits.[Dmitry]
>>>> - Update the commits msg for the mdss binding patch, explain why they
>>>> reuse different platform drivers.[Krzysztof]
>>>> - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
>>>>
>>>> Changes in v3:Fixed review comments from Krzysztof, Dmitry.
>>>> - Fix the missing space issue in commit message.[Krzysztof]
>>>> - Separate the patch for the phy from this series.[Dmitry]
>>>> - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
>>>> - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
>>>>
>>>> Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
>>>> - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
>>>> - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
>>>> - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
>>>> - Correct formatting errors and remove unnecessary status in MDSS
>>>> bindings.[Krzysztof]
>>>> - Add the the necessary information in MDSS changes commit msg.[Dmitry]
>>>> - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
>>>> 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
>>>> - Package the DisplayPort controller and eDP PHY bindings document to
>>>> this patch series.
>>>> - Collecting MDSS changes reviewd-by Dmitry.
>>>> - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
>>>> - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
>>>> - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
>>>> ---
>>>> This series depend on 4 pixel streams dt-binding series:
>>>> https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
>>>>
>>>> and separate eDP PHY binding:
>>>> https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
>>>>
>>>> ---
>>>> Yongxing Mou (6):
>>>> dt-bindings: display/msm: Document the DPU for QCS8300
>>>> dt-bindings: display/msm: dp-controller: document QCS8300 compatible
>>>> dt-bindings: display/msm: Document MDSS on QCS8300
>>>> soc: qcom: ubwc: Add QCS8300 UBWC cfg
>>>> drm/msm: mdss: Add QCS8300 support
>>>> drm/msm/dp: Add DisplayPort controller for QCS8300
>>>>
>>>> .../bindings/display/msm/dp-controller.yaml | 22 ++
>>>> .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
>>>> .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
>>>> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
>>>> drivers/gpu/drm/msm/msm_mdss.c | 1 +
>>>> drivers/soc/qcom/ubwc_config.c | 1 +
>>>> 6 files changed, 321 insertions(+), 5 deletions(-)
>>>> ---
>>>> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
>>>> change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
>>>> prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
>>>> prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
>>>> prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
>>>> prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
>>>> prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
>>>> prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
>>>> prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
>>>> prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
>>>> prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
>>>> prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
>>>> prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
>>>> prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
>>>>
>>>> Best regards,
>>>
>>> Hi, maintainers:
>>> sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
>>
>> You can fix that manually by sending them both through
>>
>> b4 send -o /tmp/
>> git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
>> git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
>>
>> Konrad
> Thanks for guide, when i use cmd "git send-email --in-reply-to="20250904-qcs8300_mdss-v11-0-bc8761964d76@oss.qualcomm.com" ~/tmpyongmou/0005-drm-msm-mdss-add-qcs8300-support.eml", seems something wrong, error log:
> mou@oss.qualcomm.com>, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
> (body) Adding cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> from line 'Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
> 5.1.3 The recipient address <y> is not a valid RFC 5321 address. For more
> 5.1.3 information, go to
> 5.1.3 https://support.google.com/a/answer/3221692 and review RFC 5321
> 5.1.3 specifications. d9443c01a7336-24b1ba1718bsm64512315ad.39 - gsmtpWould you mind sharing some suggestions for this? Thanks~~
Looks wrong, perhaps you pressed 'y' instinctively when git send-email asked you
whom (additionally) send the message to. Just to make sure b4 isn't broken I
tried something similar (ignore dry-run, I simply didn't want to send any emails):
git send-email --dry-run /tmp/0014-illustrative_test.eml
To whom should the emails be sent (if anyone)? <enter>
Message-ID to be used as In-Reply-To for the first email (if any)? <enter>
<lots of email spam>
Result: OK
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-04 9:31 ` Yongxing Mou
2025-09-04 9:44 ` Konrad Dybcio
@ 2025-09-04 13:41 ` Dmitry Baryshkov
2025-09-05 3:55 ` Yongxing Mou
1 sibling, 1 reply; 22+ messages in thread
From: Dmitry Baryshkov @ 2025-09-04 13:41 UTC (permalink / raw)
To: Yongxing Mou
Cc: Konrad Dybcio, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski
On Thu, Sep 04, 2025 at 05:31:01PM +0800, Yongxing Mou wrote:
>
>
> On 9/4/2025 4:21 PM, Konrad Dybcio wrote:
> > On 9/4/25 9:55 AM, Yongxing Mou wrote:
> > >
> > >
> > > On 9/4/2025 3:22 PM, Yongxing Mou wrote:
> > > > This series introduces support to enable the Mobile Display Subsystem (MDSS)
> > > > , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
> > > > QCS8300 target. It includes the addition of the hardware catalog, compatible
> > > > string, and their YAML bindings.
> > > >
> > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > > ---
> > > > Changes in v11: Fixed review comments from Dmitry.
> > > > - Rebase to MST bindings V8.
> > > > - Update the clocks-name for QCS8300 in dp-controller.
> > > > - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
> > > >
> > > > Changes in v10:
> > > > - Rebase to MST bindings V7.
> > > > - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
> > > > - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
> > > >
> > > > Changes in v9: Fixed review comments from Dmitry.
> > > > - Updated the description of dp-controller DT binding.
> > > > - Add new clause only work for QCS8300(one DP controller with 4 streams).
> > > > - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
> > > >
> > > > Changes in v8: Fixed review comments from Krzysztof, Dmitry.
> > > > - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
> > > > - Fixed incorrect description for ubwc change.[Dmitry]
> > > > - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
> > > >
> > > > Changes in v7: Fixed review comments from Dmitry.
> > > > - Rebase to next-20250818 and 4 pixel stream series V6.
> > > > - Add more description for the dp-controller dt-bingding change.[Dmitry]
> > > > - Reorder the MDSS change and UBWC change.[Dmitry]
> > > > - Switch to the OSS email.
> > > > - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
> > > >
> > > > Changes in v6: Fixed review comments from Konrad, Dmitry.
> > > > - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
> > > > - Optimize the description in MDSS dt-binding.[Dmitry]
> > > > - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
> > > > - Add the DP controller driver change.
> > > > - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
> > > >
> > > > Changes in v5:Fixed review comments from Krzysztof, Dmitry.
> > > > - Rebase to next-20250717.
> > > > - Change DP compatible to qcs8300-dp due to add 4 streams support.
> > > > - Add QCS8300 UBWC config change due to rebase.
> > > > - Add 4 streams clk and phy in the mdss yaml.
> > > > - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
> > > >
> > > > Changes in v4:Fixed review comments from Krzysztof, Dmitry.
> > > > - Use the common style for the dt-bindings commits.[Dmitry]
> > > > - Update the commits msg for the mdss binding patch, explain why they
> > > > reuse different platform drivers.[Krzysztof]
> > > > - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
> > > >
> > > > Changes in v3:Fixed review comments from Krzysztof, Dmitry.
> > > > - Fix the missing space issue in commit message.[Krzysztof]
> > > > - Separate the patch for the phy from this series.[Dmitry]
> > > > - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
> > > > - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
> > > >
> > > > Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
> > > > - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
> > > > - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
> > > > - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
> > > > - Correct formatting errors and remove unnecessary status in MDSS
> > > > bindings.[Krzysztof]
> > > > - Add the the necessary information in MDSS changes commit msg.[Dmitry]
> > > > - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
> > > > 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
> > > > - Package the DisplayPort controller and eDP PHY bindings document to
> > > > this patch series.
> > > > - Collecting MDSS changes reviewd-by Dmitry.
> > > > - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
> > > > - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
> > > > - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
> > > > ---
> > > > This series depend on 4 pixel streams dt-binding series:
> > > > https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
> > > >
> > > > and separate eDP PHY binding:
> > > > https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
> > > >
> > > > ---
> > > > Yongxing Mou (6):
> > > > dt-bindings: display/msm: Document the DPU for QCS8300
> > > > dt-bindings: display/msm: dp-controller: document QCS8300 compatible
> > > > dt-bindings: display/msm: Document MDSS on QCS8300
> > > > soc: qcom: ubwc: Add QCS8300 UBWC cfg
> > > > drm/msm: mdss: Add QCS8300 support
> > > > drm/msm/dp: Add DisplayPort controller for QCS8300
> > > >
> > > > .../bindings/display/msm/dp-controller.yaml | 22 ++
> > > > .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
> > > > .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
> > > > drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> > > > drivers/gpu/drm/msm/msm_mdss.c | 1 +
> > > > drivers/soc/qcom/ubwc_config.c | 1 +
> > > > 6 files changed, 321 insertions(+), 5 deletions(-)
> > > > ---
> > > > base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
> > > > change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
> > > > prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
> > > > prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
> > > > prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
> > > > prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
> > > > prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
> > > > prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
> > > > prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
> > > > prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
> > > > prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
> > > > prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
> > > > prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
> > > > prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
> > > >
> > > > Best regards,
> > >
> > > Hi, maintainers:
> > > sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
> >
> > You can fix that manually by sending them both through
> >
> > b4 send -o /tmp/
> > git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
> > git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
> >
> > Konrad
> Thanks for guide, when i use cmd "git send-email
> --in-reply-to="20250904-qcs8300_mdss-v11-0-bc8761964d76@oss.qualcomm.com"
> ~/tmpyongmou/0005-drm-msm-mdss-add-qcs8300-support.eml", seems something
> wrong, error log:
> mou@oss.qualcomm.com>, Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com>'
> (body) Adding cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> from
> line 'Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
> 5.1.3 The recipient address <y> is not a valid RFC 5321 address. For more
> 5.1.3 information, go to
> 5.1.3 https://support.google.com/a/answer/3221692 and review RFC 5321
> 5.1.3 specifications. d9443c01a7336-24b1ba1718bsm64512315ad.39 - gsmtpWould
> you mind sharing some suggestions for this? Thanks~~
When `git send-email` asks you, just press 'Enter', no extra chars. Or
it migth be easier to just `b4 send --resend`.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-04 7:22 ` [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible Yongxing Mou
@ 2025-09-04 13:43 ` Dmitry Baryshkov
2025-09-05 2:50 ` Yongxing Mou
0 siblings, 1 reply; 22+ messages in thread
From: Dmitry Baryshkov @ 2025-09-04 13:43 UTC (permalink / raw)
To: Yongxing Mou
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
> Add compatible string for the DisplayPort controller found on the
> Qualcomm QCS8300 SoC.
>
> The Qualcomm QCS8300 platform comes with one DisplayPort controller
> that supports 4 MST streams.
>
> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> ---
> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -18,6 +18,7 @@ properties:
> compatible:
> oneOf:
> - enum:
> + - qcom,qcs8300-dp
Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
new one?
> - qcom,sa8775p-dp
> - qcom,sc7180-dp
> - qcom,sc7280-dp
> @@ -195,6 +196,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,qcs8300-dp
> - qcom,sa8775p-dp
> - qcom,x1e80100-dp
> then:
> @@ -295,6 +297,26 @@ allOf:
> minItems: 6
> maxItems: 8
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + # QCS8300 only has one DP controller that supports 4
> + # streams MST.
> + - qcom,qcs8300-dp
> + then:
> + properties:
> + reg:
> + minItems: 9
> + maxItems: 9
> + clocks:
> + minItems: 8
> + maxItems: 8
> + clocks-names:
> + minItems: 8
> + maxItems: 8
> +
> additionalProperties: false
>
> examples:
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-04 13:43 ` Dmitry Baryshkov
@ 2025-09-05 2:50 ` Yongxing Mou
2025-09-05 8:25 ` Krzysztof Kozlowski
2025-09-05 13:48 ` Dmitry Baryshkov
0 siblings, 2 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-05 2:50 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
> On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
>> Add compatible string for the DisplayPort controller found on the
>> Qualcomm QCS8300 SoC.
>>
>> The Qualcomm QCS8300 platform comes with one DisplayPort controller
>> that supports 4 MST streams.
>>
>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>> ---
>> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> @@ -18,6 +18,7 @@ properties:
>> compatible:
>> oneOf:
>> - enum:
>> + - qcom,qcs8300-dp
>
> Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
> new one?
>
I think we can not use fallback to sa8775p, since we don't have DP1
controller for QCS8300. SA8775P actually have 4 DP controllers (now only
2 really used). So in the hardware, i think it is different with SA8775P
and we need a new one.>> - qcom,sa8775p-dp
>> - qcom,sc7180-dp
>> - qcom,sc7280-dp
>> @@ -195,6 +196,7 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> + - qcom,qcs8300-dp
>> - qcom,sa8775p-dp
>> - qcom,x1e80100-dp
>> then:
>> @@ -295,6 +297,26 @@ allOf:
>> minItems: 6
>> maxItems: 8
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + # QCS8300 only has one DP controller that supports 4
>> + # streams MST.
>> + - qcom,qcs8300-dp
>> + then:
>> + properties:
>> + reg:
>> + minItems: 9
>> + maxItems: 9
>> + clocks:
>> + minItems: 8
>> + maxItems: 8
>> + clocks-names:
>> + minItems: 8
>> + maxItems: 8
>> +
>> additionalProperties: false
>>
>> examples:
>>
>> --
>> 2.34.1
>>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-04 9:44 ` Konrad Dybcio
@ 2025-09-05 3:48 ` Yongxing Mou
0 siblings, 0 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-05 3:48 UTC (permalink / raw)
To: Konrad Dybcio, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski, Dmitry Baryshkov
On 9/4/2025 5:44 PM, Konrad Dybcio wrote:
> On 9/4/25 11:31 AM, Yongxing Mou wrote:
>>
>>
>> On 9/4/2025 4:21 PM, Konrad Dybcio wrote:
>>> On 9/4/25 9:55 AM, Yongxing Mou wrote:
>>>>
>>>>
>>>> On 9/4/2025 3:22 PM, Yongxing Mou wrote:
>>>>> This series introduces support to enable the Mobile Display Subsystem (MDSS)
>>>>> , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
>>>>> QCS8300 target. It includes the addition of the hardware catalog, compatible
>>>>> string, and their YAML bindings.
>>>>>
>>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>>> ---
>>>>> Changes in v11: Fixed review comments from Dmitry.
>>>>> - Rebase to MST bindings V8.
>>>>> - Update the clocks-name for QCS8300 in dp-controller.
>>>>> - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
>>>>>
>>>>> Changes in v10:
>>>>> - Rebase to MST bindings V7.
>>>>> - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
>>>>> - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
>>>>>
>>>>> Changes in v9: Fixed review comments from Dmitry.
>>>>> - Updated the description of dp-controller DT binding.
>>>>> - Add new clause only work for QCS8300(one DP controller with 4 streams).
>>>>> - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
>>>>>
>>>>> Changes in v8: Fixed review comments from Krzysztof, Dmitry.
>>>>> - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
>>>>> - Fixed incorrect description for ubwc change.[Dmitry]
>>>>> - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
>>>>>
>>>>> Changes in v7: Fixed review comments from Dmitry.
>>>>> - Rebase to next-20250818 and 4 pixel stream series V6.
>>>>> - Add more description for the dp-controller dt-bingding change.[Dmitry]
>>>>> - Reorder the MDSS change and UBWC change.[Dmitry]
>>>>> - Switch to the OSS email.
>>>>> - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
>>>>>
>>>>> Changes in v6: Fixed review comments from Konrad, Dmitry.
>>>>> - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
>>>>> - Optimize the description in MDSS dt-binding.[Dmitry]
>>>>> - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
>>>>> - Add the DP controller driver change.
>>>>> - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
>>>>>
>>>>> Changes in v5:Fixed review comments from Krzysztof, Dmitry.
>>>>> - Rebase to next-20250717.
>>>>> - Change DP compatible to qcs8300-dp due to add 4 streams support.
>>>>> - Add QCS8300 UBWC config change due to rebase.
>>>>> - Add 4 streams clk and phy in the mdss yaml.
>>>>> - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
>>>>>
>>>>> Changes in v4:Fixed review comments from Krzysztof, Dmitry.
>>>>> - Use the common style for the dt-bindings commits.[Dmitry]
>>>>> - Update the commits msg for the mdss binding patch, explain why they
>>>>> reuse different platform drivers.[Krzysztof]
>>>>> - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
>>>>>
>>>>> Changes in v3:Fixed review comments from Krzysztof, Dmitry.
>>>>> - Fix the missing space issue in commit message.[Krzysztof]
>>>>> - Separate the patch for the phy from this series.[Dmitry]
>>>>> - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
>>>>> - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
>>>>>
>>>>> Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
>>>>> - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
>>>>> - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
>>>>> - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
>>>>> - Correct formatting errors and remove unnecessary status in MDSS
>>>>> bindings.[Krzysztof]
>>>>> - Add the the necessary information in MDSS changes commit msg.[Dmitry]
>>>>> - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
>>>>> 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
>>>>> - Package the DisplayPort controller and eDP PHY bindings document to
>>>>> this patch series.
>>>>> - Collecting MDSS changes reviewd-by Dmitry.
>>>>> - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
>>>>> - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
>>>>> - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
>>>>> ---
>>>>> This series depend on 4 pixel streams dt-binding series:
>>>>> https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
>>>>>
>>>>> and separate eDP PHY binding:
>>>>> https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
>>>>>
>>>>> ---
>>>>> Yongxing Mou (6):
>>>>> dt-bindings: display/msm: Document the DPU for QCS8300
>>>>> dt-bindings: display/msm: dp-controller: document QCS8300 compatible
>>>>> dt-bindings: display/msm: Document MDSS on QCS8300
>>>>> soc: qcom: ubwc: Add QCS8300 UBWC cfg
>>>>> drm/msm: mdss: Add QCS8300 support
>>>>> drm/msm/dp: Add DisplayPort controller for QCS8300
>>>>>
>>>>> .../bindings/display/msm/dp-controller.yaml | 22 ++
>>>>> .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
>>>>> .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
>>>>> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
>>>>> drivers/gpu/drm/msm/msm_mdss.c | 1 +
>>>>> drivers/soc/qcom/ubwc_config.c | 1 +
>>>>> 6 files changed, 321 insertions(+), 5 deletions(-)
>>>>> ---
>>>>> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
>>>>> change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
>>>>> prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
>>>>> prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
>>>>> prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
>>>>> prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
>>>>> prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
>>>>> prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
>>>>> prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
>>>>> prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
>>>>> prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
>>>>> prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
>>>>> prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
>>>>> prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
>>>>>
>>>>> Best regards,
>>>>
>>>> Hi, maintainers:
>>>> sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
>>>
>>> You can fix that manually by sending them both through
>>>
>>> b4 send -o /tmp/
>>> git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
>>> git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
>>>
>>> Konrad
>> Thanks for guide, when i use cmd "git send-email --in-reply-to="20250904-qcs8300_mdss-v11-0-bc8761964d76@oss.qualcomm.com" ~/tmpyongmou/0005-drm-msm-mdss-add-qcs8300-support.eml", seems something wrong, error log:
>> mou@oss.qualcomm.com>, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
>> (body) Adding cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> from line 'Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
>> 5.1.3 The recipient address <y> is not a valid RFC 5321 address. For more
>> 5.1.3 information, go to
>> 5.1.3 https://support.google.com/a/answer/3221692 and review RFC 5321
>> 5.1.3 specifications. d9443c01a7336-24b1ba1718bsm64512315ad.39 - gsmtpWould you mind sharing some suggestions for this? Thanks~~
>
> Looks wrong, perhaps you pressed 'y' instinctively when git send-email asked you
> whom (additionally) send the message to. Just to make sure b4 isn't broken I
> tried something similar (ignore dry-run, I simply didn't want to send any emails):
>
> git send-email --dry-run /tmp/0014-illustrative_test.eml
> To whom should the emails be sent (if anyone)? <enter>
> Message-ID to be used as In-Reply-To for the first email (if any)? <enter>
> <lots of email spam>
>
> Result: OK
Thanks for the guide. i think i should not type 'y' when b4 ask me.. now
i have post patch 5/6,6/6 to upstream, thank.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-04 13:41 ` Dmitry Baryshkov
@ 2025-09-05 3:55 ` Yongxing Mou
2025-09-05 13:49 ` Dmitry Baryshkov
0 siblings, 1 reply; 22+ messages in thread
From: Yongxing Mou @ 2025-09-05 3:55 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Konrad Dybcio, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski
On 9/4/2025 9:41 PM, Dmitry Baryshkov wrote:
> On Thu, Sep 04, 2025 at 05:31:01PM +0800, Yongxing Mou wrote:
>>
>>
>> On 9/4/2025 4:21 PM, Konrad Dybcio wrote:
>>> On 9/4/25 9:55 AM, Yongxing Mou wrote:
>>>>
>>>>
>>>> On 9/4/2025 3:22 PM, Yongxing Mou wrote:
>>>>> This series introduces support to enable the Mobile Display Subsystem (MDSS)
>>>>> , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
>>>>> QCS8300 target. It includes the addition of the hardware catalog, compatible
>>>>> string, and their YAML bindings.
>>>>>
>>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>>> ---
>>>>> Changes in v11: Fixed review comments from Dmitry.
>>>>> - Rebase to MST bindings V8.
>>>>> - Update the clocks-name for QCS8300 in dp-controller.
>>>>> - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
>>>>>
>>>>> Changes in v10:
>>>>> - Rebase to MST bindings V7.
>>>>> - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
>>>>> - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
>>>>>
>>>>> Changes in v9: Fixed review comments from Dmitry.
>>>>> - Updated the description of dp-controller DT binding.
>>>>> - Add new clause only work for QCS8300(one DP controller with 4 streams).
>>>>> - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
>>>>>
>>>>> Changes in v8: Fixed review comments from Krzysztof, Dmitry.
>>>>> - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
>>>>> - Fixed incorrect description for ubwc change.[Dmitry]
>>>>> - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
>>>>>
>>>>> Changes in v7: Fixed review comments from Dmitry.
>>>>> - Rebase to next-20250818 and 4 pixel stream series V6.
>>>>> - Add more description for the dp-controller dt-bingding change.[Dmitry]
>>>>> - Reorder the MDSS change and UBWC change.[Dmitry]
>>>>> - Switch to the OSS email.
>>>>> - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
>>>>>
>>>>> Changes in v6: Fixed review comments from Konrad, Dmitry.
>>>>> - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
>>>>> - Optimize the description in MDSS dt-binding.[Dmitry]
>>>>> - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
>>>>> - Add the DP controller driver change.
>>>>> - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
>>>>>
>>>>> Changes in v5:Fixed review comments from Krzysztof, Dmitry.
>>>>> - Rebase to next-20250717.
>>>>> - Change DP compatible to qcs8300-dp due to add 4 streams support.
>>>>> - Add QCS8300 UBWC config change due to rebase.
>>>>> - Add 4 streams clk and phy in the mdss yaml.
>>>>> - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
>>>>>
>>>>> Changes in v4:Fixed review comments from Krzysztof, Dmitry.
>>>>> - Use the common style for the dt-bindings commits.[Dmitry]
>>>>> - Update the commits msg for the mdss binding patch, explain why they
>>>>> reuse different platform drivers.[Krzysztof]
>>>>> - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
>>>>>
>>>>> Changes in v3:Fixed review comments from Krzysztof, Dmitry.
>>>>> - Fix the missing space issue in commit message.[Krzysztof]
>>>>> - Separate the patch for the phy from this series.[Dmitry]
>>>>> - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
>>>>> - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
>>>>>
>>>>> Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
>>>>> - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
>>>>> - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
>>>>> - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
>>>>> - Correct formatting errors and remove unnecessary status in MDSS
>>>>> bindings.[Krzysztof]
>>>>> - Add the the necessary information in MDSS changes commit msg.[Dmitry]
>>>>> - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
>>>>> 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
>>>>> - Package the DisplayPort controller and eDP PHY bindings document to
>>>>> this patch series.
>>>>> - Collecting MDSS changes reviewd-by Dmitry.
>>>>> - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
>>>>> - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
>>>>> - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
>>>>> ---
>>>>> This series depend on 4 pixel streams dt-binding series:
>>>>> https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
>>>>>
>>>>> and separate eDP PHY binding:
>>>>> https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
>>>>>
>>>>> ---
>>>>> Yongxing Mou (6):
>>>>> dt-bindings: display/msm: Document the DPU for QCS8300
>>>>> dt-bindings: display/msm: dp-controller: document QCS8300 compatible
>>>>> dt-bindings: display/msm: Document MDSS on QCS8300
>>>>> soc: qcom: ubwc: Add QCS8300 UBWC cfg
>>>>> drm/msm: mdss: Add QCS8300 support
>>>>> drm/msm/dp: Add DisplayPort controller for QCS8300
>>>>>
>>>>> .../bindings/display/msm/dp-controller.yaml | 22 ++
>>>>> .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
>>>>> .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
>>>>> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
>>>>> drivers/gpu/drm/msm/msm_mdss.c | 1 +
>>>>> drivers/soc/qcom/ubwc_config.c | 1 +
>>>>> 6 files changed, 321 insertions(+), 5 deletions(-)
>>>>> ---
>>>>> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
>>>>> change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
>>>>> prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
>>>>> prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
>>>>> prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
>>>>> prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
>>>>> prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
>>>>> prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
>>>>> prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
>>>>> prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
>>>>> prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
>>>>> prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
>>>>> prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
>>>>> prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
>>>>>
>>>>> Best regards,
>>>>
>>>> Hi, maintainers:
>>>> sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
>>>
>>> You can fix that manually by sending them both through
>>>
>>> b4 send -o /tmp/
>>> git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
>>> git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
>>>
>>> Konrad
>> Thanks for guide, when i use cmd "git send-email
>> --in-reply-to="20250904-qcs8300_mdss-v11-0-bc8761964d76@oss.qualcomm.com"
>> ~/tmpyongmou/0005-drm-msm-mdss-add-qcs8300-support.eml", seems something
>> wrong, error log:
>> mou@oss.qualcomm.com>, Dmitry Baryshkov
>> <dmitry.baryshkov@oss.qualcomm.com>'
>> (body) Adding cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> from
>> line 'Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
>> 5.1.3 The recipient address <y> is not a valid RFC 5321 address. For more
>> 5.1.3 information, go to
>> 5.1.3 https://support.google.com/a/answer/3221692 and review RFC 5321
>> 5.1.3 specifications. d9443c01a7336-24b1ba1718bsm64512315ad.39 - gsmtpWould
>> you mind sharing some suggestions for this? Thanks~~
>
> When `git send-email` asks you, just press 'Enter', no extra chars. Or
> it migth be easier to just `b4 send --resend`.
>
Thanks for the guidance — that was the mistake I made. It has now been
sent upstream. It looks like the patch wasn't archived into the V11
series. So does this ok?
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-05 2:50 ` Yongxing Mou
@ 2025-09-05 8:25 ` Krzysztof Kozlowski
2025-09-08 9:46 ` Yongxing Mou
2025-09-05 13:48 ` Dmitry Baryshkov
1 sibling, 1 reply; 22+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-05 8:25 UTC (permalink / raw)
To: Yongxing Mou
Cc: Dmitry Baryshkov, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
dri-devel, freedreno, devicetree, linux-kernel
On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
>
>
> On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
> > On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
> > > Add compatible string for the DisplayPort controller found on the
> > > Qualcomm QCS8300 SoC.
> > >
> > > The Qualcomm QCS8300 platform comes with one DisplayPort controller
> > > that supports 4 MST streams.
> > >
> > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > ---
> > > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
> > > 1 file changed, 22 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
> > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > @@ -18,6 +18,7 @@ properties:
> > > compatible:
> > > oneOf:
> > > - enum:
> > > + - qcom,qcs8300-dp
> >
> > Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
> > new one?
> >
> I think we can not use fallback to sa8775p, since we don't have DP1
> controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
> really used). So in the hardware, i think it is different with SA8775P and
> we need a new one.>> - qcom,sa8775p-dp
I don't understand how this rationale explains what Dmitry asked.
Why number of IP blocks (and this is DPx, right?) matter? Are you sure
you understand what compatibility means? Please read the slides from
OSSE25 or just read writing bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-05 2:50 ` Yongxing Mou
2025-09-05 8:25 ` Krzysztof Kozlowski
@ 2025-09-05 13:48 ` Dmitry Baryshkov
2025-09-08 9:46 ` Yongxing Mou
1 sibling, 1 reply; 22+ messages in thread
From: Dmitry Baryshkov @ 2025-09-05 13:48 UTC (permalink / raw)
To: Yongxing Mou
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
>
>
> On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
> > On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
> > > Add compatible string for the DisplayPort controller found on the
> > > Qualcomm QCS8300 SoC.
> > >
> > > The Qualcomm QCS8300 platform comes with one DisplayPort controller
> > > that supports 4 MST streams.
> > >
> > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > ---
> > > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
> > > 1 file changed, 22 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
> > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > @@ -18,6 +18,7 @@ properties:
> > > compatible:
> > > oneOf:
> > > - enum:
> > > + - qcom,qcs8300-dp
> >
> > Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
> > new one?
> >
> I think we can not use fallback to sa8775p, since we don't have DP1
> controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
> really used). So in the hardware, i think it is different with SA8775P and
> we need a new one.>> - qcom,sa8775p-dp
The DP controller is the same as the one present on SA8775P.
> > > - qcom,sc7180-dp
> > > - qcom,sc7280-dp
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-05 3:55 ` Yongxing Mou
@ 2025-09-05 13:49 ` Dmitry Baryshkov
2025-09-05 14:25 ` Dmitry Baryshkov
0 siblings, 1 reply; 22+ messages in thread
From: Dmitry Baryshkov @ 2025-09-05 13:49 UTC (permalink / raw)
To: Yongxing Mou
Cc: Konrad Dybcio, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski
On Fri, Sep 05, 2025 at 11:55:52AM +0800, Yongxing Mou wrote:
>
>
> On 9/4/2025 9:41 PM, Dmitry Baryshkov wrote:
> > On Thu, Sep 04, 2025 at 05:31:01PM +0800, Yongxing Mou wrote:
> > >
> > >
> > > On 9/4/2025 4:21 PM, Konrad Dybcio wrote:
> > > > On 9/4/25 9:55 AM, Yongxing Mou wrote:
> > > > >
> > > > >
> > > > > On 9/4/2025 3:22 PM, Yongxing Mou wrote:
> > > > > > This series introduces support to enable the Mobile Display Subsystem (MDSS)
> > > > > > , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
> > > > > > QCS8300 target. It includes the addition of the hardware catalog, compatible
> > > > > > string, and their YAML bindings.
> > > > > >
> > > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > > > > ---
> > > > > > Changes in v11: Fixed review comments from Dmitry.
> > > > > > - Rebase to MST bindings V8.
> > > > > > - Update the clocks-name for QCS8300 in dp-controller.
> > > > > > - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
> > > > > >
> > > > > > Changes in v10:
> > > > > > - Rebase to MST bindings V7.
> > > > > > - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
> > > > > > - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
> > > > > >
> > > > > > Changes in v9: Fixed review comments from Dmitry.
> > > > > > - Updated the description of dp-controller DT binding.
> > > > > > - Add new clause only work for QCS8300(one DP controller with 4 streams).
> > > > > > - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
> > > > > >
> > > > > > Changes in v8: Fixed review comments from Krzysztof, Dmitry.
> > > > > > - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
> > > > > > - Fixed incorrect description for ubwc change.[Dmitry]
> > > > > > - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
> > > > > >
> > > > > > Changes in v7: Fixed review comments from Dmitry.
> > > > > > - Rebase to next-20250818 and 4 pixel stream series V6.
> > > > > > - Add more description for the dp-controller dt-bingding change.[Dmitry]
> > > > > > - Reorder the MDSS change and UBWC change.[Dmitry]
> > > > > > - Switch to the OSS email.
> > > > > > - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
> > > > > >
> > > > > > Changes in v6: Fixed review comments from Konrad, Dmitry.
> > > > > > - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
> > > > > > - Optimize the description in MDSS dt-binding.[Dmitry]
> > > > > > - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
> > > > > > - Add the DP controller driver change.
> > > > > > - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
> > > > > >
> > > > > > Changes in v5:Fixed review comments from Krzysztof, Dmitry.
> > > > > > - Rebase to next-20250717.
> > > > > > - Change DP compatible to qcs8300-dp due to add 4 streams support.
> > > > > > - Add QCS8300 UBWC config change due to rebase.
> > > > > > - Add 4 streams clk and phy in the mdss yaml.
> > > > > > - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
> > > > > >
> > > > > > Changes in v4:Fixed review comments from Krzysztof, Dmitry.
> > > > > > - Use the common style for the dt-bindings commits.[Dmitry]
> > > > > > - Update the commits msg for the mdss binding patch, explain why they
> > > > > > reuse different platform drivers.[Krzysztof]
> > > > > > - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
> > > > > >
> > > > > > Changes in v3:Fixed review comments from Krzysztof, Dmitry.
> > > > > > - Fix the missing space issue in commit message.[Krzysztof]
> > > > > > - Separate the patch for the phy from this series.[Dmitry]
> > > > > > - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
> > > > > > - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
> > > > > >
> > > > > > Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
> > > > > > - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
> > > > > > - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
> > > > > > - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
> > > > > > - Correct formatting errors and remove unnecessary status in MDSS
> > > > > > bindings.[Krzysztof]
> > > > > > - Add the the necessary information in MDSS changes commit msg.[Dmitry]
> > > > > > - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
> > > > > > 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
> > > > > > - Package the DisplayPort controller and eDP PHY bindings document to
> > > > > > this patch series.
> > > > > > - Collecting MDSS changes reviewd-by Dmitry.
> > > > > > - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
> > > > > > - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
> > > > > > - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
> > > > > > ---
> > > > > > This series depend on 4 pixel streams dt-binding series:
> > > > > > https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
> > > > > >
> > > > > > and separate eDP PHY binding:
> > > > > > https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
> > > > > >
> > > > > > ---
> > > > > > Yongxing Mou (6):
> > > > > > dt-bindings: display/msm: Document the DPU for QCS8300
> > > > > > dt-bindings: display/msm: dp-controller: document QCS8300 compatible
> > > > > > dt-bindings: display/msm: Document MDSS on QCS8300
> > > > > > soc: qcom: ubwc: Add QCS8300 UBWC cfg
> > > > > > drm/msm: mdss: Add QCS8300 support
> > > > > > drm/msm/dp: Add DisplayPort controller for QCS8300
> > > > > >
> > > > > > .../bindings/display/msm/dp-controller.yaml | 22 ++
> > > > > > .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
> > > > > > .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
> > > > > > drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> > > > > > drivers/gpu/drm/msm/msm_mdss.c | 1 +
> > > > > > drivers/soc/qcom/ubwc_config.c | 1 +
> > > > > > 6 files changed, 321 insertions(+), 5 deletions(-)
> > > > > > ---
> > > > > > base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
> > > > > > change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
> > > > > > prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
> > > > > > prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
> > > > > > prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
> > > > > > prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
> > > > > > prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
> > > > > > prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
> > > > > > prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
> > > > > > prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
> > > > > > prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
> > > > > > prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
> > > > > > prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
> > > > > > prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
> > > > > >
> > > > > > Best regards,
> > > > >
> > > > > Hi, maintainers:
> > > > > sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
> > > >
> > > > You can fix that manually by sending them both through
> > > >
> > > > b4 send -o /tmp/
> > > > git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
> > > > git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
> > > >
> > > > Konrad
> > > Thanks for guide, when i use cmd "git send-email
> > > --in-reply-to="20250904-qcs8300_mdss-v11-0-bc8761964d76@oss.qualcomm.com"
> > > ~/tmpyongmou/0005-drm-msm-mdss-add-qcs8300-support.eml", seems something
> > > wrong, error log:
> > > mou@oss.qualcomm.com>, Dmitry Baryshkov
> > > <dmitry.baryshkov@oss.qualcomm.com>'
> > > (body) Adding cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> from
> > > line 'Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
> > > 5.1.3 The recipient address <y> is not a valid RFC 5321 address. For more
> > > 5.1.3 information, go to
> > > 5.1.3 https://support.google.com/a/answer/3221692 and review RFC 5321
> > > 5.1.3 specifications. d9443c01a7336-24b1ba1718bsm64512315ad.39 - gsmtpWould
> > > you mind sharing some suggestions for this? Thanks~~
> >
> > When `git send-email` asks you, just press 'Enter', no extra chars. Or
> > it migth be easier to just `b4 send --resend`.
> >
> Thanks for the guidance — that was the mistake I made. It has now been sent
> upstream. It looks like the patch wasn't archived into the V11 series. So
> does this ok?
No, I don't see them on the mailing list.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform
2025-09-05 13:49 ` Dmitry Baryshkov
@ 2025-09-05 14:25 ` Dmitry Baryshkov
0 siblings, 0 replies; 22+ messages in thread
From: Dmitry Baryshkov @ 2025-09-05 14:25 UTC (permalink / raw)
To: Yongxing Mou
Cc: Konrad Dybcio, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
dri-devel, freedreno, devicetree, linux-kernel,
Krzysztof Kozlowski
On Fri, Sep 05, 2025 at 04:49:01PM +0300, Dmitry Baryshkov wrote:
> On Fri, Sep 05, 2025 at 11:55:52AM +0800, Yongxing Mou wrote:
> >
> >
> > On 9/4/2025 9:41 PM, Dmitry Baryshkov wrote:
> > > On Thu, Sep 04, 2025 at 05:31:01PM +0800, Yongxing Mou wrote:
> > > >
> > > >
> > > > On 9/4/2025 4:21 PM, Konrad Dybcio wrote:
> > > > > On 9/4/25 9:55 AM, Yongxing Mou wrote:
> > > > > >
> > > > > >
> > > > > > On 9/4/2025 3:22 PM, Yongxing Mou wrote:
> > > > > > > This series introduces support to enable the Mobile Display Subsystem (MDSS)
> > > > > > > , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
> > > > > > > QCS8300 target. It includes the addition of the hardware catalog, compatible
> > > > > > > string, and their YAML bindings.
> > > > > > >
> > > > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > > > > > ---
> > > > > > > Changes in v11: Fixed review comments from Dmitry.
> > > > > > > - Rebase to MST bindings V8.
> > > > > > > - Update the clocks-name for QCS8300 in dp-controller.
> > > > > > > - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
> > > > > > >
> > > > > > > Changes in v10:
> > > > > > > - Rebase to MST bindings V7.
> > > > > > > - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
> > > > > > > - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
> > > > > > >
> > > > > > > Changes in v9: Fixed review comments from Dmitry.
> > > > > > > - Updated the description of dp-controller DT binding.
> > > > > > > - Add new clause only work for QCS8300(one DP controller with 4 streams).
> > > > > > > - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
> > > > > > >
> > > > > > > Changes in v8: Fixed review comments from Krzysztof, Dmitry.
> > > > > > > - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
> > > > > > > - Fixed incorrect description for ubwc change.[Dmitry]
> > > > > > > - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
> > > > > > >
> > > > > > > Changes in v7: Fixed review comments from Dmitry.
> > > > > > > - Rebase to next-20250818 and 4 pixel stream series V6.
> > > > > > > - Add more description for the dp-controller dt-bingding change.[Dmitry]
> > > > > > > - Reorder the MDSS change and UBWC change.[Dmitry]
> > > > > > > - Switch to the OSS email.
> > > > > > > - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
> > > > > > >
> > > > > > > Changes in v6: Fixed review comments from Konrad, Dmitry.
> > > > > > > - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
> > > > > > > - Optimize the description in MDSS dt-binding.[Dmitry]
> > > > > > > - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
> > > > > > > - Add the DP controller driver change.
> > > > > > > - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
> > > > > > >
> > > > > > > Changes in v5:Fixed review comments from Krzysztof, Dmitry.
> > > > > > > - Rebase to next-20250717.
> > > > > > > - Change DP compatible to qcs8300-dp due to add 4 streams support.
> > > > > > > - Add QCS8300 UBWC config change due to rebase.
> > > > > > > - Add 4 streams clk and phy in the mdss yaml.
> > > > > > > - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
> > > > > > >
> > > > > > > Changes in v4:Fixed review comments from Krzysztof, Dmitry.
> > > > > > > - Use the common style for the dt-bindings commits.[Dmitry]
> > > > > > > - Update the commits msg for the mdss binding patch, explain why they
> > > > > > > reuse different platform drivers.[Krzysztof]
> > > > > > > - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
> > > > > > >
> > > > > > > Changes in v3:Fixed review comments from Krzysztof, Dmitry.
> > > > > > > - Fix the missing space issue in commit message.[Krzysztof]
> > > > > > > - Separate the patch for the phy from this series.[Dmitry]
> > > > > > > - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
> > > > > > > - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
> > > > > > >
> > > > > > > Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
> > > > > > > - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
> > > > > > > - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
> > > > > > > - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
> > > > > > > - Correct formatting errors and remove unnecessary status in MDSS
> > > > > > > bindings.[Krzysztof]
> > > > > > > - Add the the necessary information in MDSS changes commit msg.[Dmitry]
> > > > > > > - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
> > > > > > > 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
> > > > > > > - Package the DisplayPort controller and eDP PHY bindings document to
> > > > > > > this patch series.
> > > > > > > - Collecting MDSS changes reviewd-by Dmitry.
> > > > > > > - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
> > > > > > > - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
> > > > > > > - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
> > > > > > > ---
> > > > > > > This series depend on 4 pixel streams dt-binding series:
> > > > > > > https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
> > > > > > >
> > > > > > > and separate eDP PHY binding:
> > > > > > > https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
> > > > > > >
> > > > > > > ---
> > > > > > > Yongxing Mou (6):
> > > > > > > dt-bindings: display/msm: Document the DPU for QCS8300
> > > > > > > dt-bindings: display/msm: dp-controller: document QCS8300 compatible
> > > > > > > dt-bindings: display/msm: Document MDSS on QCS8300
> > > > > > > soc: qcom: ubwc: Add QCS8300 UBWC cfg
> > > > > > > drm/msm: mdss: Add QCS8300 support
> > > > > > > drm/msm/dp: Add DisplayPort controller for QCS8300
> > > > > > >
> > > > > > > .../bindings/display/msm/dp-controller.yaml | 22 ++
> > > > > > > .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
> > > > > > > .../bindings/display/msm/qcom,sm8650-dpu.yaml | 15 +-
> > > > > > > drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> > > > > > > drivers/gpu/drm/msm/msm_mdss.c | 1 +
> > > > > > > drivers/soc/qcom/ubwc_config.c | 1 +
> > > > > > > 6 files changed, 321 insertions(+), 5 deletions(-)
> > > > > > > ---
> > > > > > > base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
> > > > > > > change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
> > > > > > > prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
> > > > > > > prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
> > > > > > > prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
> > > > > > > prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
> > > > > > > prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
> > > > > > > prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
> > > > > > > prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
> > > > > > > prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
> > > > > > > prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
> > > > > > > prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
> > > > > > > prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
> > > > > > > prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
> > > > > > >
> > > > > > > Best regards,
> > > > > >
> > > > > > Hi, maintainers:
> > > > > > sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
> > > > >
> > > > > You can fix that manually by sending them both through
> > > > >
> > > > > b4 send -o /tmp/
> > > > > git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
> > > > > git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
> > > > >
> > > > > Konrad
> > > > Thanks for guide, when i use cmd "git send-email
> > > > --in-reply-to="20250904-qcs8300_mdss-v11-0-bc8761964d76@oss.qualcomm.com"
> > > > ~/tmpyongmou/0005-drm-msm-mdss-add-qcs8300-support.eml", seems something
> > > > wrong, error log:
> > > > mou@oss.qualcomm.com>, Dmitry Baryshkov
> > > > <dmitry.baryshkov@oss.qualcomm.com>'
> > > > (body) Adding cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> from
> > > > line 'Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
> > > > 5.1.3 The recipient address <y> is not a valid RFC 5321 address. For more
> > > > 5.1.3 information, go to
> > > > 5.1.3 https://support.google.com/a/answer/3221692 and review RFC 5321
> > > > 5.1.3 specifications. d9443c01a7336-24b1ba1718bsm64512315ad.39 - gsmtpWould
> > > > you mind sharing some suggestions for this? Thanks~~
> > >
> > > When `git send-email` asks you, just press 'Enter', no extra chars. Or
> > > it migth be easier to just `b4 send --resend`.
> > >
> > Thanks for the guidance — that was the mistake I made. It has now been sent
> > upstream. It looks like the patch wasn't archived into the V11 series. So
> > does this ok?
>
> No, I don't see them on the mailing list.
They are now, but the In-Reply-To seems to be incorrect.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-05 8:25 ` Krzysztof Kozlowski
@ 2025-09-08 9:46 ` Yongxing Mou
0 siblings, 0 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-08 9:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Dmitry Baryshkov, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
dri-devel, freedreno, devicetree, linux-kernel
On 9/5/2025 4:25 PM, Krzysztof Kozlowski wrote:
> On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
>>
>>
>> On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
>>> On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
>>>> Add compatible string for the DisplayPort controller found on the
>>>> Qualcomm QCS8300 SoC.
>>>>
>>>> The Qualcomm QCS8300 platform comes with one DisplayPort controller
>>>> that supports 4 MST streams.
>>>>
>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>> ---
>>>> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
>>>> 1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
>>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> @@ -18,6 +18,7 @@ properties:
>>>> compatible:
>>>> oneOf:
>>>> - enum:
>>>> + - qcom,qcs8300-dp
>>>
>>> Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
>>> new one?
>>>
>> I think we can not use fallback to sa8775p, since we don't have DP1
>> controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
>> really used). So in the hardware, i think it is different with SA8775P and
>> we need a new one.>> - qcom,sa8775p-dp
>
> I don't understand how this rationale explains what Dmitry asked.
>
> Why number of IP blocks (and this is DPx, right?) matter? Are you sure
> you understand what compatibility means? Please read the slides from
> OSSE25 or just read writing bindings.
>
> Best regards,
> Krzysztof
>
Sure.. I’ll discuss this further here to make sure I fully understand
these comments.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-05 13:48 ` Dmitry Baryshkov
@ 2025-09-08 9:46 ` Yongxing Mou
2025-09-08 10:04 ` Dmitry Baryshkov
0 siblings, 1 reply; 22+ messages in thread
From: Yongxing Mou @ 2025-09-08 9:46 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On 9/5/2025 9:48 PM, Dmitry Baryshkov wrote:
> On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
>>
>>
>> On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
>>> On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
>>>> Add compatible string for the DisplayPort controller found on the
>>>> Qualcomm QCS8300 SoC.
>>>>
>>>> The Qualcomm QCS8300 platform comes with one DisplayPort controller
>>>> that supports 4 MST streams.
>>>>
>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>> ---
>>>> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
>>>> 1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
>>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> @@ -18,6 +18,7 @@ properties:
>>>> compatible:
>>>> oneOf:
>>>> - enum:
>>>> + - qcom,qcs8300-dp
>>>
>>> Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
>>> new one?
>>>
>> I think we can not use fallback to sa8775p, since we don't have DP1
>> controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
>> really used). So in the hardware, i think it is different with SA8775P and
>> we need a new one.>> - qcom,sa8775p-dp
>
> The DP controller is the same as the one present on SA8775P.
>
Yes, it is same.. I just want to confirm again—even if we only need DP0
for QCS8300, we can also use sa8775p as fallback, right?
static const struct msm_dp_desc msm_dp_desc_sa8775p[] = {
{ .io_start = 0x0af54000, .id = MSM_DP_CONTROLLER_0,
.wide_bus_supported = true },
{ .io_start = 0x0af5c000, .id = MSM_DP_CONTROLLER_1,
.wide_bus_supported = true },
{ .io_start = 0x22154000, .id = MSM_DP_CONTROLLER_2,
.wide_bus_supported = true },
{ .io_start = 0x2215c000, .id = MSM_DP_CONTROLLER_3,
.wide_bus_supported = true },
{}
};
.mst_streams = 4 is suitable for both QCS8300 and SA8775P DP 0 here.
Previously, my understanding here was that we might need a new
compatible for QCS8300.
Thanks~~>>>> - qcom,sc7180-dp
>>>> - qcom,sc7280-dp
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-08 9:46 ` Yongxing Mou
@ 2025-09-08 10:04 ` Dmitry Baryshkov
2025-09-08 11:00 ` Yongxing Mou
0 siblings, 1 reply; 22+ messages in thread
From: Dmitry Baryshkov @ 2025-09-08 10:04 UTC (permalink / raw)
To: Yongxing Mou
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Mon, Sep 08, 2025 at 05:46:30PM +0800, Yongxing Mou wrote:
>
>
> On 9/5/2025 9:48 PM, Dmitry Baryshkov wrote:
> > On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
> > >
> > >
> > > On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
> > > > On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
> > > > > Add compatible string for the DisplayPort controller found on the
> > > > > Qualcomm QCS8300 SoC.
> > > > >
> > > > > The Qualcomm QCS8300 platform comes with one DisplayPort controller
> > > > > that supports 4 MST streams.
> > > > >
> > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > > > ---
> > > > > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
> > > > > 1 file changed, 22 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > > > index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
> > > > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > > > @@ -18,6 +18,7 @@ properties:
> > > > > compatible:
> > > > > oneOf:
> > > > > - enum:
> > > > > + - qcom,qcs8300-dp
> > > >
> > > > Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
> > > > new one?
> > > >
> > > I think we can not use fallback to sa8775p, since we don't have DP1
> > > controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
> > > really used). So in the hardware, i think it is different with SA8775P and
> > > we need a new one.>> - qcom,sa8775p-dp
> >
> > The DP controller is the same as the one present on SA8775P.
> >
> Yes, it is same.. I just want to confirm again—even if we only need DP0 for
> QCS8300, we can also use sa8775p as fallback, right?
What makes you think that we can't? Let me repharse the question: which
part of DP controller (single one) on QCS8300 is incompatible with the
DP controller on SA8775P?
>
> static const struct msm_dp_desc msm_dp_desc_sa8775p[] = {
> { .io_start = 0x0af54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported
> = true },
> { .io_start = 0x0af5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported
> = true },
> { .io_start = 0x22154000, .id = MSM_DP_CONTROLLER_2, .wide_bus_supported
> = true },
> { .io_start = 0x2215c000, .id = MSM_DP_CONTROLLER_3, .wide_bus_supported
> = true },
> {}
> };
> .mst_streams = 4 is suitable for both QCS8300 and SA8775P DP 0 here.
>
> Previously, my understanding here was that we might need a new compatible
> for QCS8300.
>
> Thanks~~>>>> - qcom,sc7180-dp
> > > > > - qcom,sc7280-dp
> >
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-09-08 10:04 ` Dmitry Baryshkov
@ 2025-09-08 11:00 ` Yongxing Mou
0 siblings, 0 replies; 22+ messages in thread
From: Yongxing Mou @ 2025-09-08 11:00 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On 9/8/2025 6:04 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 08, 2025 at 05:46:30PM +0800, Yongxing Mou wrote:
>>
>>
>> On 9/5/2025 9:48 PM, Dmitry Baryshkov wrote:
>>> On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
>>>>
>>>>
>>>> On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
>>>>> On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
>>>>>> Add compatible string for the DisplayPort controller found on the
>>>>>> Qualcomm QCS8300 SoC.
>>>>>>
>>>>>> The Qualcomm QCS8300 platform comes with one DisplayPort controller
>>>>>> that supports 4 MST streams.
>>>>>>
>>>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>>>> ---
>>>>>> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
>>>>>> 1 file changed, 22 insertions(+)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>>>> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
>>>>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>>>> @@ -18,6 +18,7 @@ properties:
>>>>>> compatible:
>>>>>> oneOf:
>>>>>> - enum:
>>>>>> + - qcom,qcs8300-dp
>>>>>
>>>>> Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
>>>>> new one?
>>>>>
>>>> I think we can not use fallback to sa8775p, since we don't have DP1
>>>> controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
>>>> really used). So in the hardware, i think it is different with SA8775P and
>>>> we need a new one.>> - qcom,sa8775p-dp
>>>
>>> The DP controller is the same as the one present on SA8775P.
>>>
>> Yes, it is same.. I just want to confirm again—even if we only need DP0 for
>> QCS8300, we can also use sa8775p as fallback, right?
>
> What makes you think that we can't? Let me repharse the question: which
> part of DP controller (single one) on QCS8300 is incompatible with the
> DP controller on SA8775P?
>
Sure.. got this point.. will update next version.. for the single one ,
they are same...
Thanks.>>
>> static const struct msm_dp_desc msm_dp_desc_sa8775p[] = {
>> { .io_start = 0x0af54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported
>> = true },
>> { .io_start = 0x0af5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported
>> = true },
>> { .io_start = 0x22154000, .id = MSM_DP_CONTROLLER_2, .wide_bus_supported
>> = true },
>> { .io_start = 0x2215c000, .id = MSM_DP_CONTROLLER_3, .wide_bus_supported
>> = true },
>> {}
>> };
>> .mst_streams = 4 is suitable for both QCS8300 and SA8775P DP 0 here.
>>
>> Previously, my understanding here was that we might need a new compatible
>> for QCS8300.
>>
>> Thanks~~>>>> - qcom,sc7180-dp
>>>>>> - qcom,sc7280-dp
>>>
>>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2025-09-08 11:00 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-04 7:22 [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 1/6] dt-bindings: display/msm: Document the DPU for QCS8300 Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible Yongxing Mou
2025-09-04 13:43 ` Dmitry Baryshkov
2025-09-05 2:50 ` Yongxing Mou
2025-09-05 8:25 ` Krzysztof Kozlowski
2025-09-08 9:46 ` Yongxing Mou
2025-09-05 13:48 ` Dmitry Baryshkov
2025-09-08 9:46 ` Yongxing Mou
2025-09-08 10:04 ` Dmitry Baryshkov
2025-09-08 11:00 ` Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 3/6] dt-bindings: display/msm: Document MDSS on QCS8300 Yongxing Mou
2025-09-04 7:22 ` [PATCH v11 4/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg Yongxing Mou
2025-09-04 7:55 ` [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
2025-09-04 8:21 ` Konrad Dybcio
2025-09-04 9:31 ` Yongxing Mou
2025-09-04 9:44 ` Konrad Dybcio
2025-09-05 3:48 ` Yongxing Mou
2025-09-04 13:41 ` Dmitry Baryshkov
2025-09-05 3:55 ` Yongxing Mou
2025-09-05 13:49 ` Dmitry Baryshkov
2025-09-05 14:25 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).