From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joseph Guo <qijian.guo@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Justin Jiang <justin.jiang@nxp.com>
Subject: Re: [PATCH 2/2] dt-bindings: arm: imx Add FRDM-IMX91 board
Date: Fri, 14 Nov 2025 08:04:44 +0100 [thread overview]
Message-ID: <c3137311-d85e-4eeb-9122-3072faa83feb@kernel.org> (raw)
In-Reply-To: <20251114-imx91_frdm-v1-2-e5763bdf9336@nxp.com>
On 14/11/2025 07:55, Joseph Guo wrote:
> Add the board FRDM-IMX91 in the binding document.
>
> Signed-off-by: Joseph Guo <qijian.guo@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 00cdf490b0620bf537330ee9342a197f13c8c8ab..402c735bafe97236a2f4790f914ef56a4156b0f0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1409,6 +1409,7 @@ properties:
> items:
> - enum:
> - fsl,imx91-11x11-evk # i.MX91 11x11 EVK Board
> + - fsl,frdm-imx91 # FRDM i.MX91 Development Board
You received comments already the order of board/soc is wrong, but still
push own version. No, read the feedback people gave you.
Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
> - const: fsl,imx91
>
> - description: i.MX93 based Boards
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-14 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 6:55 [PATCH 0/2] Add FRDM i.MX 91 Development board support Joseph Guo
2025-11-14 6:55 ` [PATCH 1/2] arm64: dts: freescale: Add FRDM-IMX91 basic support Joseph Guo
2025-11-14 7:09 ` Krzysztof Kozlowski
2025-11-14 12:58 ` Francesco Valla
2025-11-17 3:30 ` Joseph Guo
2025-11-14 6:55 ` [PATCH 2/2] dt-bindings: arm: imx Add FRDM-IMX91 board Joseph Guo
2025-11-14 7:04 ` Krzysztof Kozlowski [this message]
2025-11-14 7:10 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3137311-d85e-4eeb-9122-3072faa83feb@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=justin.jiang@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qijian.guo@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).