From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD3DC38142 for ; Mon, 23 Jan 2023 08:13:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231650AbjAWINs (ORCPT ); Mon, 23 Jan 2023 03:13:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbjAWINr (ORCPT ); Mon, 23 Jan 2023 03:13:47 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C00441A94B for ; Mon, 23 Jan 2023 00:13:44 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id e3so9941727wru.13 for ; Mon, 23 Jan 2023 00:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SBM3bwQWzykO2B1JQ+ipvskwHKEQ4WdxVib/Qyi51ug=; b=AT9Iq0xSCEqZpmKDW/Ox7GmeyX5AuNSRJunHvXTae3PtaTzXAaVeLJiUNCqlOyzZPw 33iOZHMkSml012eGVJ/IICOryeb3/C3pOsn3g1PIhUPamMcb4uBeWg9efJVUXjxl+bFp 0zW+bAj0q6l1Gj2h+11m2yuUu0cuj22N/4GRjtmdTOPLeMUNixJ7BsuSeM7+xQ1PijzC GLqz/JxaSPW1s+RVlRp0DnWuxcQ3xeON8gI1oYo374UIcxoaNTFJ1q2hEzgNcEZzaFEi 564qfpA2fPIkm25jO5xQ6Obq7Kvks5lEJy0N0yf7xANOgqqn2qRJM07bm+JBKp265V+M HqTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SBM3bwQWzykO2B1JQ+ipvskwHKEQ4WdxVib/Qyi51ug=; b=AjOEQophlluGxQV9OgDdGELiiYydRlHLt83HzERmDwocLis5FRMUJhOZeK2IihTZYv f1xKEs+PpH03vnR9m6txnbvlwYCS3IxU1ebELGbbwpQ8iAFuvPZ9W85WhDs+O4OmiOh/ Y/LbS9LdeFNW6H2opE7lpgA4slWlnRLeD6yQPgBUOVY0cT0skYeFR0ZzgFqd4AdursS5 nVCp7FVydCxq0Ld0cZx/u9Au6Ka1lPJ60w5XQwUgbJcL3b8vqnz6Iil4eKHtZf+HEk9m xCAjLXBXRszUfJrDtNk2ES33fBz/hw+4WX1/FZWXKUw/tPd4Ml/k2OS2Uuyy6M3PeLGd SC3Q== X-Gm-Message-State: AFqh2kpM2EfKbZv2VxCRtJpIcLAnUHH3CrH0q8xbe/dYV9VktB/Et5IK ggCNIBuvrvq0U1J6sXmM3eVfqg== X-Google-Smtp-Source: AMrXdXvEE2+iNOHYDBXMmjnnlnEeh6QweQ/hJDMmk245CtGSpc/zmfvz+73u+L3+2RYwpIRt3IDSbQ== X-Received: by 2002:adf:fa08:0:b0:2bc:aa57:7f35 with SMTP id m8-20020adffa08000000b002bcaa577f35mr20792170wrr.52.1674461623286; Mon, 23 Jan 2023 00:13:43 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id b9-20020adff909000000b002be5401ef5fsm7588216wrr.39.2023.01.23.00.13.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 00:13:42 -0800 (PST) Message-ID: Date: Mon, 23 Jan 2023 09:13:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 13/15] dt-bindings: pinctrl: add support for Ambarella Content-Language: en-US To: Li Chen , Li Chen , Linus Walleij , Rob Herring , Krzysztof Kozlowski Cc: "moderated list:ARM/Ambarella SoC support" , "open list:PIN CONTROL SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-14-lchen@ambarella.com> From: Krzysztof Kozlowski In-Reply-To: <20230123073305.149940-14-lchen@ambarella.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/01/2023 08:32, Li Chen wrote: > Add a Ambarella compatible. > > Signed-off-by: Li Chen > Change-Id: I8bcab3b763bdc7e400a04cc46589f0f694028a66 > --- > .../bindings/pinctrl/ambarella,pinctrl.yaml | 160 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 161 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/ambarella,pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/ambarella,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ambarella,pinctrl.yaml > new file mode 100644 > index 000000000000..51f5a9cc4714 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/ambarella,pinctrl.yaml > @@ -0,0 +1,160 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/ambarella,pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ambarella PIN controller > + > +maintainers: > + - Li Chen > + > +description: | > + The pins controlled by Ambarella SoC chip are organized in banks, each bank > + has 32 pins. Each pin has at least 2 multiplexing functions, and generally, > + the first function is GPIO. > + > + The PINCTRL node acts as a container for an arbitrary number of subnodes. And > + these subnodes will fall into two categories. > + > + One is for GPIO, please see the "GPIO node" section for detail, and another one > + is to set up a group of pins for a function, both pin configurations and mux > + selection, and it's called group node in the binding document. > + > +properties: > + compatible: > + items: > + - const: ambarella,pinctrl > + > + reg: > + minItems: 4 > + maxItems: 4 > + Same problems as with other patches. You need to fix all of my previous comments. Best regards, Krzysztof