From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F029C83F01 for ; Sun, 27 Aug 2023 07:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230149AbjH0H4p (ORCPT ); Sun, 27 Aug 2023 03:56:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbjH0H4N (ORCPT ); Sun, 27 Aug 2023 03:56:13 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E1CA109 for ; Sun, 27 Aug 2023 00:56:10 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4ff8cf11b90so3517839e87.1 for ; Sun, 27 Aug 2023 00:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693122969; x=1693727769; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WtCfEv+4MKM7AB9nOhBJNz/fOo34fqcluKuKRBYbD48=; b=qD7V+/1eeqflk5HBX6g3KX3146dEBk/Xkv8nuSU+gc3hnO6r9ofzuLGMPcc8Dn7C2e GKlBdiZ2qE5uIrVHiTtm9JGCOOrTPB6mU9ujnBbMsXK1WVwupwtgLBNFxtBZiqvjaQyD PdZrJzydTmbJlB+zh+djrY96msG3m1kA998NMjMmH+ugM569oMQCwSK03EFEx49Lhxtd lVEVI6GG1tCWtccwwbwmN0/6vKwbixgoMys0rMT+EZp16KSvz5VxiTH1rr+FZDIDcOzR PyyjxQ6Hp4+5N7egiFOWCMcHc9jbnIlMDtyzPyssB7v6CNdwRVdT6/nTEbCEDyAb5Dy7 +rCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693122969; x=1693727769; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WtCfEv+4MKM7AB9nOhBJNz/fOo34fqcluKuKRBYbD48=; b=jbFkgbA8pdO4mN/97Ce1dvJF+tNbHHJ/u8MvGnNOr19/iHpy4fKVPbWe4qhIbWlr7N CPA4/RLwsx8aWKoUKeuRkIlqZRkFuAZCzZ7u3r9pOyHwW9h1Ru8qHI+KZWIS8VWygQh0 rk0nAeVVSWsOdPieb0SyYMna1og1WjLJ5Z2ozgC75qj9MwelBr8fpkUkXWfh3OLph3RK Mc6RnSJUI7kFxWyKjOulFwzLF8/Kcv42NQ2EwTzInw2vpgtOcc2cn3YSs0ApT7hHxXnP WJfwVm+lWzUZCH0rY+0ju6mmf1j6BnabDzUAtDMOPlNrb1B9SoYG4CnFClTmPlU0Up4+ RZtA== X-Gm-Message-State: AOJu0YxDHnA2pRpTvtQxy5jTL5jWmqSePFBo7enOMB5uuj1E0SkNbvMD +xYZ4XTiWGqdU6AY657brSSglw== X-Google-Smtp-Source: AGHT+IH+qv/LoraiYPu/y8KAOtXrIZc0aV8VyRf3SodaZ97qiCkEX4ZtlRNINc81TgAvCPpw8+aRAw== X-Received: by 2002:a05:6512:3e08:b0:500:b872:7899 with SMTP id i8-20020a0565123e0800b00500b8727899mr351076lfv.62.1693122968433; Sun, 27 Aug 2023 00:56:08 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id rn14-20020a170906d92e00b00992afee724bsm3136783ejb.76.2023.08.27.00.56.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Aug 2023 00:56:07 -0700 (PDT) Message-ID: Date: Sun, 27 Aug 2023 09:56:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller Content-Language: en-US To: Serge Semin , Keguang Zhang Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Bogendoerfer , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Serge Semin References: <20230824125012.1040288-1-keguang.zhang@gmail.com> <20230824125012.1040288-3-keguang.zhang@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/08/2023 23:04, Serge Semin wrote: >> + clock-names: >> + items: >> + - const: stmmaceth > > clock-names: > const: stmmaceth > ? The existing syntax is correct. This is a string array. > >> + >> + interrupts: >> + maxItems: 1 >> + > >> + interrupt-names: >> + items: >> + - const: macirq > > interrupt-names: > const: macirq > ? As well. > >> + >> + loongson,ls1-syscon: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to the syscon containing some extra configurations >> + including PHY interface mode. >> + > >> + phy-mode: >> + items: >> + - enum: >> + - mii >> + - rmii > > phy-mode: > enum: ... > ? Here indeed, this is a string, not a list, so items are wrong. Best regards, Krzysztof