From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Subject: Re: [PATCH 2/5] arm64: dts: qcom: qrb2210-rb1: Fix regulators
Date: Wed, 6 Sep 2023 11:38:41 +0200 [thread overview]
Message-ID: <c32d93c1-a7f5-6e8b-cd43-96479c17899a@linaro.org> (raw)
In-Reply-To: <20230906-topic-rb1_features_sans_icc-v1-2-e92ce6fbde16@linaro.org>
On 06/09/2023 11:24, Konrad Dybcio wrote:
> Commit b4fe47d12f1f ("arm64: dts: qcom: qrb2210-rb1: Add regulators")
> introduced regulator settings that were never put in place, as all of the
> properties ended 'microvolts' instead of 'microvolt' (which dt schema did
> not check for back then).
>
> Fix the microvolts-microvolt typo and adjust voltage ranges where it's
> necessary to fit within the volt = base + n*step formula.
>
> Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: b4fe47d12f1f ("arm64: dts: qcom: qrb2210-rb1: Add regulators")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Dmitry fixed it already... but apparently never sent it upstream, so his
loss.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-06 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 9:24 [PATCH 0/5] RB1 features Konrad Dybcio
2023-09-06 9:24 ` [PATCH 1/5] arm64: dts: qcom: qrb2210-rb1: Swap UART index Konrad Dybcio
2023-09-06 11:05 ` Dmitry Baryshkov
2023-09-06 11:07 ` Dmitry Baryshkov
2023-09-06 9:24 ` [PATCH 2/5] arm64: dts: qcom: qrb2210-rb1: Fix regulators Konrad Dybcio
2023-09-06 9:38 ` Krzysztof Kozlowski [this message]
2023-09-06 11:05 ` Dmitry Baryshkov
2023-09-06 9:24 ` [PATCH 3/5] arm64: dts: qcom: qrb2210-rb1: Enable remote processors Konrad Dybcio
2023-09-06 11:07 ` Dmitry Baryshkov
2023-09-06 9:24 ` [PATCH 4/5] arm64: dts: qcom: qrb2210-rb1: Add GPIO LEDs Konrad Dybcio
2023-09-06 9:24 ` [PATCH 5/5] arm64: dts: qcom: qrb2210-rb1: Hook up USB3 Konrad Dybcio
2023-09-06 11:07 ` Dmitry Baryshkov
2023-09-20 2:14 ` [PATCH 0/5] RB1 features Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c32d93c1-a7f5-6e8b-cd43-96479c17899a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).