Re: [PATCH v3 1/8] dt-bindings: remoteproc: qcom,pas: add thermal mitigation properties

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/06/2026 14:30, Daniel Lezcano wrote:
> Hi Gaurav,
>>>> thanks for review, shall i use driver data, which is basically pas 
>>>> data structure like below:
>>>>
>>>> static const struct qcom_pas_data {
>>>>      .crash_reason_smem = 601,
>>>>      .firmware_name = "cdsp.mdt",
>>>>      .tmd_names = (const char *[]){"xyz", NULL},
>>>>      .num_tmds = 1,
>>>>
>>>> Is something like above acceptable? and this will also help to filter 
>>>> tmd names as well?
>>>
>>>
>>> How the thermal framework will bind the thermal zone with the TMD ? 
>>> (node pointer, id) ?
>>>
>>
>> Hi Daniel,
>>
>> thanks for review.
>>
>> With id only, in this case instead of taking tmd names from device tree, 
>> qmi_tmd will take tmd name from pas_data(driver) and register with the 
>> cooling framework with id only. Please let us know if this looks fine.
> May be I'm missing something but:
> 
>   - The QMI TMD returns a list of names, not ids
>   - The QMI TMD may return the list in different order than assumed
>   - The cooling map index points to the name of the TMD in the DT
>   - This name is used to match the name in the aformentionned list
>   - The index in the list and the id in the DT can differ
> 
> Krzysztof , I don't get why having the TMD names as properties is wrong, 
> they describes the existing TMDs on the system and the cooling maps 
> index points to the one to be connected with thermal zone.


'xxx-names' have a fixed meaning in DT by convention - assign
identifiable strings to the 'xxx'. I miss the property 'tmd' in such
case - its definition and meaning. Where is it?

But maybe you just want list of strings, so I am open to discuss it - I
don't understand the need for this property and commit and property
description tell me nothing.

Really, this commit message is basically non-existing. It explains what
it did and provides that much explanation WHY:

"- tmd-names (thermal mitigation device names)"

Really? This is the explanation why this change is being made, why this
property is needed?

So sure, describe the problem being solved and WHY this problem is being
solved that way. Maybe it will fit DT.


Best regards,
Krzysztof