From: Matthias Brugger <matthias.bgg@gmail.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>, CK HU <ck.hu@mediatek.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
Sascha Hauer <kernel@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Nicolas Boichat <drinkcat@chromium.org>,
YT Shen <yt.shen@mediatek.com>,
Daoyuan Huang <daoyuan.huang@mediatek.com>,
Jiaguang Zhang <jiaguang.zhang@mediatek.com>,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
Houlong Wei <houlong.wei@mediatek.com>,
ginny.chen@mediatek.com
Subject: Re: [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct
Date: Tue, 27 Aug 2019 12:04:03 +0200 [thread overview]
Message-ID: <c33f6829-b1f4-376f-5e12-38c811c370dd@gmail.com> (raw)
In-Reply-To: <1566879121.29523.8.camel@mtksdaap41>
On 27/08/2019 06:12, Bibby Hsieh wrote:
>>>
>>> int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event)
>>> {
>>> - u32 arg_b;
>>> + struct cmdq_instruction *inst;
>>>
>>> if (event >= CMDQ_MAX_EVENT)
>>> return -EINVAL;
>>>
>>> - /*
>>> - * WFE arg_b
>>> - * bit 0-11: wait value
>>> - * bit 15: 1 - wait, 0 - no wait
>>> - * bit 16-27: update value
>>> - * bit 31: 1 - update, 0 - no update
>>> - */
>>
>> I have no strong opinion of CMDQ_WFE_OPTION but if you want to introduce it,
>> then please copy the comment over to include/linux/mailbox/mtk-cmdq-mailbox.h
>
> Ok. let's move the descriptions to header.
>>
>> Just one question, why did you call it _OPTION? It's not really expressive for me.
>
> Actually, _OPTION is come from our hardware design name...
>
Ok, then I'll stop bike-shedding. I leave it up to you to rename it or not.
Regards,
Matthias
next prev parent reply other threads:[~2019-08-27 10:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 8:49 [RESEND, PATCH v13 00/12] support gce on mt8183 platform Bibby Hsieh
[not found] ` <20190820084932.22282-1-bibby.hsieh-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-08-20 8:49 ` [RESEND, PATCH v13 01/12] dt-binding: gce: remove thread-num property Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 02/12] dt-binding: gce: add gce header file for mt8183 Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 03/12] dt-binding: gce: add binding for gce client reg property Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 04/12] mailbox: mediatek: cmdq: move the CMDQ_IRQ_MASK into cmdq driver data Bibby Hsieh
2019-08-23 11:32 ` Matthias Brugger
2019-08-20 8:49 ` [RESEND, PATCH v13 05/12] mailbox: mediatek: cmdq: support mt8183 gce function Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 06/12] soc: mediatek: cmdq: clear the event in cmdq initial flow Bibby Hsieh
2019-08-23 11:36 ` Matthias Brugger
2019-08-23 11:43 ` Matthias Brugger
2019-08-20 8:49 ` [RESEND, PATCH v13 07/12] soc: mediatek: cmdq: reorder the parameter Bibby Hsieh
2019-08-23 12:05 ` Matthias Brugger
2019-08-20 8:49 ` [RESEND, PATCH v13 08/12] soc: mediatek: cmdq: change the type of input parameter Bibby Hsieh
2019-08-23 12:09 ` Matthias Brugger
2019-08-20 8:49 ` [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct Bibby Hsieh
2019-08-20 9:39 ` houlong wei
2019-08-23 13:50 ` Matthias Brugger
2019-08-27 4:12 ` Bibby Hsieh
2019-08-27 10:04 ` Matthias Brugger [this message]
2019-08-20 8:49 ` [RESEND, PATCH v13 10/12] soc: mediatek: cmdq: add polling function Bibby Hsieh
2019-08-20 9:50 ` houlong wei
2019-08-23 14:05 ` Matthias Brugger
2019-08-27 4:07 ` Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function Bibby Hsieh
2019-08-20 9:40 ` houlong wei
2019-08-20 9:47 ` houlong wei
2019-08-23 14:21 ` Matthias Brugger
2019-08-27 3:59 ` Bibby Hsieh
2019-08-27 10:13 ` Matthias Brugger
2019-08-28 8:32 ` Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 12/12] arm64: dts: add gce node for mt8183 Bibby Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c33f6829-b1f4-376f-5e12-38c811c370dd@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=bibby.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=daoyuan.huang@mediatek.com \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=drinkcat@chromium.org \
--cc=ginny.chen@mediatek.com \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=jiaguang.zhang@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).