From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1790EB64DC for ; Fri, 21 Jul 2023 13:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230005AbjGUN1N (ORCPT ); Fri, 21 Jul 2023 09:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230518AbjGUN1L (ORCPT ); Fri, 21 Jul 2023 09:27:11 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B64526A3; Fri, 21 Jul 2023 06:26:45 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 36LDQEhQ068767; Fri, 21 Jul 2023 08:26:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1689945974; bh=CE0bOLWvWbP95V4YC8ATu1t6fLv4W1N/pWcklQAfuJs=; h=Date:Subject:From:To:CC:References:In-Reply-To; b=HzkQr74PDLcu1lZVn0WmvFnAJB7LKz7gD94Bgc+OKekfVtnM0/cyEEUnX92V6xBTq sDbTjD5fADgmMNy8Rwaiu/9gSmuFxjrKlsDtrBqqB/XFIC3rpuX+Jttruj02JYyLnb AjTI8nH+OLuNZ0o1PjGw5+ngQTj6vewC1a45zpno= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 36LDQE4X035390 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Jul 2023 08:26:14 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 21 Jul 2023 08:26:14 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 21 Jul 2023 08:26:14 -0500 Received: from [172.24.227.112] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 36LDQB7w111784; Fri, 21 Jul 2023 08:26:11 -0500 Message-ID: Date: Fri, 21 Jul 2023 18:56:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 3/5] arm64: dts: ti: k3-j784s4: Add WIZ and SERDES PHY nodes From: Jayesh Choudhary To: Nishanth Menon , Andrew Davis CC: , , , , , , , References: <20230710101705.154119-1-j-choudhary@ti.com> <20230710101705.154119-4-j-choudhary@ti.com> <20230712141828.lnpo4mhd5dv34rlz@census> <18310450-05f3-172c-e4bc-fda114f333a4@ti.com> <20230713182107.ashuygyg4x4j77s5@backboard> <20230713185835.ek5jskqyengvba56@ascertain> <9f5d52fc-f9da-1429-1f97-bdec16d80a43@ti.com> Content-Language: en-US In-Reply-To: <9f5d52fc-f9da-1429-1f97-bdec16d80a43@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/07/23 15:06, Jayesh Choudhary wrote: > > > On 14/07/23 00:28, Nishanth Menon wrote: >> On 13:31-20230713, Andrew Davis wrote: >>> On 7/13/23 1:21 PM, Nishanth Menon wrote: >>>> On 21:01-20230713, Jayesh Choudhary wrote: >>>>> >>>>> >>>>> On 12/07/23 19:48, Nishanth Menon wrote: >>>>>> On 15:47-20230710, Jayesh Choudhary wrote: >>>>>>> From: Siddharth Vadapalli >>>>>>> >>>>>>> J784S4 SoC has 4 Serdes instances along with their respective WIZ >>>>>>> instances. Add device-tree nodes for them and disable them by >>>>>>> default. >>>>>>> >>>>>>> Signed-off-by: Siddharth Vadapalli >>>>>>> [j-choudhary@ti.com: fix serdes_wiz clock order] >>>>>>> Signed-off-by: Jayesh Choudhary >>>>>>> --- >>>>>> NAK. This patch introduces the following dtbs_check warning. >>>>>> arch/arm64/boot/dts/ti/k3-am69-sk.dtb: serdes-refclk: >>>>>> 'clock-frequency' is a required property >>>>>> >>>>> >>>>> Sorry for this. This property was added in the final board file. >>>>> I will fix it in the next revision. >>>>> I will add '0' as clock-property in the main file similar to j721e[1] >>>>> which will be overridden in the board file with required value to get >>>>> rid of this warning. >>>> >>>> That would follow what renesas (r8a774a1.dtsi) and imx >>>> (imx8dxl-ss-conn.dtsi) seem to be doing as well. Just make sure to add >>>> documentation to the property to indicate expectation. Unless someone >>>> has objections to this approach. >>>> >>> >>> Would it work better to disable these nodes, only enabling them in the >>> board files when a real clock-frequency can be provided? >>> >>> My initial reaction would be to move the whole external reference clock >>> node to the board file since that is where it is provided, but seems >>> that would cause more churn in serdes_wiz* nodes than we would want.. >> >> I would prefer that as well, but I have'nt gone around looking for >> similar examples on other SoCs (Jayesh, can you check?). One other >> approach (alipine and few other places) has been for the bootloader to >> update the property set in dtb as 0, which is not needed in this case >> to the best of what I see.. just hoping we use a technique that most >> board folks are familiar with across SoCs. >> > > > I can see the clock nodes in board files for some vendors. But like > Andrew said, that would cause issues with serdes_wiz node in the > main.dtsi. > > So I think it would be better to keep the external clock node in main > dtsi itself. I will add comments to the property to indicate that this > value will be over-written in board dts. > Posting v6 to address these comments and others on the series. > FYI.. I posted v6: https://lore.kernel.org/all/20230721132029.123881-1-j-choudhary@ti.com/ And I am using status property instead to address the dtbs_warning here. Warm Regards, Jayesh