Re: [PATCH v4 5/5] spi: cadence: Add MRVL overlay xfer operation support

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 09/05/2024 03:05, Witold Sadowski wrote:
> MRVL Xfer overlay extend xSPI capabilities, to support non-memory SPI
> operations. Marvell overlay combined with generic command allows to
> create full-duplex SPI transactions. It also allows to create
> transaction with undetermined transaction length - with cs_hold
> parameter, and ability to extend CS signal assertion, even if xSPI block
> requests CS signal de-assertion.
> 


> +
>  static int cdns_xspi_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> @@ -905,6 +1140,16 @@ static int cdns_xspi_probe(struct platform_device *pdev)
>  		return PTR_ERR(cdns_xspi->auxbase);
>  	}
>  
> +	if (cdns_xspi->mrvl_hw_overlay) {
> +		res = platform_get_resource(pdev, IORESOURCE_MEM, 3);
> +		cdns_xspi->xferbase = devm_ioremap_resource(dev, res);

Use proper wrapper/helper for these two. This looks like you are working
on old, downstream kernel.

Best regards,
Krzysztof