From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD79E1B7F1 for ; Fri, 26 Jan 2024 13:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706275272; cv=none; b=hSoZM3qYgNwOWfDpvNubP95Z4JSoV15WA3qlXoU/AwzcKEb1hTl60Vj2gh9JVd3sG95GfGsc1KwZYcmIFy78oHmk41esE/EWgFESZO8yIAEZxbTvZIPLFPOoO+iAFU8xfbTyCbQ4Ajl48zgR0AZGe6plZg+w2vFjU5f4w4J0uf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706275272; c=relaxed/simple; bh=k/hmjmzlrned/165p3axqjqzNbe0FFV/hch3IZTVydA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=puIloaGcrszKogJpWhi3wYqn0TzGby4Om1Jq7WGhZ7SBF6tGFTPVSqSmn7m17JFp3NsXMNkHrRbi5hSedzMubF92hlKh7HpsNs5zqhv8qfctZzq4o/kgSyiTGugdsHqr/r3b6nUv0IUGzjZNnEa9w+txgYYdO3l7gf9+UV3aWs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dQKS+cYs; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dQKS+cYs" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2cc9fa5e8e1so3414601fa.3 for ; Fri, 26 Jan 2024 05:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706275269; x=1706880069; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KVmQv9Y5onGlqwoMtR9By+Wn80G7PjkoIVuCrBbQ7so=; b=dQKS+cYs2kCmKxk3jJFQZYmgxotaFPf/5LCau2W+ykg9iRTqzIViRUEhxKx6AUbyyN 4CCGochLkA0TgZJVy/K/n4Z5ADlwAYejNJjjPtlYbw4I7H/WFVL99N8g3geB60kpCsiH FL+I/dwImos0CBbOso4ZoL/3DdMJECW61oog5cIBkXh3MmI4m3aEMWCnWl061sfZcc6c uJXLx3nKGV2mXZbP11e5Gfu04/btHD119JQIneId5Y4nRgGEgVJnARMr60O3w6dQF1bt YMfgpushziRqiYmANpYFqJnA8TmoTqUExZp1ul7wO3mt48dVyRGi9Mz4xJqSqxhSDpwM NS6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706275269; x=1706880069; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KVmQv9Y5onGlqwoMtR9By+Wn80G7PjkoIVuCrBbQ7so=; b=jWYGM4rvwFmVKvl9J1WXoc3x/XZk16lumEYhUiMzyalSewm1e0NVV+AllJgT/SQ8xN 9ObdVsJyr6/yVVDfQq0+vxyx2ZvjE/7hyxKY8I4ucCOQrj4zb/gq8AGGjE3BoWclZKSd hN8jZWVdQaB4aiuTXVwlZwrcKmQDVUSYZd7Xj5bLOzHaSz4miulW16Wwo0KAuMZC/DpO +gddNom8wDG6EUX9jM50Kl0/GnruHiXxgeSW5YCgjUU4B63AC24RpLBX8spwvyyNRTLd osbT/S56vi6Bu8NbAfeC2xYeO5K6tCJQ0ab3YFdDZjxQfZ2ykd47mUIFvsCARgIFPZwW lK+w== X-Gm-Message-State: AOJu0Yx5ceM+W+BNMLYOtkwUG3H84ItWgc/KdlCvPNbskLyj03w+Trex 5Kjm4Mic1PN1geBeiDbD2ThVH8Kp50XJx0iLcAbvbjMzh6nrXTT55KlwcmX/eXM= X-Google-Smtp-Source: AGHT+IG/KfVN0OJU93FXTI8VXeIHenvI+pKcY89vxS9fG6+aXB5dFbBe9TpNB2afyZz5WxtcwU9U+Q== X-Received: by 2002:a2e:bb95:0:b0:2cf:2309:ca28 with SMTP id y21-20020a2ebb95000000b002cf2309ca28mr662733lje.58.1706275268838; Fri, 26 Jan 2024 05:21:08 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id l30-20020a50d6de000000b0055c875c2095sm612168edj.96.2024.01.26.05.21.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 05:21:08 -0800 (PST) Message-ID: Date: Fri, 26 Jan 2024 13:21:07 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-x13s: correct analogue microphone route Content-Language: en-US To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240125154531.417098-1-krzysztof.kozlowski@linaro.org> From: Srinivas Kandagatla In-Reply-To: <20240125154531.417098-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks Krzystof, On 25/01/2024 15:45, Krzysztof Kozlowski wrote: > Starting with Qualcomm SM8350 SoC, so Low Power Audio SubSystem (LPASS) > block version v9.2, the register responsible for TX SMIC MUXn muxes is > different. The LPASS TX macro codec driver is being fixed to handle > that difference, so the DTS must be updated as well for new widget name. > > Signed-off-by: Krzysztof Kozlowski > > --- > Unfortunately this is breaking mic on X13s. --srini > This unfortunately depends on: > https://lore.kernel.org/alsa-devel/20240125153110.410295-1-krzysztof.kozlowski@linaro.org/T/#m62da29e6b80fa419e6339d3c27439894cb04cecb > > and my tries to make it backwards compatible failed. > --- > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index def3976bd5bb..0165492e4e11 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -986,7 +986,7 @@ &sound { > "VA DMIC0", "VA MIC BIAS1", > "VA DMIC1", "VA MIC BIAS1", > "VA DMIC2", "VA MIC BIAS3", > - "TX SWR_ADC1", "ADC2_OUTPUT"; > + "TX SWR_INPUT1", "ADC2_OUTPUT"; > > wcd-playback-dai-link { > link-name = "WCD Playback";