From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naresh Solanki <naresh.solanki@9elements.com>,
devicetree@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Patrick Rudolph <patrick.rudolph@9elements.com>
Subject: Re: [PATCH v7 1/4] dt-bindings: hwmon: fan: Add fan binding to schema
Date: Tue, 29 Nov 2022 09:12:08 +0100 [thread overview]
Message-ID: <c35917d1-dfbd-f7d9-5c94-a9f0ee3b7ed8@linaro.org> (raw)
In-Reply-To: <20221121122932.2493174-2-Naresh.Solanki@9elements.com>
On 21/11/2022 13:29, Naresh Solanki wrote:
> + pulses-per-revolution:
> + description:
> + The number of pulse from fan sensor per revolution.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + target-rpm:
> + description:
> + Target RPM the fan should be configured during driver probe.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pwms:
> + description:
> + PWM provider.
Ah, so it is not a PWM provider by this FAN controller? A bit confusing
description. Instead maybe:
PWM signal for the fan
and do you expect more than one PWM for one fan?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-29 8:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 12:29 [PATCH v7 0/4] Add devicetree support for max6639 Naresh Solanki
2022-11-21 12:29 ` [PATCH v7 1/4] dt-bindings: hwmon: fan: Add fan binding to schema Naresh Solanki
2022-11-22 19:25 ` Guenter Roeck
2022-11-29 8:09 ` Krzysztof Kozlowski
2022-11-29 8:12 ` Krzysztof Kozlowski [this message]
2022-11-29 15:46 ` Naresh Solanki
2022-11-29 15:57 ` Krzysztof Kozlowski
2022-11-29 16:03 ` Naresh Solanki
2022-11-21 12:29 ` [PATCH v7 2/4] dt-bindings: hwmon: Add binding for max6639 Naresh Solanki
2022-11-29 8:14 ` Krzysztof Kozlowski
2022-11-29 15:52 ` Naresh Solanki
2022-11-21 12:29 ` [PATCH v7 3/4] hwmon: (max6639) Change from pdata to dt configuration Naresh Solanki
2022-11-25 16:18 ` Guenter Roeck
2022-11-29 16:11 ` Naresh Solanki
2022-11-21 12:29 ` [PATCH v7 4/4] hwmon: (max6639) Add pwm support Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c35917d1-dfbd-f7d9-5c94-a9f0ee3b7ed8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).