Re: [PATCH v1 4/4] drm: panel: Add support for Renesas R69328 based MIPI DSI panel

[ALOK TIWARI <alok.a.tiwari@oracle.com>]

On 13-04-2025 22:20, ALOK TIWARI wrote:
>> +    mipi_dsi_set_drvdata(dsi, priv);
>> +
>> +    dsi->lanes = 4;
>> +    dsi->format = MIPI_DSI_FMT_RGB888;
>> +    dsi->mode_flags = MIPI_DSI_MODE_VIDEO | 
>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>> +              MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM;
>> +
>> +    drm_panel_init(&priv->panel, dev, &renesas_r69328_panel_funcs,
>> +               DRM_MODE_CONNECTOR_DSI);
>> +
>> +    ret = drm_panel_of_backlight(&priv->panel);
>> +    if (ret)
>> +        return dev_err_probe(dev, ret, "Failed to get backlight\n");
> 
> 
> drm_panel_of_backlight, 0 on success, or a negative error code on 
> failure so
>      if( ret > 0)
ie if( ret < 0)

> 
>> +
>> +    drm_panel_add(&priv->panel);
>> +
>> +    ret = mipi_dsi_attach(dsi);
> 
> if ( ret > 0) it return negative error code
ie if( ret < 0)

> 
>> +    if (ret) {
>> +        dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
>> +        drm_panel_remove(&priv->panel);
>> +        return ret;
> 
> use return dev_err_probe
> 
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +static void renesas_r69328_remove(struct mipi_dsi_device *dsi)
>> +{
>> +    struct renesas_r69328 *priv = mipi_dsi_get_drvdata(dsi);
>> +    int ret;
>> +
>> +    ret = mipi_dsi_detach(dsi);
> 
> if ( ret > 0) it return negative error code
ie if( ret < 0)

> 
>> +    if (ret)
>> +        dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
>> + 


Thanks,
Alok