From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Douglas Anderson <dianders@chromium.org>,
Henry Sun <henrysun@google.com>,
Bob Moragues <moragues@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360
Date: Tue, 30 Aug 2022 09:05:31 +0300 [thread overview]
Message-ID: <c36a4b78-241e-8c0d-f2b7-3844fa709be1@linaro.org> (raw)
In-Reply-To: <20220830025438.v2.1.Ic4d4e0777115011544dbc2ab07ed4d7b408c003a@changeid>
On 30/08/2022 05:55, Yunlong Jia wrote:
> pazquel360 is an extension project based on pazquel.
> We create 3 sku on pazquel360:
> sku 20 for LTE with physical SIM _and_ eSIM and WiFi
> sku 21 for WiFi only
> sku 22 for LTE with only a physical SIM
> Both sku20 and sku22 are LTE SKUs.
> One has the eSIM stuffed and one doesn't.
> There is a single shared device tree for the two.
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
>
No need for such blank lines. Do you see them in the code?
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-30 6:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 2:55 [PATCH v2 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia
2022-08-30 2:55 ` [PATCH v2 2/2] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia
2022-08-30 6:07 ` Krzysztof Kozlowski
2022-08-30 6:05 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-31 10:43 [PATCH v2 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia
2022-08-31 12:46 ` Krzysztof Kozlowski
2022-08-30 11:21 Yunlong Jia
2022-08-30 11:29 ` Krzysztof Kozlowski
[not found] ` <CAFvdKjsEwFcs7HuhOrx4RBqmAP3DrA5bm6f2Y7MYGZ4gr5=Ehg@mail.gmail.com>
2022-08-30 12:23 ` Krzysztof Kozlowski
2022-08-30 8:42 Yunlong Jia
2022-08-29 3:09 Yunlong Jia
2022-08-29 14:17 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36a4b78-241e-8c0d-f2b7-3844fa709be1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=henrysun@google.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@chromium.org \
--cc=robh+dt@kernel.org \
--cc=yunlong.jia@ecs.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).