From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4007C32771 for ; Wed, 28 Sep 2022 07:35:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233658AbiI1HfE (ORCPT ); Wed, 28 Sep 2022 03:35:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233672AbiI1Hey (ORCPT ); Wed, 28 Sep 2022 03:34:54 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B2BFEE16 for ; Wed, 28 Sep 2022 00:34:34 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id t16so9380131ljh.3 for ; Wed, 28 Sep 2022 00:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=T+twYSzMPRleSE9OznXaEMFrJJUZFkK7lBSk4Vw77aA=; b=D1432DOl/gFwxeJt0n2GOHt0Rhdmv87VJv4a7RA4E8I2u4j//Big6m/qFkNf6lTBpm W0ksnSWkRf8ETFnZqBTyFmTQqHTLcP25jTVvmyiqLiEUcnOk1v6+pfRYrVIaVj35bdq0 2jIlq8lnnOtEFlfxYAOyUlLsQvHkCrDnlsv7lXjf7W1xwdN+Rbm/cBsIMogB9442XXxF N3hLfFm8EtXWV+O3wC31QeV1XeN7X+oXgIzoxdirW8+WdNWVHIXhUyAuPbaAZyam9mMB APAQjRpEsRTkDGMRDOjGcZF6yOmSwbUI4syZsk7yb9slQNY9s/oHiv8YYy746pT98mxP NbWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=T+twYSzMPRleSE9OznXaEMFrJJUZFkK7lBSk4Vw77aA=; b=TMqNCG+W2efkAob2dm2bayjg3LSGIQAnOvtkMFDbXdMvHrPOoV+pyI8Gtp4Q8Qkwvi Ne/mh2Jxs2obcpoLaUHX/xArEuEJyiOu+sjDqU4Q32LbGv9BLa8TxKZ0DqS8SheLWfmi 0NC917m/p7AiTKN+/IgdoqrrYSZJbqkVz7Ie5RoLahhOUc4E+o3HzsSEm6MNZeJpN1YK KS7ytZSheKDG8dnb2cAqqonp+eX31iaHjUOrxbE5tXbQyqjZ4LjM7sNCYrrXrCXjRSbF RYwYhFEWAaeCtD7a0Q0AJsM+d/ht9XSRZ3nYMAkfMz1c8+WL/O/SEsOln0n62hTId4sG yiAg== X-Gm-Message-State: ACrzQf20no4dAt1tFM1CzFUaEqHUIi/ZQuWijno9B2YmC83HnWFWoDkE qVSA57SV+maS0SPTrHpYHi+BDCwUGtIHUw== X-Google-Smtp-Source: AMsMyM79y1rM6aAQ3/1f3BKXwVvkldEwZiTCyJOd1oqYgmngq62XIbI78g6wHdKw7+NT5rAOIKRK4w== X-Received: by 2002:a05:6512:4005:b0:49e:6f0a:b09e with SMTP id br5-20020a056512400500b0049e6f0ab09emr12354347lfb.330.1664349972648; Wed, 28 Sep 2022 00:26:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u21-20020ac258d5000000b00494a27500c1sm393237lfo.163.2022.09.28.00.26.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 00:26:12 -0700 (PDT) Message-ID: Date: Wed, 28 Sep 2022 09:26:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/2] ARM: dts: qcom: pm8941: fix iadc node Content-Language: en-US To: Luca Weiss , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220925161821.78030-1-luca@z3ntu.xyz> <20220925161821.78030-2-luca@z3ntu.xyz> <74ef3de8-5be0-70ec-e34b-717ba93d3d77@linaro.org> <1828122.tdWV9SEqCh@g550jk> From: Krzysztof Kozlowski In-Reply-To: <1828122.tdWV9SEqCh@g550jk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/09/2022 17:05, Luca Weiss wrote: > Hi Krzysztof, > > On Montag, 26. September 2022 10:54:23 CEST Krzysztof Kozlowski wrote: >> On 25/09/2022 18:18, Luca Weiss wrote: >>> The iadc node name is supposed to be just 'adc' and the compatible is >>> only supposed to be qcom,spmi-iadc according to the bindings. >>> >>> Adjust the node to match that. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> >>> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi >>> b/arch/arm/boot/dts/qcom-pm8941.dtsi index 3c15eecf2f21..33517cccee01 >>> 100644 >>> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi >>> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi >>> @@ -131,8 +131,8 @@ adc-chan@48 { >>> >>> }; >>> >>> }; >>> >>> - pm8941_iadc: iadc@3600 { >>> - compatible = "qcom,pm8941-iadc", > "qcom,spmi-iadc"; >>> + pm8941_iadc: adc@3600 { >>> + compatible = "qcom,spmi-iadc"; >> >> I am not sure this is correct. Usually specific compatibles are encouraged. > > I'm happy to change it the other way also. > > But the sibling of this compatible, qcom,spmi-vadc also only has that single > compatible so it'd align it with that. Ugh, there is a mess around them. Some other ADCs have specific compatibles, some not, so there is no consistency. I propose to have device specific compatible with qcom,spmi-iadc fallback, so basically document the DTS in bindings. Maybe other IADC will need some quirks, so specific compatible helps here. Best regards, Krzysztof