From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7A3C433FE for ; Tue, 22 Feb 2022 21:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbiBVVXd (ORCPT ); Tue, 22 Feb 2022 16:23:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235735AbiBVVXc (ORCPT ); Tue, 22 Feb 2022 16:23:32 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0351BC627A for ; Tue, 22 Feb 2022 13:23:06 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id j7so27396053lfu.6 for ; Tue, 22 Feb 2022 13:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=jtBVx2Q/oC2O51WQvIZoigpKLKNp7EeBw9E1UoJ7r14=; b=mAa8bFMjWfWT9TC79LezRPpW/O5teRZRBGOhGeyZlyPSn1RHq2IC87Lql6EkKB7Q9m mWTGKLknMy42DlWk53dfq8vebjptcTZh6UxaO0cddBDBmquX3n9al0Dqy9jX0rj7IZ02 1VZKBc9lz4Sk37aQVP8iDCiQOm/V2CeoounJUpha1YMvihrLHinMviFRB7MLSZyWzBoj VIpbYCKPeZGB9rygAk59ibEocVP51rrPpEeTfuMsqlHME1qioGGOfoITrhi9YsPi/Ylt KFL/EJ8TWFhqkvM2YB8Qszca7EvBlru9P36GBNQ3E39PGwe9YvcU2QIurKKcVl1MHHNW l4pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jtBVx2Q/oC2O51WQvIZoigpKLKNp7EeBw9E1UoJ7r14=; b=Xa01kHANtCgAjdYKSNXS8jyncvdbFXYfHQppUIdDt3Xx5eS+w7o+dgZEfnRVRA7T6D 2pnK1w+9yMQBzDc2/8Oi4omhEaT6QheGWKgjy5hvrgmfcZ6uW3jov4YkbYit6E+fetVz OfDjugtTbmJo9g9eEWRD+mDhkIZeSmwmPA/lY7pl2Fb9rYsE7wBw5TUsWHb9i+c64CVE OULM938Kh246HM1gifDaxtX+7RsGSvYfj5TpIzAJV2GWvTjvgQnUkqGNLCsPa7ThvPEX 2CtaWZMRLQti81LqA3LEZZnqS67amL6XP7DxOINwyeRpIpWzkauajHK1oBNW9vngq5d5 aiqw== X-Gm-Message-State: AOAM5305lLj/UwncT6DVz5clpDNuWMaZ3FPys0uQVz+RTt8bbd8cgQKs 25+7KVmqjYHHa4H/qkJ+S84cAw== X-Google-Smtp-Source: ABdhPJzpuqxZyPb0Aal7oIwfG1XVN3zZsfnOTv+F0lFTZPwG9KQdFdeL5m54z3cXCPgTPAfvJx5dzw== X-Received: by 2002:ac2:51d0:0:b0:43a:df78:18c with SMTP id u16-20020ac251d0000000b0043adf78018cmr18410052lfm.168.1645564984361; Tue, 22 Feb 2022 13:23:04 -0800 (PST) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id k14sm1847626ljh.82.2022.02.22.13.23.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 13:23:03 -0800 (PST) Message-ID: Date: Wed, 23 Feb 2022 00:23:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP Content-Language: en-GB To: Doug Anderson Cc: Vinod Polimera , dri-devel , linux-arm-msm , freedreno , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Andy Gross , Bjorn Andersson , Rob Herring , Rob Clark , Sean Paul , Stephen Boyd , Krzysztof Kozlowski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , quic_kalyant@quicinc.com, Sankeerth Billakanti , quic_vproddut@quicinc.com References: <1645455086-9359-1-git-send-email-quic_vpolimer@quicinc.com> <1645455086-9359-2-git-send-email-quic_vpolimer@quicinc.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/02/2022 22:25, Doug Anderson wrote: > Hi, > > On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov > wrote: >> >>> +static int dp_link_psr_status(struct dp_link_private *link) >>> +{ >>> + u8 status[2]; >>> + >>> + drm_dp_dpcd_read(link->aux, DP_PSR_ERROR_STATUS, status, 2); >>> + >>> + if (status[0] & DP_PSR_LINK_CRC_ERROR) >>> + DRM_ERROR("PSR LINK CRC ERROR\n"); >>> + else if (status[0] & DP_PSR_RFB_STORAGE_ERROR) >>> + DRM_ERROR("PSR RFB STORAGE ERROR\n"); >>> + else if (status[0] & DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR) >>> + DRM_ERROR("PSR VSC SDP UNCORRECTABLE ERROR\n"); >>> + else if (status[1] & DP_PSR_CAPS_CHANGE) >>> + DRM_INFO("PSR Capability Change\n"); >> >> DRM_DEBUG_DP > > Not sure I'll have time to go back and review the series, but one > thing that caught my eye as this flashed through my inbox is that I > think all of these "shouting" are deprecated. It's even officially > documented now as of commit d2f0a8afc1be ("UPSTREAM: drm/print: Add > deprecation notes to DRM_...() functions"). Agreed. But not the DRM_INFO too. -- With best wishes Dmitry