From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B39C77B73 for ; Mon, 1 May 2023 16:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232498AbjEAQBG (ORCPT ); Mon, 1 May 2023 12:01:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232698AbjEAQBE (ORCPT ); Mon, 1 May 2023 12:01:04 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1759612E for ; Mon, 1 May 2023 09:01:03 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3062c1e7df8so821658f8f.1 for ; Mon, 01 May 2023 09:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682956861; x=1685548861; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x8XFH13zanbc2i0C+jTsrlpaQVDgaN9DzDRKTIvVf2Y=; b=K9UUnLiQXZ9TOhPoJ2eLUXLFjcKWkb2/Ft/e5ZRiTmh6rwZ9OF0Gxsm+p7W8jcVewI HTMNeVSS554DA5Wlb2V4AKLnGNOnQlto0KA9C109/yeGRNkoP30jHz0h1RrwkZSMEIWz dju14qDOsvvppcg3Aeyp9oWMAsVNo20e4XxNpCM+h9CJtAsUkn58ZUf0ipj+6eJNMGsA 6+oSpgPGBaBu2rAC81GcBAqZWfzDDL88d1/F77VKq0H5k0EbF0hWoAt+0t8gtIUdF3OF 3nLB/OfxdyGlyNT+kv3AvxGffaSgQWd9Ow8e1JSbmQcxMbGzkFKlZq3dDEdvcvHtV1Qu BSDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682956861; x=1685548861; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x8XFH13zanbc2i0C+jTsrlpaQVDgaN9DzDRKTIvVf2Y=; b=CcMhlUAF5gfStXdp1Wnb/Yeyol0rMFWp8UqZf/+tlgpWMYYLTYc6axZpwOsqVhE8Ce C/bkKUUj5kO6OMakWNQ/vbqH4fonjC9l79ccusbcDtQMjRId/QN3Bet/kKWPS7mIT6Tp 7iQgjdOohySzSgQBVi43eStycl0/2hG1jw8u9Mohf55V8K/8DGttSv60A4I0HCzKoVan BtrsgbTTbJlt9jqlkmWnlE668o/Em5dZulHXDARYSE4PX7jA8tenjaUNzJ0w3OQqn3t6 TDGmkfZZxLGC/aO+uKkDuRrRMixoVhnxSzrJk2amLApu+YwZe6O/1sqtGOqPaHX4ipuQ darg== X-Gm-Message-State: AC+VfDwm9A+tF2g7+/w4Xr8+WcXEqkxgKmgyHdmxtfywotr03Liy1fRi UqJMfz++mSwgs9Fd2PY9RSibag== X-Google-Smtp-Source: ACHHUZ64n5TqDLh64E0B7bmlfS56FhfwmZTNP1/WJaNvdHvKL9I43O+hXpP+SWtQr+7qy1TCfMafdg== X-Received: by 2002:adf:ef06:0:b0:304:8149:239b with SMTP id e6-20020adfef06000000b003048149239bmr9031893wro.50.1682956861574; Mon, 01 May 2023 09:01:01 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id c11-20020a5d63cb000000b003062cdc6ac5sm3318628wrw.89.2023.05.01.09.01.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 May 2023 09:01:01 -0700 (PDT) Message-ID: Date: Mon, 1 May 2023 17:00:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v6 13/13] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy Content-Language: en-US To: Jianhua Lu Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, luca.weiss@fairphone.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, caleb.connolly@linaro.org, konrad.dybcio@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230501121111.1058190-1-bryan.odonoghue@linaro.org> <20230501121111.1058190-14-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/05/2023 16:34, Jianhua Lu wrote: >> &usb_2 { >> @@ -1375,6 +1383,12 @@ pm8150b_role_switch_out: endpoint { >> remote-endpoint = <&dwc3_role_switch_in>; >> }; >> }; > Should add port@0 for usb_1_hsphy because it is required Not by the hardware its not. The combophy is exclusively responsible for processing the orientation switch. The only required port in usb-c-connector is port@0 i.e. you have to have one thing the usb-c-connector can connect to for data-role switching. Now.. I'd take the input that <&qmpphy_typec_mux_in> is not documented but relies on commit d56de8c9a17d8f5202d0f37dd06ce186cc512586 Author: Li Jun Date: Tue Mar 28 16:23:04 2023 +0800 usb: typec: tcpm: try to get role switch from tcpc fwnode because that is the case. I will add something to documentation to capture the case where we use a usb-c-connector to trigger an type-c mux orientation switch. --- bod