From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3436C2D0DB for ; Wed, 22 Jan 2020 13:39:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C731B20704 for ; Wed, 22 Jan 2020 13:39:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="taziyYJQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725802AbgAVNjU (ORCPT ); Wed, 22 Jan 2020 08:39:20 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:46584 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbgAVNjU (ORCPT ); Wed, 22 Jan 2020 08:39:20 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 00MDd0cM057467; Wed, 22 Jan 2020 07:39:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1579700340; bh=co1m/tnZ+ImTwD3yuXyZxVaG3wlifWau9XX6MEe8Chg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=taziyYJQlSzT2GyfKCypQhi5IB6lZr9GRxURow+X6+pPSQokO3HMZ5n1Ktm1eOZV+ QOsv5YUsmbCQO9rciykyNX8OSaR8Ff8g2cuKfD4CCH/IloXOHZA9/Fm6d1FFzbQAcT LwBwM8c5O1wWlnzNP20hbrcxQGLBFFveLKn91q14= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 00MDd05r065172 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Jan 2020 07:39:00 -0600 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 22 Jan 2020 07:38:59 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 22 Jan 2020 07:38:59 -0600 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 00MDcxqI104110; Wed, 22 Jan 2020 07:38:59 -0600 Subject: Re: [PATCH 1/3] dt-bindings: net: can: m_can: Add Documentation for stb-gpios To: Faiz Abbas , , , , , CC: , , , , , , , , References: <20200122080310.24653-1-faiz_abbas@ti.com> <20200122080310.24653-2-faiz_abbas@ti.com> From: Dan Murphy Message-ID: Date: Wed, 22 Jan 2020 07:35:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200122080310.24653-2-faiz_abbas@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Faiz On 1/22/20 2:03 AM, Faiz Abbas wrote: > The CAN transceiver on some boards has an STB pin which is > used to control its standby mode. Add an optional property > stb-gpios to toggle the same. > > Signed-off-by: Faiz Abbas > Signed-off-by: Sekhar Nori > --- > Documentation/devicetree/bindings/net/can/m_can.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt > index ed614383af9c..cc8ba3f7a2aa 100644 > --- a/Documentation/devicetree/bindings/net/can/m_can.txt > +++ b/Documentation/devicetree/bindings/net/can/m_can.txt > @@ -48,6 +48,8 @@ Optional Subnode: > that can be used for CAN/CAN-FD modes. See > Documentation/devicetree/bindings/net/can/can-transceiver.txt > for details. > +stb-gpios : gpio node to toggle the STB (standby) signal on the transceiver > + The m_can.txt is for the m_can framework.  If this is specific to the platform then it really does not belong here. If the platform has specific nodes then maybe we need a m_can_platform.txt binding for specific platform nodes.  But I leave that decision to Rob. Also I prefer you spell out standby like the gpios are spelled out in the tcan binding. Dan > Example: > SoC dtsi: > m_can1: can@20e8000 {