From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>,
linux-phy@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 1/6] dt-bindings: phy: qcom,hdmi-phy-other: use pxo clock
Date: Fri, 9 Sep 2022 18:44:11 +0200 [thread overview]
Message-ID: <c3b4638e-05f7-cc73-b893-422f92909f6e@linaro.org> (raw)
In-Reply-To: <59242592-4e3d-b7c2-e0bb-b39df780c26b@linaro.org>
On 09/09/2022 17:03, Dmitry Baryshkov wrote:
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 1
>>> + maxItems: 2
>>> + clock-names:
>>> + minItems: 1
>>> + items:
>>> + - const: slave_iface
>>> + - const: pxo
>>
>> Why pxo is optional? Commit msg does not say much here.
>
> It's optional as it is not present in current DT files. The driver will
> fallback to 'pxo_board' if the clock is not present.
>
>> It seems you also miss the DTS change adding the clock.
>
> Oh, I'll add it to v2.
How about adding it to DTS and making it required in the bindings? I did
not check the driver, but isn't the driver fail if clock is missing thus
the clock is really required?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-09 16:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 13:20 [PATCH 0/6] drm/msm/hdmi: update hdmi_pll_8960 driver Dmitry Baryshkov
2022-09-09 13:20 ` [PATCH 1/6] dt-bindings: phy: qcom,hdmi-phy-other: use pxo clock Dmitry Baryshkov
2022-09-09 13:30 ` Krzysztof Kozlowski
2022-09-09 15:03 ` Dmitry Baryshkov
2022-09-09 16:44 ` Krzysztof Kozlowski [this message]
2022-09-09 20:29 ` Dmitry Baryshkov
2022-09-10 7:53 ` Krzysztof Kozlowski
2022-09-09 13:20 ` [PATCH 2/6] dt-bindings: phy: qcom,hdmi-phy-other: mark it as clock provider Dmitry Baryshkov
2022-09-09 13:31 ` Krzysztof Kozlowski
2022-09-09 13:20 ` [PATCH 3/6] drm/msm/hdmi: switch hdmi_pll_8960 to use parent_data Dmitry Baryshkov
2022-09-09 13:20 ` [PATCH 4/6] drm/msm/hdmi: make hdmi_phy_8960 OF clk provider Dmitry Baryshkov
2022-09-09 13:20 ` [PATCH 5/6] ARM: dts: qcom: apq8064: add #clock-cells to the HDMI PHY node Dmitry Baryshkov
2022-09-09 13:31 ` Krzysztof Kozlowski
2022-09-09 13:20 ` [PATCH 6/6] ARM: dts: qcom: apq8064: use hdmi_phy for the MMCC's hdmipll clock Dmitry Baryshkov
2022-09-09 13:31 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-01-19 13:22 [PATCH 0/6] drm/msm/hdmi: integrate msm8960 HDMI PHY with DT clocks infrastructure Dmitry Baryshkov
2023-01-19 13:22 ` [PATCH 1/6] dt-bindings: phy: qcom,hdmi-phy-other: use pxo clock Dmitry Baryshkov
2023-01-26 11:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3b4638e-05f7-cc73-b893-422f92909f6e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).