devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh+dt@kernel.org>,
	Sriranjani P <sriranjani.p@samsung.com>
Cc: krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	alim.akhtar@samsung.com, pankaj.dubey@samsung.com,
	ravi.patel@samsung.com, sathya@samsung.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
Date: Mon, 9 Jan 2023 09:37:05 +0100	[thread overview]
Message-ID: <c3c35b5e-ec85-1226-c7a7-53bf4bd83713@linaro.org> (raw)
In-Reply-To: <CAL_JsqLAqSoVdExrHXZ4xVaY4Ut5R54izoumOY8zsXWN2e8++w@mail.gmail.com>

On 09/01/2023 02:15, Rob Herring wrote:
> On Tue, Dec 13, 2022 at 10:47 PM Sriranjani P <sriranjani.p@samsung.com> wrote:
>>
>> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
>> them and deprecate usage of generic Exynos850 compatible alone.
>>
>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>> ---
>>  .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 ++++++++++++---
>>  1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> index 4954790eda6c..427df05224e5 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> @@ -17,7 +17,6 @@ properties:
>>                - samsung,exynos3-sysreg
>>                - samsung,exynos4-sysreg
>>                - samsung,exynos5-sysreg
>> -              - samsung,exynos850-sysreg
>>                - samsung,exynosautov9-sysreg
>>                - tesla,fsd-cam-sysreg
>>                - tesla,fsd-fsys0-sysreg
>> @@ -33,9 +32,17 @@ properties:
>>            - const: samsung,exynos5433-sysreg
>>            - const: syscon
>>        - items:
>> -          - const: samsung,exynos5433-sysreg
>> +          - enum:
>> +              - samsung,exynos5433-sysreg
>> +              - samsung,exynos850-sysreg
>> +          - const: syscon
>> +            deprecated: true
> 
> This is throwing an error in linux-next now.
> 
> How can 1 item in a list be deprecated? What's the not deprecated
> value for the entry? Probably this needs to move up to 'items' as the
> whole entry is deprecated.

I missed this. I'll fix it. I'll updated my dtschema and see the error now.

Best regards,
Krzysztof


  reply	other threads:[~2023-01-09  8:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221214044418epcas5p3c2708eda3abcf5b217eddacf533e0a0f@epcas5p3.samsung.com>
2022-12-14  4:43 ` [PATCH v3 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 Sriranjani P
     [not found]   ` <CGME20221214044423epcas5p2920e87930665345169745002ec6993c3@epcas5p2.samsung.com>
2022-12-14  4:43     ` [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 Sriranjani P
2022-12-15 21:39       ` Sam Protsenko
2022-12-20 17:17       ` Rob Herring
2023-01-09  1:15       ` Rob Herring
2023-01-09  8:37         ` Krzysztof Kozlowski [this message]
     [not found]   ` <CGME20221214044427epcas5p39131549dc4529ea41d9916d81d3d5fce@epcas5p3.samsung.com>
2022-12-14  4:43     ` [PATCH v3 2/4] arm64: dts: exynos: " Sriranjani P
2022-12-15 21:39       ` Sam Protsenko
     [not found]   ` <CGME20221214044430epcas5p4c896fde60471fea774387bd74abe0ea5@epcas5p4.samsung.com>
2022-12-14  4:43     ` [PATCH v3 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9 Sriranjani P
2022-12-20 12:32       ` Chanho Park
2022-12-20 17:18       ` Rob Herring
     [not found]   ` <CGME20221214044434epcas5p212735c11a8ff9f72e25742e4ac8a7794@epcas5p2.samsung.com>
2022-12-14  4:43     ` [PATCH v3 4/4] arm64: dts: exynos: " Sriranjani P
2022-12-20 12:34       ` Chanho Park
2022-12-26 15:17   ` [PATCH v3 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3c35b5e-ec85-1226-c7a7-53bf4bd83713@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=pankaj.dubey@samsung.com \
    --cc=ravi.patel@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=sathya@samsung.com \
    --cc=sriranjani.p@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).