* [PATCH 0/2] Add Samsung AMS639RQ08 panel support @ 2024-06-09 20:36 Danila Tikhonov 2024-06-09 20:36 ` [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08 Danila Tikhonov 2024-06-09 20:36 ` [PATCH 2/2] drm/panel: Add Samsung AMS639RQ08 panel driver Danila Tikhonov 0 siblings, 2 replies; 5+ messages in thread From: Danila Tikhonov @ 2024-06-09 20:36 UTC (permalink / raw) To: neil.armstrong, quic_jesszhan, sam, maarten.lankhorst, mripard, tzimmermann, airlied, daniel, robh, krzk+dt, conor+dt Cc: dri-devel, devicetree, linux-kernel, adrian, degdagmohamed, Danila Tikhonov This series adds Samsung AMS639RQ08 panel support used in: - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis) - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci) - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael) Was tested on sm7150-xiaomi-davinci and sm8150-xiaomi-raphael. Based on my analysis of the downstream DTS, this driver should be fully compatible with the sdm710-xiaomi-pyxis (unfortunately not tested) without requiring any modifications. To: Neil Armstrong <neil.armstrong@linaro.org> To: Jessica Zhang <quic_jesszhan@quicinc.com> To: Sam Ravnborg <sam@ravnborg.org> To: David Airlie <airlied@gmail.com> To: Daniel Vetter <daniel@ffwll.ch> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> To: Maxime Ripard <mripard@kernel.org> To: Thomas Zimmermann <tzimmermann@suse.de> To: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzk+dt@kernel.org> To: Conor Dooley <conor+dt@kernel.org> Cc: dri-devel@lists.freedesktop.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Jens Reidel <adrian@travitia.xyz> Cc: Degdag Mohamed <degdagmohamed@gmail.com> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> Danila Tikhonov (2): dt-bindings: display: panel: Add Samsung AMS639RQ08 drm/panel: Add Samsung AMS639RQ08 panel driver .../display/panel/samsung,ams639rq08.yaml | 80 ++++ drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-samsung-ams639rq08.c | 362 ++++++++++++++++++ 4 files changed, 452 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml create mode 100644 drivers/gpu/drm/panel/panel-samsung-ams639rq08.c -- 2.45.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08 2024-06-09 20:36 [PATCH 0/2] Add Samsung AMS639RQ08 panel support Danila Tikhonov @ 2024-06-09 20:36 ` Danila Tikhonov 2024-06-10 8:11 ` Krzysztof Kozlowski 2024-06-09 20:36 ` [PATCH 2/2] drm/panel: Add Samsung AMS639RQ08 panel driver Danila Tikhonov 1 sibling, 1 reply; 5+ messages in thread From: Danila Tikhonov @ 2024-06-09 20:36 UTC (permalink / raw) To: neil.armstrong, quic_jesszhan, sam, maarten.lankhorst, mripard, tzimmermann, airlied, daniel, robh, krzk+dt, conor+dt Cc: dri-devel, devicetree, linux-kernel, adrian, degdagmohamed, Danila Tikhonov The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode AMOLED panel used in: - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis) - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci) - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael) Add a dt-binding for it. Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> --- .../display/panel/samsung,ams639rq08.yaml | 80 +++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml b/Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml new file mode 100644 index 0000000000000..3a561156f5601 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,ams639rq08.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung AMS639RQ08 EA8076-based 6.39" 1080x2340 MIPI-DSI Panel + +maintainers: + - Danila Tikhonov <danila@jiaxyga.com> + - Jens Reidel <adrian@travitia.xyz> + +description: | + The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode AMOLED panel. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: samsung,ams639rq08 + + reg: + maxItems: 1 + + vdd3p3-supply: + description: 3.3V source voltage rail + + vddio-supply: + description: I/O source voltage rail + + vsn-supply: + description: Positive source voltage rail + + vsp-supply: + description: Negative source voltage rail + + reset-gpios: true + port: true + +additionalProperties: false + +required: + - compatible + - reg + - vdd3p3-supply + - vddio-supply + - vsn-supply + - vsp-supply + - reset-gpios + - port + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "samsung,ams639rq08"; + reg = <0>; + + vdd3p3-supply = <&vreg_l18a_2p8>; + vddio-supply = <&vreg_l13a_1p8>; + vsn-supply = <&vreg_ibb>; + vsp-supply = <&vreg_lab>; + + reset-gpios = <&pm6150l_gpios 9 GPIO_ACTIVE_LOW>; + + port { + panel_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; + }; + +... -- 2.45.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08 2024-06-09 20:36 ` [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08 Danila Tikhonov @ 2024-06-10 8:11 ` Krzysztof Kozlowski 0 siblings, 0 replies; 5+ messages in thread From: Krzysztof Kozlowski @ 2024-06-10 8:11 UTC (permalink / raw) To: Danila Tikhonov, neil.armstrong, quic_jesszhan, sam, maarten.lankhorst, mripard, tzimmermann, airlied, daniel, robh, krzk+dt, conor+dt Cc: dri-devel, devicetree, linux-kernel, adrian, degdagmohamed On 09/06/2024 22:36, Danila Tikhonov wrote: > The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode > AMOLED panel used in: > - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis) > - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci) > - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael) > Add a dt-binding for it. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> If there is going to be any new posting, then two changes: > +maintainers: > + - Danila Tikhonov <danila@jiaxyga.com> > + - Jens Reidel <adrian@travitia.xyz> > + > +description: | Do not need '|' unless you need to preserve formatting. > + The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode AMOLED panel. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: samsung,ams639rq08 > + > + reg: > + maxItems: 1 > + > + vdd3p3-supply: > + description: 3.3V source voltage rail > + > + vddio-supply: > + description: I/O source voltage rail > + > + vsn-supply: > + description: Positive source voltage rail > + > + vsp-supply: > + description: Negative source voltage rail > + > + reset-gpios: true > + port: true > + > +additionalProperties: false This goes after "required:" block. > + > +required: > + - compatible > + - reg > + - vdd3p3-supply > + - vddio-supply > + - vsn-supply > + - vsp-supply > + - reset-gpios > + - port > + Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] drm/panel: Add Samsung AMS639RQ08 panel driver 2024-06-09 20:36 [PATCH 0/2] Add Samsung AMS639RQ08 panel support Danila Tikhonov 2024-06-09 20:36 ` [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08 Danila Tikhonov @ 2024-06-09 20:36 ` Danila Tikhonov 2024-06-11 7:51 ` neil.armstrong 1 sibling, 1 reply; 5+ messages in thread From: Danila Tikhonov @ 2024-06-09 20:36 UTC (permalink / raw) To: neil.armstrong, quic_jesszhan, sam, maarten.lankhorst, mripard, tzimmermann, airlied, daniel, robh, krzk+dt, conor+dt Cc: dri-devel, devicetree, linux-kernel, adrian, degdagmohamed, Danila Tikhonov Add the driver for Samsung AMS639RQ08 FHD Plus CMD mode panel support found in: - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis) - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci) - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael) Tested-by: Degdag Mohamed <degdagmohamed@gmail.com> # xiaomi-raphael Tested-by: Jens Reidel <adrian@travitia.xyz> # xiaomi-davinci Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-samsung-ams639rq08.c | 362 ++++++++++++++++++ 3 files changed, 372 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-samsung-ams639rq08.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 2ae0eb0638f32..8a86960ae812a 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -576,6 +576,15 @@ config DRM_PANEL_RONBO_RB070D30 Say Y here if you want to enable support for Ronbo Electronics RB070D30 1024x600 DSI panel. +config DRM_PANEL_SAMSUNG_AMS639RQ08 + tristate "Samsung AMS639RQ08 panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y or M here if you want to enable support for the + Samsung AMS639RQ08 FHD Plus (2340x1080@60Hz) CMD mode panel. + config DRM_PANEL_SAMSUNG_S6E88A0_AMS452EF01 tristate "Samsung AMS452EF01 panel with S6E88A0 DSI video mode controller" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index f0203f6e02f44..eb87bc01b0414 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -58,6 +58,7 @@ obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM68200) += panel-raydium-rm68200.o obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM692E5) += panel-raydium-rm692e5.o obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM69380) += panel-raydium-rm69380.o obj-$(CONFIG_DRM_PANEL_RONBO_RB070D30) += panel-ronbo-rb070d30.o +obj-$(CONFIG_DRM_PANEL_SAMSUNG_AMS639RQ08) += panel-samsung-ams639rq08.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20) += panel-samsung-atna33xc20.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_DB7430) += panel-samsung-db7430.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_LD9040) += panel-samsung-ld9040.o diff --git a/drivers/gpu/drm/panel/panel-samsung-ams639rq08.c b/drivers/gpu/drm/panel/panel-samsung-ams639rq08.c new file mode 100644 index 0000000000000..f9789fdd6c326 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-samsung-ams639rq08.c @@ -0,0 +1,362 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com> + */ + +#include <linux/backlight.h> +#include <linux/delay.h> +#include <linux/gpio/consumer.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/regulator/consumer.h> + +#include <video/mipi_display.h> + +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> +#include <drm/drm_probe_helper.h> + +/* Manufacturer Command Set */ +#define MCS_ACCESS_PROT_OFF 0xb0 +#define MCS_UNKNOWN_B7 0xb7 +#define MCS_BIAS_CURRENT_CTRL 0xd1 +#define MCS_PASSWD1 0xf0 +#define MCS_PASSWD2 0xfc +#define MCS_UNKNOWN_FF 0xff + +struct ams639rq08 { + struct drm_panel panel; + struct mipi_dsi_device *dsi; + struct gpio_desc *reset_gpio; + struct regulator_bulk_data supplies[4]; +}; + +static inline struct ams639rq08 *to_ams639rq08(struct drm_panel *panel) +{ + return container_of(panel, struct ams639rq08, panel); +} + +static void ams639rq08_reset(struct ams639rq08 *ctx) +{ + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + usleep_range(1000, 2000); + gpiod_set_value_cansleep(ctx->reset_gpio, 0); + usleep_range(10000, 11000); +} + +static int ams639rq08_on(struct ams639rq08 *ctx) +{ + struct mipi_dsi_device *dsi = ctx->dsi; + struct device *dev = &dsi->dev; + int ret; + + /* Delay 2ms for VCI1 power */ + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0x5a, 0x5a); + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0x5a, 0x5a); + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x0c); + mipi_dsi_dcs_write_seq(dsi, MCS_UNKNOWN_FF, 0x10); + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x2f); + mipi_dsi_dcs_write_seq(dsi, MCS_BIAS_CURRENT_CTRL, 0x01); + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5); + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0xa5, 0xa5); + + /* Sleep Out */ + ret = mipi_dsi_dcs_exit_sleep_mode(dsi); + if (ret < 0) { + dev_err(dev, "Failed to exit sleep mode: %d\n", ret); + return ret; + } + usleep_range(10000, 11000); + + /* TE OUT (Vsync On) */ + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0x5a, 0x5a); + + ret = mipi_dsi_dcs_set_tear_on(dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK); + if (ret < 0) { + dev_err(dev, "Failed to set tear on: %d\n", ret); + return ret; + } + + /* DBV Smooth Transition */ + mipi_dsi_dcs_write_seq(dsi, MCS_UNKNOWN_B7, 0x01, 0x4b); + + /* Edge Dimming Speed Setting */ + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x06); + mipi_dsi_dcs_write_seq(dsi, MCS_UNKNOWN_B7, 0x10); + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5); + + /* Page Address Set */ + ret = mipi_dsi_dcs_set_page_address(dsi, 0x0000, 0x0923); + if (ret < 0) { + dev_err(dev, "Failed to set page address: %d\n", ret); + return ret; + } + + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0x5a, 0x5a); + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0x5a, 0x5a); + + /* Set DDIC internal HFP */ + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x23); + mipi_dsi_dcs_write_seq(dsi, MCS_BIAS_CURRENT_CTRL, 0x11); + + /* OFC Setting 84.1 Mhz */ + mipi_dsi_dcs_write_seq(dsi, 0xe9, 0x11, 0x55, + 0xa6, 0x75, 0xa3, + 0xb9, 0xa1, 0x4a, + 0x00, 0x1a, 0xb8); + + /* Err_FG Setting */ + mipi_dsi_dcs_write_seq(dsi, 0xe1, + 0x00, 0x00, 0x02, + 0x02, 0x42, 0x02); + mipi_dsi_dcs_write_seq(dsi, 0xe2, + 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00); + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x0c); + mipi_dsi_dcs_write_seq(dsi, 0xe1, 0x19); + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5); + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0xa5, 0xa5); + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x20); + + /* Brightness Control */ + ret = mipi_dsi_dcs_set_display_brightness(dsi, 0x0000); + if (ret < 0) { + dev_err(dev, "Failed to set display brightness: %d\n", ret); + return ret; + } + + /* Display On */ + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, 0x00); + msleep(67); + + ret = mipi_dsi_dcs_set_display_on(dsi); + if (ret < 0) { + dev_err(dev, "Failed to set display on: %d\n", ret); + return ret; + } + + return 0; +} + +static int ams639rq08_off(struct ams639rq08 *ctx) +{ + struct mipi_dsi_device *dsi = ctx->dsi; + struct device *dev = &dsi->dev; + int ret; + + ret = mipi_dsi_dcs_set_display_off(dsi); + if (ret < 0) { + dev_err(dev, "Failed to set display off: %d\n", ret); + return ret; + } + + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); + if (ret < 0) { + dev_err(dev, "Failed to enter sleep mode: %d\n", ret); + return ret; + } + msleep(120); + + return 0; +} + +static int ams639rq08_prepare(struct drm_panel *panel) +{ + struct ams639rq08 *ctx = to_ams639rq08(panel); + struct device *dev = &ctx->dsi->dev; + int ret; + + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + if (ret < 0) { + dev_err(dev, "Failed to enable regulators: %d\n", ret); + return ret; + } + + ams639rq08_reset(ctx); + + ret = ams639rq08_on(ctx); + if (ret < 0) { + dev_err(dev, "Failed to initialize panel: %d\n", ret); + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + return ret; + } + + return 0; +} + +static int ams639rq08_unprepare(struct drm_panel *panel) +{ + struct ams639rq08 *ctx = to_ams639rq08(panel); + struct device *dev = &ctx->dsi->dev; + int ret; + + ret = ams639rq08_off(ctx); + if (ret < 0) + dev_err(dev, "Failed to un-initialize panel: %d\n", ret); + + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + + return 0; +} + +static const struct drm_display_mode ams639rq08_mode = { + .clock = (1080 + 64 + 20 + 64) * (2340 + 64 + 20 + 64) * 60 / 1000, + .hdisplay = 1080, + .hsync_start = 1080 + 64, + .hsync_end = 1080 + 64 + 20, + .htotal = 1080 + 64 + 20 + 64, + .vdisplay = 2340, + .vsync_start = 2340 + 64, + .vsync_end = 2340 + 64 + 20, + .vtotal = 2340 + 64 + 20 + 64, + .width_mm = 68, + .height_mm = 147, + .type = DRM_MODE_TYPE_DRIVER, +}; + +static int ams639rq08_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + return drm_connector_helper_get_modes_fixed(connector, &ams639rq08_mode); +} + +static const struct drm_panel_funcs ams639rq08_panel_funcs = { + .prepare = ams639rq08_prepare, + .unprepare = ams639rq08_unprepare, + .get_modes = ams639rq08_get_modes, +}; + +static int ams639rq08_bl_update_status(struct backlight_device *bl) +{ + struct mipi_dsi_device *dsi = bl_get_data(bl); + u16 brightness = backlight_get_brightness(bl); + int ret; + + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; + + ret = mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); + if (ret < 0) + return ret; + + dsi->mode_flags |= MIPI_DSI_MODE_LPM; + + return 0; +} + +static int ams639rq08_bl_get_brightness(struct backlight_device *bl) +{ + struct mipi_dsi_device *dsi = bl_get_data(bl); + u16 brightness; + int ret; + + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; + + ret = mipi_dsi_dcs_get_display_brightness_large(dsi, &brightness); + if (ret < 0) + return ret; + + dsi->mode_flags |= MIPI_DSI_MODE_LPM; + + return brightness; +} + +static const struct backlight_ops ams639rq08_bl_ops = { + .update_status = ams639rq08_bl_update_status, + .get_brightness = ams639rq08_bl_get_brightness, +}; + +static struct backlight_device * +ams639rq08_create_backlight(struct mipi_dsi_device *dsi) +{ + struct device *dev = &dsi->dev; + const struct backlight_properties props = { + .type = BACKLIGHT_RAW, + .brightness = 1023, + .max_brightness = 2047, + }; + + return devm_backlight_device_register(dev, dev_name(dev), dev, dsi, + &ams639rq08_bl_ops, &props); +} + +static int ams639rq08_probe(struct mipi_dsi_device *dsi) +{ + struct device *dev = &dsi->dev; + struct ams639rq08 *ctx; + int ret; + + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + ctx->supplies[0].supply = "vdd3p3"; + ctx->supplies[1].supply = "vddio"; + ctx->supplies[2].supply = "vsn"; + ctx->supplies[3].supply = "vsp"; + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), + ctx->supplies); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to get regulators\n"); + + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(ctx->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), + "Failed to get reset-gpios\n"); + + ctx->dsi = dsi; + mipi_dsi_set_drvdata(dsi, ctx); + + dsi->lanes = 4; + dsi->format = MIPI_DSI_FMT_RGB888; + dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM; + + drm_panel_init(&ctx->panel, dev, &ams639rq08_panel_funcs, + DRM_MODE_CONNECTOR_DSI); + ctx->panel.prepare_prev_first = true; + + ctx->panel.backlight = ams639rq08_create_backlight(dsi); + if (IS_ERR(ctx->panel.backlight)) + return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), + "Failed to create backlight\n"); + + drm_panel_add(&ctx->panel); + + ret = devm_mipi_dsi_attach(dev, dsi); + if (ret < 0) { + drm_panel_remove(&ctx->panel); + return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); + } + + return 0; +} + +static void ams639rq08_remove(struct mipi_dsi_device *dsi) +{ + struct ams639rq08 *ctx = mipi_dsi_get_drvdata(dsi); + + drm_panel_remove(&ctx->panel); +} + +static const struct of_device_id ams639rq08_of_match[] = { + { .compatible = "samsung,ams639rq08" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, ams639rq08_of_match); + +static struct mipi_dsi_driver ams639rq08_driver = { + .probe = ams639rq08_probe, + .remove = ams639rq08_remove, + .driver = { + .name = "panel-samsung-ams639rq08", + .of_match_table = ams639rq08_of_match, + }, +}; +module_mipi_dsi_driver(ams639rq08_driver); + +MODULE_AUTHOR("Danila Tikhonov <danila@jiaxyga.com>"); +MODULE_DESCRIPTION("DRM driver for SAMSUNG AMS639RQ08 cmd mode dsi panel"); +MODULE_LICENSE("GPL"); -- 2.45.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/panel: Add Samsung AMS639RQ08 panel driver 2024-06-09 20:36 ` [PATCH 2/2] drm/panel: Add Samsung AMS639RQ08 panel driver Danila Tikhonov @ 2024-06-11 7:51 ` neil.armstrong 0 siblings, 0 replies; 5+ messages in thread From: neil.armstrong @ 2024-06-11 7:51 UTC (permalink / raw) To: Danila Tikhonov, quic_jesszhan, sam, maarten.lankhorst, mripard, tzimmermann, airlied, daniel, robh, krzk+dt, conor+dt Cc: dri-devel, devicetree, linux-kernel, adrian, degdagmohamed On 09/06/2024 22:36, Danila Tikhonov wrote: > Add the driver for Samsung AMS639RQ08 FHD Plus CMD mode panel support > found in: > - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis) > - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci) > - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael) > > Tested-by: Degdag Mohamed <degdagmohamed@gmail.com> # xiaomi-raphael > Tested-by: Jens Reidel <adrian@travitia.xyz> # xiaomi-davinci > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-samsung-ams639rq08.c | 362 ++++++++++++++++++ > 3 files changed, 372 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-samsung-ams639rq08.c > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 2ae0eb0638f32..8a86960ae812a 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -576,6 +576,15 @@ config DRM_PANEL_RONBO_RB070D30 > Say Y here if you want to enable support for Ronbo Electronics > RB070D30 1024x600 DSI panel. > > +config DRM_PANEL_SAMSUNG_AMS639RQ08 > + tristate "Samsung AMS639RQ08 panel" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y or M here if you want to enable support for the > + Samsung AMS639RQ08 FHD Plus (2340x1080@60Hz) CMD mode panel. > + > config DRM_PANEL_SAMSUNG_S6E88A0_AMS452EF01 > tristate "Samsung AMS452EF01 panel with S6E88A0 DSI video mode controller" > depends on OF > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index f0203f6e02f44..eb87bc01b0414 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -58,6 +58,7 @@ obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM68200) += panel-raydium-rm68200.o > obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM692E5) += panel-raydium-rm692e5.o > obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM69380) += panel-raydium-rm69380.o > obj-$(CONFIG_DRM_PANEL_RONBO_RB070D30) += panel-ronbo-rb070d30.o > +obj-$(CONFIG_DRM_PANEL_SAMSUNG_AMS639RQ08) += panel-samsung-ams639rq08.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20) += panel-samsung-atna33xc20.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_DB7430) += panel-samsung-db7430.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_LD9040) += panel-samsung-ld9040.o > diff --git a/drivers/gpu/drm/panel/panel-samsung-ams639rq08.c b/drivers/gpu/drm/panel/panel-samsung-ams639rq08.c > new file mode 100644 > index 0000000000000..f9789fdd6c326 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-samsung-ams639rq08.c > @@ -0,0 +1,362 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com> > + */ > + > +#include <linux/backlight.h> > +#include <linux/delay.h> > +#include <linux/gpio/consumer.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/regulator/consumer.h> > + > +#include <video/mipi_display.h> > + > +#include <drm/drm_mipi_dsi.h> > +#include <drm/drm_modes.h> > +#include <drm/drm_panel.h> > +#include <drm/drm_probe_helper.h> > + > +/* Manufacturer Command Set */ > +#define MCS_ACCESS_PROT_OFF 0xb0 > +#define MCS_UNKNOWN_B7 0xb7 > +#define MCS_BIAS_CURRENT_CTRL 0xd1 > +#define MCS_PASSWD1 0xf0 > +#define MCS_PASSWD2 0xfc > +#define MCS_UNKNOWN_FF 0xff > + > +struct ams639rq08 { > + struct drm_panel panel; > + struct mipi_dsi_device *dsi; > + struct gpio_desc *reset_gpio; > + struct regulator_bulk_data supplies[4]; > +}; > + > +static inline struct ams639rq08 *to_ams639rq08(struct drm_panel *panel) > +{ > + return container_of(panel, struct ams639rq08, panel); > +} > + > +static void ams639rq08_reset(struct ams639rq08 *ctx) > +{ > + gpiod_set_value_cansleep(ctx->reset_gpio, 1); > + usleep_range(1000, 2000); > + gpiod_set_value_cansleep(ctx->reset_gpio, 0); > + usleep_range(10000, 11000); > +} > + > +static int ams639rq08_on(struct ams639rq08 *ctx) > +{ > + struct mipi_dsi_device *dsi = ctx->dsi; > + struct device *dev = &dsi->dev; > + int ret; > + > + /* Delay 2ms for VCI1 power */ > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0x5a, 0x5a); > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0x5a, 0x5a); > + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x0c); > + mipi_dsi_dcs_write_seq(dsi, MCS_UNKNOWN_FF, 0x10); > + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x2f); > + mipi_dsi_dcs_write_seq(dsi, MCS_BIAS_CURRENT_CTRL, 0x01); > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5); > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0xa5, 0xa5); > + > + /* Sleep Out */ > + ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > + if (ret < 0) { > + dev_err(dev, "Failed to exit sleep mode: %d\n", ret); > + return ret; > + } > + usleep_range(10000, 11000); > + > + /* TE OUT (Vsync On) */ > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0x5a, 0x5a); > + > + ret = mipi_dsi_dcs_set_tear_on(dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK); > + if (ret < 0) { > + dev_err(dev, "Failed to set tear on: %d\n", ret); > + return ret; > + } > + > + /* DBV Smooth Transition */ > + mipi_dsi_dcs_write_seq(dsi, MCS_UNKNOWN_B7, 0x01, 0x4b); > + > + /* Edge Dimming Speed Setting */ > + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x06); > + mipi_dsi_dcs_write_seq(dsi, MCS_UNKNOWN_B7, 0x10); > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5); > + > + /* Page Address Set */ > + ret = mipi_dsi_dcs_set_page_address(dsi, 0x0000, 0x0923); > + if (ret < 0) { > + dev_err(dev, "Failed to set page address: %d\n", ret); > + return ret; > + } > + > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0x5a, 0x5a); > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0x5a, 0x5a); > + > + /* Set DDIC internal HFP */ > + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x23); > + mipi_dsi_dcs_write_seq(dsi, MCS_BIAS_CURRENT_CTRL, 0x11); > + > + /* OFC Setting 84.1 Mhz */ > + mipi_dsi_dcs_write_seq(dsi, 0xe9, 0x11, 0x55, > + 0xa6, 0x75, 0xa3, > + 0xb9, 0xa1, 0x4a, > + 0x00, 0x1a, 0xb8); > + > + /* Err_FG Setting */ > + mipi_dsi_dcs_write_seq(dsi, 0xe1, > + 0x00, 0x00, 0x02, > + 0x02, 0x42, 0x02); > + mipi_dsi_dcs_write_seq(dsi, 0xe2, > + 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00); > + mipi_dsi_dcs_write_seq(dsi, MCS_ACCESS_PROT_OFF, 0x0c); > + mipi_dsi_dcs_write_seq(dsi, 0xe1, 0x19); > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5); > + mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0xa5, 0xa5); > + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x20); > + > + /* Brightness Control */ > + ret = mipi_dsi_dcs_set_display_brightness(dsi, 0x0000); > + if (ret < 0) { > + dev_err(dev, "Failed to set display brightness: %d\n", ret); > + return ret; > + } > + > + /* Display On */ > + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, 0x00); > + msleep(67); > + > + ret = mipi_dsi_dcs_set_display_on(dsi); > + if (ret < 0) { > + dev_err(dev, "Failed to set display on: %d\n", ret); > + return ret; > + } > + > + return 0; > +} > + > +static int ams639rq08_off(struct ams639rq08 *ctx) > +{ > + struct mipi_dsi_device *dsi = ctx->dsi; > + struct device *dev = &dsi->dev; > + int ret; > + > + ret = mipi_dsi_dcs_set_display_off(dsi); > + if (ret < 0) { > + dev_err(dev, "Failed to set display off: %d\n", ret); > + return ret; > + } > + > + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > + if (ret < 0) { > + dev_err(dev, "Failed to enter sleep mode: %d\n", ret); > + return ret; > + } > + msleep(120); > + > + return 0; > +} > + > +static int ams639rq08_prepare(struct drm_panel *panel) > +{ > + struct ams639rq08 *ctx = to_ams639rq08(panel); > + struct device *dev = &ctx->dsi->dev; > + int ret; > + > + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); > + if (ret < 0) { > + dev_err(dev, "Failed to enable regulators: %d\n", ret); > + return ret; > + } > + > + ams639rq08_reset(ctx); > + > + ret = ams639rq08_on(ctx); > + if (ret < 0) { > + dev_err(dev, "Failed to initialize panel: %d\n", ret); > + gpiod_set_value_cansleep(ctx->reset_gpio, 1); > + regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); > + return ret; > + } > + > + return 0; > +} > + > +static int ams639rq08_unprepare(struct drm_panel *panel) > +{ > + struct ams639rq08 *ctx = to_ams639rq08(panel); > + struct device *dev = &ctx->dsi->dev; > + int ret; > + > + ret = ams639rq08_off(ctx); > + if (ret < 0) > + dev_err(dev, "Failed to un-initialize panel: %d\n", ret); > + > + gpiod_set_value_cansleep(ctx->reset_gpio, 1); > + regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); > + > + return 0; > +} > + > +static const struct drm_display_mode ams639rq08_mode = { > + .clock = (1080 + 64 + 20 + 64) * (2340 + 64 + 20 + 64) * 60 / 1000, > + .hdisplay = 1080, > + .hsync_start = 1080 + 64, > + .hsync_end = 1080 + 64 + 20, > + .htotal = 1080 + 64 + 20 + 64, > + .vdisplay = 2340, > + .vsync_start = 2340 + 64, > + .vsync_end = 2340 + 64 + 20, > + .vtotal = 2340 + 64 + 20 + 64, > + .width_mm = 68, > + .height_mm = 147, > + .type = DRM_MODE_TYPE_DRIVER, > +}; > + > +static int ams639rq08_get_modes(struct drm_panel *panel, > + struct drm_connector *connector) > +{ > + return drm_connector_helper_get_modes_fixed(connector, &ams639rq08_mode); > +} > + > +static const struct drm_panel_funcs ams639rq08_panel_funcs = { > + .prepare = ams639rq08_prepare, > + .unprepare = ams639rq08_unprepare, > + .get_modes = ams639rq08_get_modes, > +}; > + > +static int ams639rq08_bl_update_status(struct backlight_device *bl) > +{ > + struct mipi_dsi_device *dsi = bl_get_data(bl); > + u16 brightness = backlight_get_brightness(bl); > + int ret; > + > + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > + > + ret = mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); > + if (ret < 0) > + return ret; > + > + dsi->mode_flags |= MIPI_DSI_MODE_LPM; > + > + return 0; > +} > + > +static int ams639rq08_bl_get_brightness(struct backlight_device *bl) > +{ > + struct mipi_dsi_device *dsi = bl_get_data(bl); > + u16 brightness; > + int ret; > + > + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > + > + ret = mipi_dsi_dcs_get_display_brightness_large(dsi, &brightness); > + if (ret < 0) > + return ret; > + > + dsi->mode_flags |= MIPI_DSI_MODE_LPM; > + > + return brightness; > +} > + > +static const struct backlight_ops ams639rq08_bl_ops = { > + .update_status = ams639rq08_bl_update_status, > + .get_brightness = ams639rq08_bl_get_brightness, > +}; > + > +static struct backlight_device * > +ams639rq08_create_backlight(struct mipi_dsi_device *dsi) > +{ > + struct device *dev = &dsi->dev; > + const struct backlight_properties props = { > + .type = BACKLIGHT_RAW, > + .brightness = 1023, > + .max_brightness = 2047, > + }; > + > + return devm_backlight_device_register(dev, dev_name(dev), dev, dsi, > + &ams639rq08_bl_ops, &props); > +} > + > +static int ams639rq08_probe(struct mipi_dsi_device *dsi) > +{ > + struct device *dev = &dsi->dev; > + struct ams639rq08 *ctx; > + int ret; > + > + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + ctx->supplies[0].supply = "vdd3p3"; > + ctx->supplies[1].supply = "vddio"; > + ctx->supplies[2].supply = "vsn"; > + ctx->supplies[3].supply = "vsp"; > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), > + ctx->supplies); > + if (ret < 0) > + return dev_err_probe(dev, ret, "Failed to get regulators\n"); > + > + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); > + if (IS_ERR(ctx->reset_gpio)) > + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), > + "Failed to get reset-gpios\n"); > + > + ctx->dsi = dsi; > + mipi_dsi_set_drvdata(dsi, ctx); > + > + dsi->lanes = 4; > + dsi->format = MIPI_DSI_FMT_RGB888; > + dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST | > + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM; > + > + drm_panel_init(&ctx->panel, dev, &ams639rq08_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + ctx->panel.prepare_prev_first = true; > + > + ctx->panel.backlight = ams639rq08_create_backlight(dsi); > + if (IS_ERR(ctx->panel.backlight)) > + return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), > + "Failed to create backlight\n"); > + > + drm_panel_add(&ctx->panel); > + > + ret = devm_mipi_dsi_attach(dev, dsi); > + if (ret < 0) { > + drm_panel_remove(&ctx->panel); > + return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); > + } > + > + return 0; > +} > + > +static void ams639rq08_remove(struct mipi_dsi_device *dsi) > +{ > + struct ams639rq08 *ctx = mipi_dsi_get_drvdata(dsi); > + > + drm_panel_remove(&ctx->panel); > +} > + > +static const struct of_device_id ams639rq08_of_match[] = { > + { .compatible = "samsung,ams639rq08" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, ams639rq08_of_match); > + > +static struct mipi_dsi_driver ams639rq08_driver = { > + .probe = ams639rq08_probe, > + .remove = ams639rq08_remove, > + .driver = { > + .name = "panel-samsung-ams639rq08", > + .of_match_table = ams639rq08_of_match, > + }, > +}; > +module_mipi_dsi_driver(ams639rq08_driver); > + > +MODULE_AUTHOR("Danila Tikhonov <danila@jiaxyga.com>"); > +MODULE_DESCRIPTION("DRM driver for SAMSUNG AMS639RQ08 cmd mode dsi panel"); > +MODULE_LICENSE("GPL"); Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-11 7:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-06-09 20:36 [PATCH 0/2] Add Samsung AMS639RQ08 panel support Danila Tikhonov 2024-06-09 20:36 ` [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08 Danila Tikhonov 2024-06-10 8:11 ` Krzysztof Kozlowski 2024-06-09 20:36 ` [PATCH 2/2] drm/panel: Add Samsung AMS639RQ08 panel driver Danila Tikhonov 2024-06-11 7:51 ` neil.armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).