From: Krzysztof Kozlowski <krzk@kernel.org>
To: Taewan Kim <trunixs.kim@samsung.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Byoungtae Cho <bt.cho@samsung.com>
Subject: Re: [PATCH 3/3] arm64: dts: exynosautov920: add watchdog DT node
Date: Mon, 30 Sep 2024 13:37:35 +0200 [thread overview]
Message-ID: <c3d4c5b5-6c94-4f19-9de1-8f124a91475e@kernel.org> (raw)
In-Reply-To: <20240913080325.3676181-4-trunixs.kim@samsung.com>
On 13/09/2024 10:03, Taewan Kim wrote:
> From: Byoungtae Cho <bt.cho@samsung.com>
>
> Adds two watchdog devices for ExynosAutoV920 SoC.
>
> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com>
> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com>
> ---
> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index c1c8566d74f5..de210f8e5599 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -297,6 +297,26 @@ pinctrl_aud: pinctrl@1a460000 {
> compatible = "samsung,exynosautov920-pinctrl";
> reg = <0x1a460000 0x10000>;
> };
> +
> + watchdog_cl0: watchdog@10060000 {
Does not look like placed in correct location. 1a46 > 1006. Please
follow DTS coding style in all your works.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-30 11:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240913080347epcas2p222e2536e026f90bb12c18e640fd05e8e@epcas2p2.samsung.com>
2024-09-13 8:03 ` [PATCH 0/3] support watchdog for exynosautov920 Taewan Kim
[not found] ` <CGME20240913080347epcas2p3f92c8fe85b252f8ac2033261db345837@epcas2p3.samsung.com>
2024-09-13 8:03 ` [PATCH 1/3] dt-bindings: watchdog: Document ExynosAutoV920 watchdog bindings Taewan Kim
2024-09-21 0:30 ` Rob Herring (Arm)
2024-09-30 12:05 ` Krzysztof Kozlowski
[not found] ` <CGME20240913080347epcas2p4b5694797cff88a22fd815a9de989d20b@epcas2p4.samsung.com>
2024-09-13 8:03 ` [PATCH 2/3] watchdog: s3c2410_wdt: add support for exynosautov920 SoC Taewan Kim
2024-09-30 12:04 ` Krzysztof Kozlowski
2024-10-10 7:21 ` 김태완
2024-09-30 14:51 ` Guenter Roeck
2024-09-30 20:14 ` Sam Protsenko
2024-10-10 7:25 ` 김태완
2024-10-10 7:45 ` Alim Akhtar
2024-10-21 3:59 ` 김태완
[not found] ` <CGME20240913080347epcas2p46fd90107fe54b8eab3a031cf2fbd592c@epcas2p4.samsung.com>
2024-09-13 8:03 ` [PATCH 3/3] arm64: dts: exynosautov920: add watchdog DT node Taewan Kim
2024-09-30 11:37 ` Krzysztof Kozlowski [this message]
2024-10-10 7:30 ` 김태완
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3d4c5b5-6c94-4f19-9de1-8f124a91475e@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bt.cho@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=trunixs.kim@samsung.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).