From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wesley Cheng <quic_wcheng@quicinc.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
Alexey Minnekhanov <alexeymin@postmarketos.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 06/14] arm64: dts: qcom: sdm630: Drop RPM bus clocks
Date: Wed, 13 Sep 2023 14:08:53 +0200 [thread overview]
Message-ID: <c3dd5f68-af75-4880-83c2-ca7723561ae9@linaro.org> (raw)
In-Reply-To: <70b2a9d7-1a3e-25da-3d78-7bfa5d3a1e05@linaro.org>
On 13.09.2023 09:13, Krzysztof Kozlowski wrote:
> On 12/09/2023 15:31, Konrad Dybcio wrote:
>> These clocks are now handled from within the icc framework and are
>> no longer registered from within the CCF. Remove them.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
[...]
>> anoc2_smmu: iommu@16c0000 {
>> compatible = "qcom,sdm630-smmu-v2", "qcom,smmu-v2";
>> reg = <0x016c0000 0x40000>;
>> -
>> - assigned-clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
>> - assigned-clock-rates = <1000>;
>> - clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
>> - clock-names = "bus";
>
> This is also against bindings. After your patch #4, such bus clock (or
> other combinations) is still required.
So, we have 4 SMMU instances on this platform:
MMSS (described, iface, mem, mem_iface)
GPU (described, iface-mm, iface-smmu, bus-smmu)
ANOC2 (this one, no clocks after removing rpmcc bus)
LPASS (no clocks)
Should I then create a new entry in the bindings, replicating
what's there for msm8998[1] and dropping the entry with just "bus"
from anyOf?
Konrad
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/iommu/arm,smmu.yaml?h=next-20230913#n272
next prev parent reply other threads:[~2023-09-13 12:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 13:31 [PATCH v2 00/14] Clean up RPM bus clocks remnants Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 01/14] arm64: dts: qcom: msm8916: Drop RPM bus clocks Konrad Dybcio
2023-09-13 7:07 ` Krzysztof Kozlowski
2023-09-13 8:47 ` Konrad Dybcio
2023-09-13 8:53 ` Krzysztof Kozlowski
2023-09-13 10:48 ` Konrad Dybcio
2023-09-13 11:14 ` Krzysztof Kozlowski
2023-09-13 11:14 ` Konrad Dybcio
2024-01-02 10:01 ` Aiqun Yu (Maria)
2023-09-12 13:31 ` [PATCH v2 02/14] arm64: dts: qcom: msm8996: " Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 03/14] arm64: dts: qcom: qcs404: " Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 04/14] dt-bindings: arm-smmu: Fix SDM630 clocks description Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 05/14] dt-bindings: usb: qcom,dwc3: Fix SDM660 clock description Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 06/14] arm64: dts: qcom: sdm630: Drop RPM bus clocks Konrad Dybcio
2023-09-13 7:13 ` Krzysztof Kozlowski
2023-09-13 12:08 ` Konrad Dybcio [this message]
2023-09-14 6:26 ` Krzysztof Kozlowski
2023-09-14 7:41 ` Konrad Dybcio
2024-01-02 21:17 ` Marijn Suijten
2023-09-12 13:31 ` [PATCH v2 07/14] arm64: dts: qcom: msm8939: " Konrad Dybcio
2023-09-13 7:15 ` Krzysztof Kozlowski
2023-09-12 13:31 ` [PATCH v2 08/14] dt-bindings: remoteproc: qcom,adsp: Remove AGGRE2 clock Konrad Dybcio
2023-09-13 7:16 ` Krzysztof Kozlowski
2023-09-12 13:31 ` [PATCH v2 09/14] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Remove PNoC clock Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 10/14] remoteproc: qcom: q6v5-mss: Remove PNoC clock from 8996 MSS Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 11/14] arm64: dts: qcom: msm8998: Remove AGGRE2 clock from SLPI Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 12/14] arm64: dts: qcom: msm8996: " Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 14/14] arm64: dts: qcom: sdm630: Fix USB2 clock-names order Konrad Dybcio
2023-09-13 7:17 ` Krzysztof Kozlowski
2023-09-13 7:19 ` Krzysztof Kozlowski
2023-09-18 11:05 ` [PATCH v2 00/14] Clean up RPM bus clocks remnants Will Deacon
2023-09-20 18:30 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3dd5f68-af75-4880-83c2-ca7723561ae9@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=alexeymin@postmarketos.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).