From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Peter Rosin <peda@axentia.se>, Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: arb-gpio-challange: convert to DT schema
Date: Sat, 22 Jul 2023 11:47:53 +0200 [thread overview]
Message-ID: <c3e3b35a-e399-6739-1b01-e6f701af965c@linaro.org> (raw)
In-Reply-To: <CAD=FV=U1humE-MrCgWmDqSjGZPnzP04-ScGcY7yBETuW-viyHQ@mail.gmail.com>
On 21/07/2023 20:06, Doug Anderson wrote:
> Hi,
>
> On Fri, Jul 21, 2023 at 6:30 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml b/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml
>> new file mode 100644
>> index 000000000000..17f15490f073
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml
>> @@ -0,0 +1,138 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/i2c/i2c-arb-gpio-challenge.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: GPIO-based I2C Arbitration Using a Challenge & Response Mechanism
>> +
>> +maintainers:
>> + - Doug Anderson <dianders@chromium.org>
>> + - Peter Rosin <peda@axentia.se>
>
> While I don't object to Peter Rosin being listed here if he wants it,
> I suspect that you added him because he was the author of
> "i2c-arb.txt". I guess that file was really only added to try to keep
> things common between this GPIO arbitrator and the one that he cares
I added him because he was listed as maintainer of all arbitration
bindings (as part of I2C MUX entry in MAINTAINERS).
> about: "nxp,pca9541.txt". Probably he doesn't want to be added here.
>
> Speaking of "nxp,pca9541.txt", it seems like you need to convert that
> before removing "i2c-arb.txt". It still refers to that file even after
> your patch, doesn't it?
Indeed, thanks. I will convert it.
>
> In any case, other than that, this looks fine. Thanks for doing the conversion!
>
> Acked-by: Douglas Anderson <dianders@chromium.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-22 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:30 [PATCH] dt-bindings: i2c: arb-gpio-challange: convert to DT schema Krzysztof Kozlowski
2023-07-21 18:06 ` Doug Anderson
2023-07-22 9:47 ` Krzysztof Kozlowski [this message]
2023-07-22 9:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3e3b35a-e399-6739-1b01-e6f701af965c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).