From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B17DEC28CBC for ; Wed, 6 May 2020 19:10:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D2882076D for ; Wed, 6 May 2020 19:10:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="c5USd9Si" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbgEFTKg (ORCPT ); Wed, 6 May 2020 15:10:36 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:46766 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbgEFTKf (ORCPT ); Wed, 6 May 2020 15:10:35 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 046JATR1025746; Wed, 6 May 2020 14:10:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1588792229; bh=y91BBsQ57bVF9REySvrUgz895w+ukgRT8Z+er1kUntc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=c5USd9SijAl0GB88Xk18IuhI9Z+ZmZFrqv2RsPq+Psc4dNDeXEXiR5RJYFdflZAVL e+yWnTkj0Rqjjk3Ic2O/f0/yVJVprZAguuDDVkEpIit9QSKUCp1vJddtnU5xbWZsdF uj2xHCnRvHBdbmOXudFt9tR+Wui8Oc/S5xRLWPE8= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 046JATcE086681 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 6 May 2020 14:10:29 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 6 May 2020 14:10:29 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 6 May 2020 14:10:29 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 046JAOLR036216; Wed, 6 May 2020 14:10:25 -0500 Subject: Re: [PATCH net-next 1/7] dt-binding: ti: am65x: document common platform time sync cpts module To: Rob Herring CC: Richard Cochran , Murali Karicheri , "David S. Miller" , Tero Kristo , Lokesh Vutla , netdev , Sekhar Nori , "linux-kernel@vger.kernel.org" , , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Nishanth Menon References: <20200501205011.14899-1-grygorii.strashko@ti.com> <20200501205011.14899-2-grygorii.strashko@ti.com> <20200505040419.GA8509@bogus> From: Grygorii Strashko Message-ID: Date: Wed, 6 May 2020 22:10:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/05/2020 22:07, Rob Herring wrote: > On Tue, May 5, 2020 at 10:01 AM Grygorii Strashko > wrote: >> >> >> >> On 05/05/2020 07:04, Rob Herring wrote: >>> On Fri, May 01, 2020 at 11:50:05PM +0300, Grygorii Strashko wrote: >>>> Document device tree bindings for TI AM654/J721E SoC The Common Platform >>>> Time Sync (CPTS) module. The CPTS module is used to facilitate host control >>>> of time sync operations. Main features of CPTS module are: >>>> - selection of multiple external clock sources >>>> - 64-bit timestamp mode in ns with ppm and nudge adjustment. >>>> - control of time sync events via interrupt or polling >>>> - hardware timestamp of ext. events (HWx_TS_PUSH) >>>> - periodic generator function outputs (TS_GENFx) >>>> - PPS in combination with timesync router >>>> - Depending on integration it enables compliance with the IEEE 1588-2008 >>>> standard for a precision clock synchronization protocol, Ethernet Enhanced >>>> Scheduled Traffic Operations (CPTS_ESTFn) and PCIe Subsystem Precision Time >>>> Measurement (PTM). >>>> >>>> Signed-off-by: Grygorii Strashko >>>> --- >>>> .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 7 + >>>> .../bindings/net/ti,k3-am654-cpts.yaml | 152 ++++++++++++++++++ >>>> 2 files changed, 159 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml >>>> index 78bf511e2892..0f3fde45e200 100644 >>>> --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml >>>> +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml >>>> @@ -144,6 +144,13 @@ patternProperties: >>>> description: >>>> CPSW MDIO bus. >>>> >>>> + "^cpts$": >> >> ok >> >>> >>> Fixed strings go under 'properties'. >>> >>>> + type: object >>>> + allOf: >>>> + - $ref: "ti,am654-cpts.yaml#" >>>> + description: >>>> + CPSW Common Platform Time Sync (CPTS) module. >>>> + >>>> required: >>>> - compatible >>>> - reg >>>> diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml >>>> new file mode 100644 >>>> index 000000000000..1b535d41e5c6 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml >>>> @@ -0,0 +1,152 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/net/ti,am654-cpts.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: The TI AM654x/J721E Common Platform Time Sync (CPTS) module Device Tree Bindings >>>> + >>>> +maintainers: >>>> + - Grygorii Strashko >>>> + - Sekhar Nori >>>> + >>>> +description: |+ >>>> + The TI AM654x/J721E CPTS module is used to facilitate host control of time >>>> + sync operations. >>>> + Main features of CPTS module are >>>> + - selection of multiple external clock sources >>>> + - Software control of time sync events via interrupt or polling >>>> + - 64-bit timestamp mode in ns with PPM and nudge adjustment. >>>> + - hardware timestamp push inputs (HWx_TS_PUSH) >>>> + - timestamp counter compare output (TS_COMP) >>>> + - timestamp counter bit output (TS_SYNC) >>>> + - periodic Generator function outputs (TS_GENFx) >>>> + - Ethernet Enhanced Scheduled Traffic Operations (CPTS_ESTFn) (TSN) >>>> + - external hardware timestamp push inputs (HWx_TS_PUSH) timestamping >>>> + >>>> + Depending on integration it enables compliance with the IEEE 1588-2008 >>>> + standard for a precision clock synchronization protocol, Ethernet Enhanced >>>> + Scheduled Traffic Operations (CPTS_ESTFn) and PCIe Subsystem Precision Time >>>> + Measurement (PTM). >>>> + >>>> + TI AM654x/J721E SoCs has several similar CPTS modules integrated into the >>>> + different parts of the system which could be synchronized with each other >>>> + - Main CPTS >>>> + - MCU CPSW CPTS with IEEE 1588-2008 support >>>> + - PCIe subsystem CPTS for PTM support >>>> + >>>> + Depending on CPTS module integration and when CPTS is integral part of >>>> + another module (MCU CPSW for example) "compatible" and "reg" can >>>> + be omitted - parent module is fully responsible for CPTS enabling and >>>> + configuration. >>> >>> That's fine, but you should still have compatible and reg. >> >> I'll add reg as below. But compatible is an issue, because >> k3-am654-cpsw-nuss call of_platform_populate() to create mdio device. >> But for CPTS I do not want to create device as k3-am654-cpsw-nuss uses direct >> function calls to CPTS. >> >> Will it be correct to switch to of_platform_device_create() instead of >> of_platform_populate()? > > That should be fine I think. Thanks. I've sent follow up patches. -- Best regards, grygorii