From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CD6C433F5 for ; Sat, 23 Apr 2022 10:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234903AbiDWKgE (ORCPT ); Sat, 23 Apr 2022 06:36:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234473AbiDWKgC (ORCPT ); Sat, 23 Apr 2022 06:36:02 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947461D8C04 for ; Sat, 23 Apr 2022 03:32:56 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id k23so20816773ejd.3 for ; Sat, 23 Apr 2022 03:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tsJdL6DJfWiEvwfRIfk97/Nhp/cHKIkCfmyLbxjfN3I=; b=xJC6UTkhkoYanFTTSfhaxHSdEiV/oIP0wsbTBrhXOkIPgQUTqPug4iUH8CQCnWj/GL uKmUB0boeeHlHc+lFTRqU52DV02++d/2gRXjqylTkMywN2d3C8+xKyqk9QE9d7KdeDu1 g7/xfcqCKtwZTaYv3F7Pzi+dyWjRSEAkdVByRPdhYH6G9o5rtBbZup13qb3DkaiOVe4K lx8/aU/2EP9t5w0zUB3i+/cmqxdJmn83RABo0rRjrptdhJPTjGe0jOW0D0nDd18kzr7d 2UpC2O6MxvPRphoF2cwzrXGMXmHPgVNy7VB/O3tU7WPTGUr8CEXJ2xC/mo3Kik2uNtW/ 08+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tsJdL6DJfWiEvwfRIfk97/Nhp/cHKIkCfmyLbxjfN3I=; b=lgS8Rj4M7i/OHz3KN/hTGOWRGe6trCAAAE0bfkiMm25lEuM7iyrf9sdEB13olOOJVe TeYGiBaFGv7JmVfuKmeTVIAm+YX/5XmS90KZ42dU4kUTEVWSNP4Srw1EDneNc+qXaBZt fY50XHow7WXOUHQ0V5ahjMTs0I7/LYVuwKGxolK9VbrIDUGRUc4Rd0PBUM1YjRw1b3a4 CMOtv1UKa/vAH272iF/a06y+QXXyAFGvmwI922WOgQVSSsOuFQlfBgBxN5CcVkCKGQF8 SRz8TCd49HTOfhcGIJLzMGc4bpTNwNAcwmholWUsBsTrCdfrKsJ28mcRrhUoBxf9pVvU agbQ== X-Gm-Message-State: AOAM532zmuZU2CZcxfG0pEAQmybu0pKxR4KOmaNHMIEgCMUNeKcRqMKZ +2sxl1czR+VZGm8choyzE8UXrw== X-Google-Smtp-Source: ABdhPJzw23sr0PxRmACppdsVqcsGW5Xzf11v1G2nenM22VT4mr4skYMBrOi1mXs7vfxYFZbvZTdo1A== X-Received: by 2002:a17:907:1b26:b0:6ef:eaca:d2d8 with SMTP id mp38-20020a1709071b2600b006efeacad2d8mr7970655ejc.604.1650709975211; Sat, 23 Apr 2022 03:32:55 -0700 (PDT) Received: from [192.168.0.234] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id au9-20020a170907092900b006e8985cc68asm1547842ejc.1.2022.04.23.03.32.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Apr 2022 03:32:54 -0700 (PDT) Message-ID: Date: Sat, 23 Apr 2022 12:32:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable on board peripherals Content-Language: en-US To: Vignesh Raghavendra , Nishanth Menon , Tero Kristo , Rob Herring Cc: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Aswath Govindraju , Grygorii Strashko References: <20220422065002.387753-1-vigneshr@ti.com> <20220422065002.387753-3-vigneshr@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20220422065002.387753-3-vigneshr@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/04/2022 08:50, Vignesh Raghavendra wrote: > Add nodes for I2C IO expander, OSPI Flash, Eth PHYs, SD and eMMC that > are present on AM625 SK board. > > Signed-off-by: Vignesh Raghavendra > Reviewed-by: Bryan Brattlof > --- > arch/arm64/boot/dts/ti/k3-am625-sk.dts | 273 +++++++++++++++++++++++++ > 1 file changed, 273 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > index 0de4113ccd5de..5fc35898a1e2e 100644 > --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > @@ -9,6 +9,7 @@ > > #include > #include > +#include > #include "k3-am625.dtsi" > > / { > @@ -17,6 +18,12 @@ / { > > aliases { > serial2 = &main_uart0; > + mmc0 = &sdhci0; > + mmc1 = &sdhci1; > + mmc2 = &sdhci2; > + spi0 = &ospi0; > + ethernet0 = &cpsw_port1; > + ethernet1 = &cpsw_port2; > }; > > chosen { > @@ -87,6 +94,33 @@ vcc_3v3_sys: regulator-2 { > regulator-boot-on; > }; > > + vdd_mmc1: fixed-regulator-sd { Don't encode the type of binding into node name. Node name should be generic, so either regulator-0 or regulator-sd. > + /* TPS22918DBVR */ > + compatible = "regulator-fixed"; > + regulator-name = "vdd_mmc1"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + enable-active-high; > + vin-supply = <&vcc_3v3_sys>; > + gpio = <&exp1 3 GPIO_ACTIVE_HIGH>; > + }; > + > + vdd_sd_dv: gpio-regulator-TLV71033 { The same + do not mix cases, so regulator-1 or regulator-tlv71033 Best regards, Krzysztof