From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 630C2C2BB41 for ; Tue, 16 Aug 2022 09:04:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231906AbiHPJEG (ORCPT ); Tue, 16 Aug 2022 05:04:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231942AbiHPJDS (ORCPT ); Tue, 16 Aug 2022 05:03:18 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E60E4A115 for ; Tue, 16 Aug 2022 00:14:59 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id v10so9765535ljh.9 for ; Tue, 16 Aug 2022 00:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=LbMDJXoS9x8FpYW6Y68J+/9gNIBvbIu8BeEES1UgWL0=; b=Lit+hPTJkMv/nc3d5jswLDaYKakT9vO0wN4wfwHnePRwFwPHCeqsVIMTTJbAM6Mx+G QhXJsYBnl9jtPOPEu9+s9v9F5RQ/Dc5lZEPO1yR3UsPD5jEvB1+ctVH0s5imKLsu51Tg zt0YK0Vqwz3FBmWw1h+HxBYEaKFreVkp0nUDLUmi9Aw0XeXOui6UOc8RxGar7x7GLZPM 1CJ+suebgiU2dpXN6T5rVpJ8aiFLqThTAWuh34P6FPWY6oHBaBDBVBMttb1bp/80pZ95 VZ5d9uYJtlIPVD++6X5wSUPm2HxUW/ySnRSQ82NR8Q8TLH4lq5E4n5CN0wk9O41abqA0 sjjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=LbMDJXoS9x8FpYW6Y68J+/9gNIBvbIu8BeEES1UgWL0=; b=Ya6dEx7h1L9rEHu+QHWWvukb1v0jUWF7fDRBt2FoKVMycne00KRRfKZRwpvRrZBAfY kRhCFfUIHTPELSm5Pt6O61ihGg99ydPmx9cbyMcjB7NDEs6kLTDYdxJbbaQo1Pogir76 D9zfkpXYJ4tPr8DElBqJLeEpAfK7zQj5KQUlPXA+Vt/KPtu36hPHC52ykd4uwcnyGaL/ 3IQ7iQ2pwevnyscOnKUd90n8KNSDIQ5okCvX91Pz8HKoWD12I54z8bWjDs3cMMRgzH/q ER9tuOj4Np0hHauHbmXhQHTegglYnkXof2CRZpR69rUuEy/YbwcCDyiGx+M2tP0kLG6C 96AQ== X-Gm-Message-State: ACgBeo2DHZcJu5VoH0RYVrJBI7WqkuZcIBVXboF5gprhUH5ncL7rYA7+ 0culQsvJAT53J+rBSFc/XKVrLA== X-Google-Smtp-Source: AA6agR7r6LX7onIecIEwrZ1MFUwbK40aVSeFO4I1RAeHNwRERE+rCTKnJJNtq9s/rXjWpnTCNslVEw== X-Received: by 2002:a2e:bf29:0:b0:25f:fbd5:b693 with SMTP id c41-20020a2ebf29000000b0025ffbd5b693mr6292721ljr.372.1660634097606; Tue, 16 Aug 2022 00:14:57 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id z4-20020a056512370400b0048b06f34566sm1299951lfr.76.2022.08.16.00.14.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 00:14:57 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 10:14:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes Content-Language: en-US To: Allen-KH Cheng , Linus Walleij , Rob Herring , Matthias Brugger Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Guodong Liu References: <20220815122503.2768-1-allen-kh.cheng@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220815122503.2768-1-allen-kh.cheng@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/08/2022 15:25, Allen-KH Cheng wrote: > There are 8 GPIO physical address bases in mt8186, corresponding to the > items of 'reg-names' with the pinctrl driver. but the order of New sentences start with capital letter. > 'reg-names' is not correct. The mt8186 pinctrl driver would get the > wrong address, causing the system to restart when regulator initializes > . we ^^^ Something is missing. Sentence looks unfinished, full stop is in new line, next sentence does not start with capital letter. > fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example > in bindings. > > Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document") > Signed-off-by: Allen-KH Cheng > Signed-off-by: Guodong Liu > --- Best regards, Krzysztof