From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nik Bune <n3q5u8@yahoo.com>,
wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@microchip.com
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml
Date: Sat, 16 Sep 2023 22:37:23 +0200 [thread overview]
Message-ID: <c42f1653-caa8-731c-e4ef-2d5fe47adc8c@linaro.org> (raw)
In-Reply-To: <20230916154826.84925-1-n3q5u8@yahoo.com>
On 16/09/2023 17:48, Nik Bune wrote:
> Convert txt file to yaml.
> Add reg to the list of required properties.
> Add mainteiners from ./scripts/get_maintainer.pl output.
>
> Signed-off-by: Nik Bune <n3q5u8@yahoo.com>
> ---
> .../watchdog/atmel,at91rm9200-wdt.yaml | 31 +++++++++++++++++++
> .../watchdog/atmel-at91rm9200-wdt.txt | 9 ------
> 2 files changed, 31 insertions(+), 9 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> new file mode 100644
> index 000000000000..e9706b9c1e6b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> @@ -0,0 +1,31 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
How this copyright appeared here? Why are you adding some 2022
copyrights of someone else?
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/atmel,at91rm9200-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel AT91RM9200 System Timer Watchdog
> +
> +maintainers:
> + - Wim Van Sebroeck <wim@linux-watchdog.org>
> + - Guenter Roeck <linux@roeck-us.net>
> +
Missing ref to watchdog.yaml. Please open existing files and take a look
how it is done.
> +properties:
> + compatible:
> + const: atmel,at91sam9260-wdt
Missing blank line
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
This would not make sense without $ref...
Anyway, you need to also test the DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-16 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230916154826.84925-1-n3q5u8.ref@yahoo.com>
2023-09-16 15:48 ` [PATCH] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml Nik Bune
2023-09-16 16:38 ` Rob Herring
2023-09-16 20:37 ` Krzysztof Kozlowski [this message]
2023-09-17 10:02 ` Conor Dooley
2023-09-16 20:38 ` Krzysztof Kozlowski
2023-09-17 19:35 ` Nik Bune
2023-09-18 17:09 ` Conor Dooley
2023-09-17 19:55 ` Nik Bune
2023-09-18 17:11 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c42f1653-caa8-731c-e4ef-2d5fe47adc8c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=n3q5u8@yahoo.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).