From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5131CC32793 for ; Wed, 18 Jan 2023 09:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbjARJGl (ORCPT ); Wed, 18 Jan 2023 04:06:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbjARJEU (ORCPT ); Wed, 18 Jan 2023 04:04:20 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42DAC166C5 for ; Wed, 18 Jan 2023 00:23:04 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id r2so33082944wrv.7 for ; Wed, 18 Jan 2023 00:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sC4oSthDqU9cf3u2CS4pwyGd5dXVv3IJrMPqW08SHjU=; b=PHK37/6BC93sa2U8vVLffIfZLoLfvLEUdjc5PDUnIWHanPCuBFvmeXTAOktMipPju/ MU3gG/0WYsWu7craUR8r9AFY8IpVJkypg0GfImeoDwL3hHsytzJi1Z2T/rusVjmUVmuH TOyoyatn5wIxzEFPbE4IzyrOApadPH5x2K1fj6ZvvgS0TiF8XZyROf7UL3p4x54xHmfD Tb8TRj9VgeAsQjgOon9jeSOLFfurjByG2hHNeKHrvHskT30x6sAJ9+451BL1PuVJMa+z kCmADvdlrDNL3a5NCbCv7bGv43HKl32uBS++n+tltJ6n/feVL9saJhXnTddedBUQ0Xg5 dngQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sC4oSthDqU9cf3u2CS4pwyGd5dXVv3IJrMPqW08SHjU=; b=rDUC8iLWeqR0XKXWGzdeoLqkV9CA+FHjrZwbG7A+krHSA9C7UN2c3lB/x0OH3JmLIA lKMQrf4aSjNyg1bgqxbSwqy1COn18QPo1jvIP3BZjECXSwi+5To4ELJ48eYeQGSbabVJ guNmnkflfd33kympLuqRx/ZBnqn66Lll8lfbIleWeAbvLJ0AwxkJEkWKeF8zDtQXr3cm XbeCpwvnnP8b6bGyIQmQS3I3iUsF7P2LPzOdz+JcGzLJeBpW+RMxl9IdGA0DE1UD9atN u+bA9det6pveUitynDJdhxXAKLT1el2GfM4HcuJ50JrqUNXT8x0iFNNIfUWqgmH7WpIR HocQ== X-Gm-Message-State: AFqh2kqGtXq+dHY5K84enhi4UE6vspmv+9jILZf9n5+m7Vp8BrAB0Km3 qrfXHXVnYJwFxvPBSBhgDjP+KA== X-Google-Smtp-Source: AMrXdXvOicajt2IQqs1cr0S7TxfA67bKcXWin0mWuNxnzOwgUl0pT6dXcK/3bL8CyUYii8kYqIashQ== X-Received: by 2002:adf:f703:0:b0:2bd:dd96:b06a with SMTP id r3-20020adff703000000b002bddd96b06amr5342051wrp.48.1674030183084; Wed, 18 Jan 2023 00:23:03 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f8-20020a0560001b0800b002423edd7e50sm30440470wrz.32.2023.01.18.00.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 00:22:59 -0800 (PST) Message-ID: Date: Wed, 18 Jan 2023 09:22:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/5] dt-bindings: mfd: Add ADI MAX77541/MAX77540 Content-Language: en-US To: Okan Sahin Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Caleb Connolly , Marcus Folkesson , Ramona Bolboaca , William Breathitt Gray , ChiYuan Huang , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org References: <20230118063822.14521-1-okan.sahin@analog.com> <20230118063822.14521-3-okan.sahin@analog.com> From: Krzysztof Kozlowski In-Reply-To: <20230118063822.14521-3-okan.sahin@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/01/2023 07:38, Okan Sahin wrote: > Add ADI MAX77541/MAX77540 devicetree document. > > Signed-off-by: Okan Sahin > --- > .../devicetree/bindings/mfd/adi,max77541.yaml | 87 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77541.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/adi,max77541.yaml b/Documentation/devicetree/bindings/mfd/adi,max77541.yaml > new file mode 100644 > index 000000000000..91d15e9ca2e3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/adi,max77541.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/adi,max77541.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX77540/MAX77541 PMIC from ADI > + > +maintainers: > + - Okan Sahin > + > +description: | > + MAX77540 is a Power Management IC with 2 buck regulators. > + > + MAX77541 is a Power Management IC with 2 buck regulators and 1 ADC. > + > +properties: > + compatible: > + enum: > + - adi,max77540 > + - adi,max77541 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + regulators: > + $ref: /schemas/regulator/adi,max77541-regulator.yaml# No improvements regarding bisectability - this patch fails. If you tested this patch, you would see it. Instead of ignoring comments, either implement them or ask for clarification. > + > +required: > + - compatible > + - reg > + - interrupts > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: adi,max77540 > + then: > + properties: > + regulator: You do not have 'regulator' property. > + properties: > + compatible: > + const: adi,max77540-regulator > + else: > + properties: > + regulator: Same problem. > + properties: > + compatible: > + const: adi,max77541-regulator > + > +additionalProperties: false > + Best regards, Krzysztof