From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D994AC433EF for ; Sat, 9 Apr 2022 16:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242575AbiDIQ1g (ORCPT ); Sat, 9 Apr 2022 12:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235822AbiDIQ1f (ORCPT ); Sat, 9 Apr 2022 12:27:35 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 077263669C for ; Sat, 9 Apr 2022 09:25:27 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id bg10so22915726ejb.4 for ; Sat, 09 Apr 2022 09:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/i5bq1sUVPZ8voo09f+RmZlGXIR3LOWZJkP8vxfCkxs=; b=iaRy2XeK3H+BL8S9B//6ecqylfMzpD67Z/6z7Px+5S8xwp99ZQj+I0iUV8Qp2cHoX/ hn6b3sszVAot6c0WwbJsjnonJafv5VuJdOXIByL5GlOjfdcUk2YSRVw7pwLPyCP3DKeJ QDTt3L/DviaQUOex7ayqIgeSMsKga1sLwxs2AxQ69/BLPZ5fi6tK4owZieCOtY9fK+PF crU19/rgPa772FI+aPzd1nMtYNEcpEfUMN/AREKFbyPexpHZ0xhJuw7y9V23mIGamvkG bcbq/bOgssl8If7jxqGpb2FGmaQCLyz4G37IyZJ//9VqlPAALkLjvqUA4+jYOjTNwn20 GxJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/i5bq1sUVPZ8voo09f+RmZlGXIR3LOWZJkP8vxfCkxs=; b=NwMNLjSDBlGMj1hLBX8D3/qG3quuDGQ5OMbY10lU/KQT+y6fCDNd3rum1sw0iNgn1l i5w2gMY8CTy0awjKbFlJR9dVik1mSKa2w18EiVKNE/esWcXCyONz+erstjQSTl14ro8y Z8oFA/TF8BigZGrO1EtArpl8KPE3N+/5SMcEuIe7FvrdIcA/FMi3oNpC0XIvDQu7Im0n 1r+a+gPit+tMDJ6Aslh9GNgExHN3dOdTsbPgyWjwMvCPXJL1XBV3XbvLxAUrrTrHP376 ThG7GchabKqRnmXrZHnWdMXbvRmyZpWcEkZpKHxMmCEFPercR+eb3FmhMf7icZN7/hQY ykog== X-Gm-Message-State: AOAM530ujZjQUPn3qcKcvLN+yfnzIFMfw6QvYMxotjpn/2EF2Ysti/IQ XBhuRnWeTH2y96Bo6qhhJCQPFQ== X-Google-Smtp-Source: ABdhPJwhD1sGm0VjzGzH83FGU3qxCXO1Djq6Bsftw/zRBN6NcwxjyHtdhSbxTa6JQ2P/xdODB18Mgw== X-Received: by 2002:a17:906:9c82:b0:6e1:2c94:1616 with SMTP id fj2-20020a1709069c8200b006e12c941616mr23085476ejc.64.1649521525607; Sat, 09 Apr 2022 09:25:25 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id yy18-20020a170906dc1200b006d6e5c75029sm9807666ejb.187.2022.04.09.09.25.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Apr 2022 09:25:25 -0700 (PDT) Message-ID: Date: Sat, 9 Apr 2022 18:25:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle bindings Content-Language: en-US To: Drew Fustini , Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Santosh Shilimkar , Dave Gerlach , Tony Lindgren Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220409045145.2434096-1-dfustini@baylibre.com> <20220409045145.2434096-2-dfustini@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220409045145.2434096-2-dfustini@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/04/2022 06:51, Drew Fustini wrote: > Document the Wakeup M3 IPC properties that can be used to toggle the VTT > regulator during low power mode transitions. > (...) > @@ -51,6 +61,15 @@ properties: > mbox_wkupm3 child node. > maxItems: 1 > > + ti,needs-vtt-toggle: > + type: boolean > + description: boards requires VTT toggling during suspend/resume > + > + ti,vtt-gpio-pin: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: pin on the GPIO0 module used for VTT toggle > + maxItems: 1 No need for maxItems, it's a single uint32. You could add "maximum" if you know the constraints for the value. Do you actually need two properties (bool + pin)? A case of "ti,vtt-gpio-pin" without the "ti,needs-vtt-toggle" is valid? The other way looks wrong, so you need to add a dependency (see example-schema). Best regards, Krzysztof