From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB8CC4332F for ; Mon, 12 Dec 2022 03:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbiLLDTp (ORCPT ); Sun, 11 Dec 2022 22:19:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbiLLDTo (ORCPT ); Sun, 11 Dec 2022 22:19:44 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B253BBCB7; Sun, 11 Dec 2022 19:19:42 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id C95EF24E115; Mon, 12 Dec 2022 11:19:40 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 12 Dec 2022 11:19:40 +0800 Received: from [192.168.125.96] (113.72.147.126) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 12 Dec 2022 11:19:40 +0800 Message-ID: Date: Mon, 12 Dec 2022 11:19:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RESEND PATCH v2 1/3] dt-bindings: power: Add starfive,jh71xx-pmu Content-Language: en-US To: Krzysztof Kozlowski , , , CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , "Rafael J . Wysocki" , References: <20221208084523.9733-1-walker.chen@starfivetech.com> <20221208084523.9733-2-walker.chen@starfivetech.com> From: Walker Chen In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.147.126] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022/12/8 17:03, Krzysztof Kozlowski wrote: > On 08/12/2022 09:45, Walker Chen wrote: >> Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. >> >> Signed-off-by: Walker Chen > > > >> + }; >> diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h >> new file mode 100644 >> index 000000000000..73c6a79a2181 >> --- /dev/null >> +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h >> @@ -0,0 +1,17 @@ >> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > > Why different license than the bindings? MIT is pretty compatible, but > if it does not matter for you, keep same licenses as bindings. MIT should be the least restrictive license. But it seems that BSD is more used and more safe. So both of them will be used same licenses in next version. Thanks. > >> +/* >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> + * Author: Walker Chen >> + */ >> +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ >> +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ >> + >> +#define JH7110_PD_SYSTOP 0 >> +#define JH7110_PD_CPU 1 >> +#define JH7110_PD_GPUA 2 >> +#define JH7110_PD_VDEC 3 >> +#define JH7110_PD_VOUT 4 >> +#define JH7110_PD_ISP 5 >> +#define JH7110_PD_VENC 6 >> + >> +#endif > > Best regards, > Krzysztof >