From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nicholas Roth <nicholas@rothemail.net>
Cc: devicetree@vger.kernel.org, mchehab@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding
Date: Thu, 10 Nov 2022 09:48:27 +0100 [thread overview]
Message-ID: <c4669d31-ffee-e83c-4a45-370b1cc27910@linaro.org> (raw)
In-Reply-To: <CAD2rFCqrJyTz1KXXK3WTiih7LTfAW07k8V19yQhA6_LeGiqfRg@mail.gmail.com>
On 09/11/2022 17:26, Nicholas Roth wrote:
> Happy to reply inline next time. I'm still getting used to this format
> :-). Here's the context around my clock frequency question-- I'd
> really like to understand this better:
>
>>> + clock-names:
>>> + description:
>>> + Input clock for the sensor.
>>> + items:
>>> + - const: xvclk
>>> +
>>> + clock-frequency:
>>> + description:
>>> + Frequency of the xvclk clock in Hertz.
>>
>> The frequency of clock should go via common clock framework - you have
>> get_rate and set_rate. Drop entire property.
>
> I am trying to be consistent with the ov8856 driver and bindings but
> would be happy to change. I’m not familiar with that framework though.
> Is there somewhere I could read about this, including the driver and
> device-tree changes I need to use this?
git grep clk_get_rate -- drivers/media/i2c/
For example imx219 or imx334.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-10 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 2:31 ov8858 device tree addition Nicholas Roth
2022-11-09 2:31 ` [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding Nicholas Roth
2022-11-09 8:26 ` Krzysztof Kozlowski
2022-11-09 15:48 ` Nicholas Roth
2022-11-09 15:51 ` Nicholas Roth
[not found] ` <6F5319F3-FDB2-405C-99E1-A9EC64264FD6@rothemail.net>
2022-11-09 16:19 ` Krzysztof Kozlowski
2022-11-09 16:26 ` Nicholas Roth
2022-11-10 8:48 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4669d31-ffee-e83c-4a45-370b1cc27910@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=mchehab@kernel.org \
--cc=nicholas@rothemail.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).