From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F382CC433FE for ; Thu, 10 Nov 2022 08:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiKJIse (ORCPT ); Thu, 10 Nov 2022 03:48:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiKJIsd (ORCPT ); Thu, 10 Nov 2022 03:48:33 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28D6B635D for ; Thu, 10 Nov 2022 00:48:31 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id j4so1973357lfk.0 for ; Thu, 10 Nov 2022 00:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5QyraTCqY2v4zpONouCATF0EjehSKbaWOJmoVi/2g60=; b=TM/aC2jyokp5p1KPCYT6j/2Xmsqlpgv/QWPNF7P2RUdnxHczCCmhdrX/YikQVNix8N aqaF2TGqGIUuu9DJqge3QrtXobzg+rLlS62TF5VM4xZJxNqFmzHzHMC0ztwb2GRHM4Lh qyCuj6B16hBD9tRyq3Wl0eEOlG6Am2QRGv9tK5x1MaORV90wCBvrr14DI2XzZVNA3U+f ah//CnHoW1tiU/ACC8zfLC0zmoI3osSYv2h6UsaUjgQytiNFoO5xDE3kSsVp7yGhk3an TvUNxAN/MluxbMRalVGkLSmOnZqPFxsCBgFXUXsf3VIf7X+GNpYI23E1l3Kw96eXlxvx dzxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5QyraTCqY2v4zpONouCATF0EjehSKbaWOJmoVi/2g60=; b=l9679xQVEmr/U3Sjma3JOYkI4Uhwav9mXZsbaWU2tLDFNik0sW/E75Pw2GkL15D32M n+5UnpcCQKsekavuv5e+8w/4a54mrg0x0lt9h0Te+pjec1dODI1wZBZWs+5Y5e9VuP04 azx3cPWXWvEOr6niFvCYV32ixtZbs2a4Cp7H0rkJOJKaa6TCjM2slapmYo5EzeowoCBC 7V4Itvvu7lGleR9Ie1LAvCKFIlxjGtDSRixS+Xa87zr01yzHENczQZZunGO0RSCF1JUr m9w32QHebdYJg1xV/CNo78IHEuzSjzTR6LOu1S6PeB97E/BQmTqvvzhVHviLngrdAFWi 4l2Q== X-Gm-Message-State: ACrzQf3DJs8rKma6OyzaL1oS1iXPn2PB4qICqlrdqnks8k7D0cKSmZcX +M83tPoPEYbyVtHS/l+G3TwQQw== X-Google-Smtp-Source: AMsMyM5er8LudEMVrk6YDBDfvcRGHz83JCfTmvqNGE3bgCuwJz86XRf+f0HPwBeItGGUO6z7T5e6nQ== X-Received: by 2002:ac2:5c4e:0:b0:4ab:db5d:10ee with SMTP id s14-20020ac25c4e000000b004abdb5d10eemr21011612lfp.142.1668070109043; Thu, 10 Nov 2022 00:48:29 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id f30-20020a05651c02de00b00278a21bb7b9sm2248072ljo.100.2022.11.10.00.48.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 00:48:28 -0800 (PST) Message-ID: Date: Thu, 10 Nov 2022 09:48:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding Content-Language: en-US To: Nicholas Roth Cc: devicetree@vger.kernel.org, mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <6F5319F3-FDB2-405C-99E1-A9EC64264FD6@rothemail.net> <24ecc077-fc1d-5270-c901-9722ab7b68b1@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/11/2022 17:26, Nicholas Roth wrote: > Happy to reply inline next time. I'm still getting used to this format > :-). Here's the context around my clock frequency question-- I'd > really like to understand this better: > >>> + clock-names: >>> + description: >>> + Input clock for the sensor. >>> + items: >>> + - const: xvclk >>> + >>> + clock-frequency: >>> + description: >>> + Frequency of the xvclk clock in Hertz. >> >> The frequency of clock should go via common clock framework - you have >> get_rate and set_rate. Drop entire property. > > I am trying to be consistent with the ov8856 driver and bindings but > would be happy to change. I’m not familiar with that framework though. > Is there somewhere I could read about this, including the driver and > device-tree changes I need to use this? git grep clk_get_rate -- drivers/media/i2c/ For example imx219 or imx334. Best regards, Krzysztof