From: Florian Fainelli <f.fainelli@gmail.com>
To: Phil Elwell <phil@raspberrypi.org>,
Rob Herring <robh+dt@kernel.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 1/4] staging/vc04_services: Use correct cache line size
Date: Fri, 14 Sep 2018 10:03:53 -0700 [thread overview]
Message-ID: <c4807226-6738-d9da-6f08-4b0a782b9cae@gmail.com> (raw)
In-Reply-To: <1536931375-48769-2-git-send-email-phil@raspberrypi.org>
On 09/14/2018 06:22 AM, Phil Elwell wrote:
> Use the compatible string in the DTB to select the correct cache line
> size for the SoC - 32 for BCM2835, and 64 for BCM2836 and BCM2837.
>
> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
> ---
[snip]
> @@ -170,6 +170,14 @@ static struct device *vchiq_dev;
> static DEFINE_SPINLOCK(msg_queue_spinlock);
> static struct platform_device *bcm2835_camera;
>
> +static struct vchiq_drvdata bcm2835_drvdata = {
> + .cache_line_size = 32,
> +};
> +
> +static struct vchiq_drvdata bcm2836_drvdata = {
> + .cache_line_size = 64,
> +};
Those two structures could probably be marked const. Other than that,
the approach definitively looks good to me.
--
Florian
next prev parent reply other threads:[~2018-09-14 17:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 13:22 [PATCH v2 0/4] Improve VCHIQ cache line size handling Phil Elwell
2018-09-14 13:22 ` [PATCH v2 1/4] staging/vc04_services: Use correct cache line size Phil Elwell
2018-09-14 15:22 ` Phil Elwell
2018-09-14 16:46 ` Stefan Wahren
2018-09-14 17:03 ` Florian Fainelli [this message]
2018-09-14 18:12 ` Phil Elwell
2018-09-14 18:20 ` Florian Fainelli
2018-09-14 13:22 ` [PATCH v2 2/4] dt-bindings: soc: Document "brcm,bcm2836-vchiq" Phil Elwell
2018-09-14 13:22 ` [PATCH v2 3/4] ARM: dts: bcm283x: Correct vchiq compatible string Phil Elwell
2018-09-14 13:22 ` [PATCH v2 4/4] ARM: dts: bcm283x: Correct mailbox register sizes Phil Elwell
2018-09-14 17:01 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4807226-6738-d9da-6f08-4b0a782b9cae@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=phil@raspberrypi.org \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).