From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083C4EB64DD for ; Wed, 21 Jun 2023 08:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230454AbjFUIq1 (ORCPT ); Wed, 21 Jun 2023 04:46:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231620AbjFUIqZ (ORCPT ); Wed, 21 Jun 2023 04:46:25 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6D6110E6 for ; Wed, 21 Jun 2023 01:46:23 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9896216338cso114026166b.3 for ; Wed, 21 Jun 2023 01:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687337182; x=1689929182; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GflvE0roPSdSbGvWDUkng37TEfI0UgvNgk9OrUiAXgg=; b=IcHaWSJyViXSUhu1kU4YbjkKQo3cyhjXO5TxFn0/x7bspgST9bG6wmFihhp5GiFDqy zU2zIg6geWOCZTVRuKjUYZmL7nIBDA99twkxsf75TNvnRNeaVKxkGAkzde5k0oUP8gjf VFjjWkeCnqYI4Lbit6xZLnpsqHoiGSyvsLCxdYN8OlFn5f3zdTI+tp6WdhPHh8ep15Om xxid5A/zoJJN0gaBlQ4oC8fmSwBK57dT0lK2wN1+gi6SYueIIakDyzrH5ts525fUpkab W+M40bpnB/9Yf7oVfi8WWAw3/4h04UMIZCl+pq+nj/AvqmX+8Q6d6L/RD0FiyGi0qfqo bWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687337182; x=1689929182; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GflvE0roPSdSbGvWDUkng37TEfI0UgvNgk9OrUiAXgg=; b=Ueg5apqh0gKBFWShqCaLLPi/UGlAHqQM6edkW0uiVpjz8XCzaML1AUgGkS/Cl3N+Cw FcWNnNrr0QnkWuedrrcTnh6ne9pEtxM8sPR5QSx/qLKBhUSxPLXY4ha7+nM/5ZrjYdYy LXs8aK1CAB2O0t2fkU1+ZWPRRi07KFqdLdsk/2Uax7G8sNwa2YD7+8SVZoJ8slAw67W1 1BrLbnBe+vWKJjFTAW51jD7oiEUjzgyGZmCh7VTdhk8LNeUVoZ3cJ77xLHecxoGDPpnF 4oTLc1uWDvuP5D3pNLs522Wn9KzW/R98dbQXEvYDUseYhJgi6OQ05ZQiRT4FtoRaMJG3 lOxQ== X-Gm-Message-State: AC+VfDxtJIxhD8MqYfrYd8mWfFlI7CYnAQ/T5GytPFUE9fo52xLY+YIm mTva2jpqwdThnaNODN6E/CVOvw== X-Google-Smtp-Source: ACHHUZ75Ib9mgET+SuFnggOlzImf1yD7bISLiyp7cqP7i+51zkAOt08tWIrxe5qkk/VpAcGrKE4n+Q== X-Received: by 2002:a17:907:1c07:b0:982:84c9:96bd with SMTP id nc7-20020a1709071c0700b0098284c996bdmr15416351ejc.76.1687337182265; Wed, 21 Jun 2023 01:46:22 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id la18-20020a170906ad9200b009888f0bbd38sm2702486ejb.169.2023.06.21.01.46.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 01:46:21 -0700 (PDT) Message-ID: Date: Wed, 21 Jun 2023 10:46:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 03/18] dt-bindings: soc: qcom: qcom,saw2: define optional regulator node Content-Language: en-US To: Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Ilia Lin , Viresh Kumar , Nishanth Menon , Stephen Boyd , Michael Turquette , "Rafael J. Wysocki" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, Christian Marangi References: <20230612053922.3284394-1-dmitry.baryshkov@linaro.org> <20230612053922.3284394-4-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/06/2023 00:49, Dmitry Baryshkov wrote: > On 14/06/2023 19:05, Krzysztof Kozlowski wrote: >> On 12/06/2023 07:39, Dmitry Baryshkov wrote: >>> The SAW2 device can optionally provide a voltage regulator supplying the >>> CPU core, cluster or L2 cache. Describe it in the device bindings. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> .../devicetree/bindings/soc/qcom/qcom,saw2.yaml | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,saw2.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,saw2.yaml >>> index a016242367b9..b809a9cc0916 100644 >>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,saw2.yaml >>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,saw2.yaml >>> @@ -47,6 +47,10 @@ properties: >>> - description: Base address and size of the alias register region >>> minItems: 1 >>> >>> + regulator: >>> + $ref: /schemas/regulator/regulator.yaml# >> >> There was such property in the binding (and DTS!) but a bool. Previous >> patch silently dropped it, so re-introducing it with different type is >> confusing. > > Could you please propose a better name here? saw-regulator? Or maybe > regulator-saw? (as we might get regulator-avs at some point). regulator name is OK for me, but any ABI change should be: 1. Clearly expressed with rationale, 2. Done probably in one DT commit, not two. IOW, first silently dropping a property and then adding a new one like nothing happened is not good. It should be clear that old property is wrong because foo bar and we make it now different with breaking all the DTS because foo bar. Best regards, Krzysztof