From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, andersson@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
luca.weiss@fairphone.com, lujianhua000@gmail.com,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Cc: konrad.dybcio@linaro.org, caleb.connolly@linaro.org,
subbaram@quicinc.com, jackp@quicinc.com,
robertom@qti.qualcomm.com
Subject: Re: [PATCH v8 00/11] Add Qualcomm PMIC TPCM support
Date: Sun, 9 Jul 2023 02:49:20 +0300 [thread overview]
Message-ID: <c48c5f9b-eb6d-3f44-0128-d6ac35110add@linaro.org> (raw)
In-Reply-To: <20230515133643.3621656-1-bryan.odonoghue@linaro.org>
On 15/05/2023 16:36, Bryan O'Donoghue wrote:
> Bootable tree
> Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/usb-next-23-05-14-qcom-wrapper-typec-mux-bjorn
>
> V8:
> - Makes pm8150b_typec::status = disabled by default - bod
> - Greg merged the TCPM description and driver to usb-next so two patches less now.
> I've rebased this series on to usb-next using "--base=auto"
> All of the kernel robot dts/yaml checks should now pass against usb-next / a4422ff221429c600c3dc5d0394fb3738b89d040
>
> V7:
> - Adds R/B to "dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add input and output ports" - Krzysztof
> - Fixes indicated, adds R/B to "dt-bindings: usb: Add Qualcomm PMIC Type-C" - Krzysztof
> - Fixes indicated, adds R/B to "usb: typec: qcom: Add Qualcomm PMIC Type-C driver" - Guenter
> - Fixes indicated, adds R/B to "usb: typec: qcom: Add Qualcomm PMIC Type-C driver" - Caleb
> - Adds R/B to "arm64: dts: qcom: sm8250: Define ports for qmpphy orientation-switching" - Konrad
> - Adds R/B to "arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost" - Konrad
> - Fixes indicated, adds R/B to "arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM" - Jianhua, Konrad
> - Connector ports/endpoints left inside of connector
> Documentation/devicetree/bindings/connector/usb-connector.yaml - Jianhua
> - dwc3_role_switch_in -> usb_1_dwc3_role_switch_in
> qmpphy_typec_mux_in -> usb_1_qmpphy_typec_mux_in
> Both ports/endpoints defined inside of pm8150b dtsi - Konrad
>
> I modified the name of both so that the port/endpoint would be directly
> adjacent to the containing node in the dtsi file for code locality/readbility - bod
>
> - Fixes newline indicated "arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1" - Jianhua, Konrad
> - Fixes newline indicated "arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy" - Jianhua, Konrad
>
> - connector
> I have left the connector defintion and its ports/endpoints in the platform dts
>
> The reason for this
> a) Prior art e.g. arch/arm64/boot/dts/qcom/sc8280xp*
> b) The connector is really a non-SoC/PMIC component its something that is defined
> for your platform.
>
> I'm open to further debate on this topic:
> Link: https://imgflip.com/i/7kw6ck
>
> - port@1 -> port@1 "arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy" - Jianhua
>
> - OF: graph: no port node found in /soc@0/spmi@c440000/pmic@2/typec@1500
>
> I left this as-is since the DT model we want is to connect the connector directly to
> the PHY for orientation or controller for data-role switching
>
> I similarly didn't put this hack in place to remove the warning but "it would work"
>
> V6:
> - I'm dropping the previous V1-V6 log because the text is getting too long
> here's a link to the previous cover letter instead
> Link: https://lore.kernel.org/linux-arm-msm/20230501121111.1058190-1-bryan.odonoghue@linaro.org/
>
>
> Bryan O'Donoghue (11):
> dt-bindings: regulator: qcom,usb-vbus-regulator: Mark reg as required
> dt-bindings: regulator: qcom,usb-vbus-regulator: Mark
> regulator-*-microamp required
> dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add orientation-switch
> as optional
> dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add input and output
> ports
> dt-bindings: mfd: qcom,spmi-pmic: Add typec to SPMI device types
> arm64: dts: qcom: sm8250: Define ports for qmpphy
> orientation-switching
> arm64: dts: qcom: pm8150b: Add a TCPM description
> arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost
> arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM
> arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for
> usb_1
> arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for
> usb_1_qmpphy
>
> .../bindings/mfd/qcom,spmi-pmic.yaml | 4 ++
> .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 44 +++++++++++++++
> .../regulator/qcom,usb-vbus-regulator.yaml | 10 +++-
> arch/arm64/boot/dts/qcom/pm8150b.dtsi | 40 +++++++++++++
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 56 ++++++++++++++++++-
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 18 ++++++
> 6 files changed, 170 insertions(+), 2 deletions(-)
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
prev parent reply other threads:[~2023-07-08 23:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 13:36 [PATCH v8 00/11] Add Qualcomm PMIC TPCM support Bryan O'Donoghue
2023-05-15 13:36 ` [PATCH v8 01/11] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark reg as required Bryan O'Donoghue
2023-05-15 13:36 ` [PATCH v8 02/11] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark regulator-*-microamp required Bryan O'Donoghue
2023-05-15 13:36 ` [PATCH v8 03/11] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add orientation-switch as optional Bryan O'Donoghue
2023-05-15 13:36 ` [PATCH v8 04/11] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add input and output ports Bryan O'Donoghue
2023-05-15 19:59 ` Bjorn Andersson
2023-05-16 10:15 ` Bryan O'Donoghue
2023-07-18 6:09 ` Dmitry Baryshkov
2023-05-15 13:36 ` [PATCH v8 05/11] dt-bindings: mfd: qcom,spmi-pmic: Add typec to SPMI device types Bryan O'Donoghue
2023-05-15 13:36 ` [PATCH v8 06/11] arm64: dts: qcom: sm8250: Define ports for qmpphy orientation-switching Bryan O'Donoghue
2023-05-15 13:36 ` [PATCH v8 07/11] arm64: dts: qcom: pm8150b: Add a TCPM description Bryan O'Donoghue
2023-05-18 10:01 ` Konrad Dybcio
2023-05-15 13:36 ` [PATCH v8 08/11] arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost Bryan O'Donoghue
2023-07-09 0:17 ` Dmitry Baryshkov
2023-05-15 13:36 ` [PATCH v8 09/11] arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM Bryan O'Donoghue
2023-05-15 13:36 ` [PATCH v8 10/11] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Bryan O'Donoghue
2023-07-08 23:48 ` Dmitry Baryshkov
2023-05-15 13:36 ` [PATCH v8 11/11] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy Bryan O'Donoghue
2023-07-08 23:48 ` Dmitry Baryshkov
2023-07-08 23:49 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c48c5f9b-eb6d-3f44-0128-d6ac35110add@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luca.weiss@fairphone.com \
--cc=lujianhua000@gmail.com \
--cc=robertom@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=subbaram@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).