From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A3AC77B7F for ; Fri, 19 May 2023 12:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230135AbjESMkK (ORCPT ); Fri, 19 May 2023 08:40:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbjESMkJ (ORCPT ); Fri, 19 May 2023 08:40:09 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 59EB2106; Fri, 19 May 2023 05:40:08 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E83171FB; Fri, 19 May 2023 05:40:52 -0700 (PDT) Received: from [10.57.73.119] (unknown [10.57.73.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 990F13F762; Fri, 19 May 2023 05:40:05 -0700 (PDT) Message-ID: Date: Fri, 19 May 2023 13:40:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH V3 6/6] coresight: platform: acpi: Ignore the absence of graph To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org Cc: Ganapatrao Kulkarni , Steve Clevenger , Rob Herring , Frank Rowand , Russell King , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Sudeep Holla , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org References: <20230519052149.1367814-1-anshuman.khandual@arm.com> <20230519052149.1367814-7-anshuman.khandual@arm.com> From: Suzuki K Poulose In-Reply-To: <20230519052149.1367814-7-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/05/2023 06:21, Anshuman Khandual wrote: > From: Suzuki K Poulose > > Some components may not have graph connections for describing > the trace path. e.g., ETE, where it could directly use the per > CPU TRBE. Ignore the absence of graph connections > > Signed-off-by: Suzuki K Poulose > Signed-off-by: Anshuman Khandual Please could you move this before the Patch 5, where we add ACPI support for etm4x with system instructions ? That way the support is up with that patch, without an error that is fixed by this patch. Suzuki > --- > drivers/hwtracing/coresight/coresight-platform.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index 475899714104..c4b4fbde8550 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -692,8 +692,12 @@ static int acpi_coresight_parse_graph(struct acpi_device *adev, > > pdata->nr_inport = pdata->nr_outport = 0; > graph = acpi_get_coresight_graph(adev); > + /* > + * There are no graph connections, which is fine for some components. > + * e.g., ETE > + */ > if (!graph) > - return -ENOENT; > + return 0; > > nlinks = graph->package.elements[2].integer.value; > if (!nlinks)