Re: [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0/3.0 PHY

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 01/06/2023 12:49, Stanley Chang[昌育德] wrote:
> Hi Krzysztof,
> 
>> Thank you for your patch. There is something to discuss/improve.
>>
>> Actually a lot... The bindings are not suitable for review.
> 
> Thanks for your patience in reviewing my patches.
> 
> Most of the properties are about the phy parameters.
> Is the phy parameter data suitable to be placed in DTS?
> I referenced other phy drivers. 
> These parameters should not be defined in dts.
> I would move the parameters to the driver.

If these can be in the driver, why would ever they be in DTS in the
first place?

> 
>>> +  realtek,usb:
>>> +    description: The phandler of realtek dwc3 node
>>
>> "phandler"? Except obvious typo, drop "The phandler of" and describe what is
>> it for.
> 
> realtek,usb is a phandle of syscon used to control realtek dwc3 register.

Then no, phy should not control dwc3.

> 
>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>
>> Anyway, it shouldn't be here. No, no.
> 
> Can I use it for phandle of syscon?

PHY getting phandle to block using this PHY? Looks wrong. Why would PHY
need to poke IP block register?


Best regards,
Krzysztof