From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9573CC77B7E for ; Thu, 1 Jun 2023 15:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234677AbjFAPc5 (ORCPT ); Thu, 1 Jun 2023 11:32:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233776AbjFAPc4 (ORCPT ); Thu, 1 Jun 2023 11:32:56 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C38ADB3 for ; Thu, 1 Jun 2023 08:32:53 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5148f299105so2287536a12.1 for ; Thu, 01 Jun 2023 08:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685633572; x=1688225572; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d+hD8sanORaWT0+7h4FlSb8jJyfN127ZPZqGdgRFUik=; b=ElKVSOFj2eQz/HLNwoODWxWCWoi2Kx/s1W/rVvvxdLHDkzhxpGLwE89chXLB0Mnq5q 25EkWgrR7i96Rbz+knEOs6rDhevaooR2wnXmShLYc0TtwXW0IGH9npeIYsuUkXM/eHx1 ZuSPtyUAl4O8d7ayCPJqGiSKRW44M+xAk0JCdFG8x09GTqkvjvIHK5Z303ohDAIRQ7jP tdZGtiEgqRhhOHYSlYqxuv1bQEOz0ZozvnJcjRyhKEoA0C2dqXxzJWabeMMDhPP4Fs89 qsA0JBbna14pQ78O/ir++cbTJWSptZ8LzT4qVMMHmKW2DnOYq2ajzzg6eWAyn3gDhY0O NWFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685633572; x=1688225572; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d+hD8sanORaWT0+7h4FlSb8jJyfN127ZPZqGdgRFUik=; b=Lm2x9+g2sLhOP8jTskIDwgwQQuljEee4yrBt830HHkrWkRKRZoG5a38FXYXdEoQ399 Ub8ndik74cpEzb7oXN7hRySUOpO5DxKSNcYC5pzSbeOR4vbS5LB0mPYpnAzKtw31EAK+ Xosr42acKKzxOxmgAEfdhkTJP6FEVJ6lMfz12himCSYEvkO9ZJRTb7Iel52leGgbRaIe UPbtHbIpkHiMHn0Zqb3s5P66YdOZMPgDBPa1+BD1mPadIm5Tsa5j6uUoQkW6AZid7nVL SVNSXGKepcG5eAPtu2rfHk5WNDGzpSw3MyJFApzJdOdJIduFNdr2CJTJbSyrFgqBTZ3J V6QA== X-Gm-Message-State: AC+VfDzl/fkyLPM04FqIC+gno0zG60rRBsLMo5MMHkQJ7WNBoQzam7wW rGQAwb2ajkAwrPPSEA4SSapGhwtv5+sHjsnrZnk= X-Google-Smtp-Source: ACHHUZ7a+j5H+4n877373TAsr1A1hwAPC3YrdKs+go0xqZQRXTvLCs8FQzyxfAYg3gC+80JnFGDtfA== X-Received: by 2002:aa7:ca4f:0:b0:514:a016:9cd1 with SMTP id j15-20020aa7ca4f000000b00514a0169cd1mr140984edt.8.1685633572310; Thu, 01 Jun 2023 08:32:52 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id y2-20020a50eb02000000b0050488d1d376sm7361686edp.0.2023.06.01.08.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 08:32:51 -0700 (PDT) Message-ID: Date: Thu, 1 Jun 2023 17:32:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0/3.0 PHY Content-Language: en-US To: =?UTF-8?B?U3RhbmxleSBDaGFuZ1vmmIzogrLlvrdd?= , Greg Kroah-Hartman Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alan Stern , Flavio Suligoi , Mathias Nyman , Douglas Anderson , Matthias Kaehlcke , Ray Chi , Michael Grzeschik , "linux-phy@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" References: <20230525022617.30537-1-stanley_chang@realtek.com> <20230525022617.30537-3-stanley_chang@realtek.com> <0b2143ca-ead7-c8fa-2e80-a94222af51ca@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/06/2023 12:49, Stanley Chang[昌育德] wrote: > Hi Krzysztof, > >> Thank you for your patch. There is something to discuss/improve. >> >> Actually a lot... The bindings are not suitable for review. > > Thanks for your patience in reviewing my patches. > > Most of the properties are about the phy parameters. > Is the phy parameter data suitable to be placed in DTS? > I referenced other phy drivers. > These parameters should not be defined in dts. > I would move the parameters to the driver. If these can be in the driver, why would ever they be in DTS in the first place? > >>> + realtek,usb: >>> + description: The phandler of realtek dwc3 node >> >> "phandler"? Except obvious typo, drop "The phandler of" and describe what is >> it for. > > realtek,usb is a phandle of syscon used to control realtek dwc3 register. Then no, phy should not control dwc3. > >>> + $ref: /schemas/types.yaml#/definitions/phandle >> >> Anyway, it shouldn't be here. No, no. > > Can I use it for phandle of syscon? PHY getting phandle to block using this PHY? Looks wrong. Why would PHY need to poke IP block register? Best regards, Krzysztof