From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5242CC77B7F for ; Sat, 6 May 2023 07:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbjEFHAR (ORCPT ); Sat, 6 May 2023 03:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbjEFHAQ (ORCPT ); Sat, 6 May 2023 03:00:16 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9ABBAD13; Sat, 6 May 2023 00:00:14 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id C110424E21E; Sat, 6 May 2023 15:00:11 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sat, 6 May 2023 15:00:11 +0800 Received: from [192.168.125.107] (183.27.98.219) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sat, 6 May 2023 15:00:10 +0800 Message-ID: Date: Sat, 6 May 2023 15:00:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Krzysztof Kozlowski , Conor Dooley CC: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , , , References: <3ed72340-accc-4ad1-098f-4a2eb6448828@linaro.org> <482e812a-05dd-105c-189c-e926b4be9d28@starfivetech.com> <089e24d1-588a-4a56-f00b-0b35d1d99295@linaro.org> <1ac26c1a-1726-515d-6598-849a07ed0b86@linaro.org> <5adda0ad-965c-fbf0-878c-9d41d28b5c39@starfivetech.com> <86693969-59bf-5bcc-42a3-b6e94a0d6f3e@linaro.org> <20230504-worshiper-ongoing-5581e1f2c2c4@wendy> <2f473307-2219-61a4-fa66-5848fe566cf0@starfivetech.com> <20230505-magician-poet-724c96020c2f@wendy> <9e7b265d-bfe5-f583-2357-d8e342bcf982@linaro.org> From: Changhuang Liang In-Reply-To: <9e7b265d-bfe5-f583-2357-d8e342bcf982@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.98.219] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX062.cuchost.com (172.16.6.62) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/5/6 14:31, Krzysztof Kozlowski wrote: > On 06/05/2023 03:45, Changhuang Liang wrote: >> >> Hi, Krzysztof and Conor >> >> Due to the current aon pmu needs to be adjusted, it affects the syscon in PLL series. >> So It's inevitable to change syscon in PLL series. >> >> My current idea is PLL series don't add the aon_syscon node. I will add it in my >> aon pmu series in next version like this: >> >> aon_syscon: syscon@17010000 { >> compatible = "starfive,jh7110-aon-pmu", "syscon"; >> reg = <0x0 0x17010000 0x0 0x1000>; >> #power-domain-cells = <1>; >> }; >> >> In my opinion, the first we add "starfive,jh7110-aon-syscon" because "syscon" can >> not appear alone in the compatible. If we have "starfive,jh7110-aon-pmu", this >> "starfive,jh7110-aon-syscon" is not a must-be need. >> >> Do you agree with doing so. > > Sorry guys, I don't know what you talk about. I have no clue what are > PLL and aon series. More over I don't understand what is complicated > here... all SoCs follow the same rules and similar way of development. > In other words, if I use the above approach, [1] https://lore.kernel.org/all/20230414024157.53203-6-xingyu.wu@starfivetech.com/ [2] https://lore.kernel.org/all/20230414024157.53203-7-xingyu.wu@starfivetech.com/ Links [1][2] need to be dropped "aon_syscon" node.