From: Marek Vasut <marex@denx.de>
To: Ajay.Kathat@microchip.com, alexis.lothore@bootlin.com,
linux-wireless@vger.kernel.org
Cc: davem@davemloft.net, adham.abozaeid@microchip.com,
claudiu.beznea@tuxon.dev, conor+dt@kernel.org,
edumazet@google.com, kuba@kernel.org, kvalo@kernel.org,
krzk+dt@kernel.org, pabeni@redhat.com, robh@kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] wifi: wilc1000: Rework bus locking
Date: Thu, 21 Nov 2024 02:39:40 +0100 [thread overview]
Message-ID: <c4d655d5-93d3-41dd-a958-c9305ab82fcd@denx.de> (raw)
In-Reply-To: <b287f8f9-600e-4e69-b7ec-25990275575e@denx.de>
On 11/16/24 8:57 PM, Marek Vasut wrote:
> On 11/15/24 9:04 PM, Ajay.Kathat@microchip.com wrote:
>
> Hello Ajay,
>
>>>>>> Can you explain how to prevent that or shall we disable uAPSD
>>>>>> altogether ?
>>>>>
>>>>> Could you please share the test procedure and logs. I am occupied
>>>>> at the
>>>>> moment but I shall make some time to look into it and get a better
>>>>> understanding.
>>>>
>>>> The simplest test procedure is this:
>>>>
>>>> $ while true ; do ifconfig wlan0 up ; ifconfig wlan0 down ; done
>>>>
>>>> As for the logs, MMCI controller sporadically reports either Command or
>>>> Data CRC error, so likely the SDIO response (from WILC to Host) is
>>>> corrupted.
>>>
>>> Are there any news ?
>>
>> I did test the same procedure in my setup, but I couldn't reproduce
>> this issue
>> even after running it for a long duration. In my test setup, I used the
>> sama5d27-som1-ek1 host and wilc3000 firmware version 16.3.
>>
>> I think this issue could be related to the host MMCI controller driver.
>> Normally, the wilc SDIO bus failures are captured by driver logs with
>> an error
>> code (e.g., timeout), but if the MMCI controller is outputting the
>> warning
>> message, then the error could be related to it. Does the MMCI
>> controller error
>> point to any specific function?
>
> Either CMD52 or CMD53 errors out with CRC error, this is recognized by
> the controller. That points to sporadic CRC error during SDIO transfer.
>
>> Which host was used to test this scenario, and
>> is it possible to test with different host or different configuration
>> on the
>> same host
>
> I am observing sporadic command and data CRC errors on STM32MP157F
> system with SDIO WILC3000.
>
> , like disabling power save on the host?
> I already tested disabling power save.
>
> Can you explain why does uAPSD (iw ...set power_save off) adversely
> affect SDIO bus stability ?
>
> Can you explain how to prevent that or shall we disable uAPSD altogether ?
>
> Is there any way to make the WILC firmware produce debug output , so we
> can figure out what is going on "on the other side" ?
>
> Are you able to provide me (maybe off-list) some debug firmware build ?
> (or can I get firmware sources and build and debug my own WILC firmware
> on the Cortus CPU?)
>
> I can trigger the SDIO errors even without being connected to any AP ,
> so this is something between the WILC and the SDIO host, the radio is
> likely not involved , right ?
Any news ?
next prev parent reply other threads:[~2024-11-21 4:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 1:38 [PATCH] wifi: wilc1000: Rework bus locking Marek Vasut
2024-10-22 10:43 ` Alexis Lothoré
2024-10-22 13:19 ` Marek Vasut
2024-10-23 7:17 ` Ajay.Kathat
2024-10-23 14:44 ` Marek Vasut
2024-10-23 17:54 ` Ajay.Kathat
2024-10-23 18:47 ` Marek Vasut
2024-11-04 11:44 ` Marek Vasut
2024-11-07 1:28 ` Ajay.Kathat
2024-11-07 16:10 ` Marek Vasut
2024-11-15 14:33 ` Marek Vasut
2024-11-15 20:04 ` Ajay.Kathat
2024-11-16 19:57 ` Marek Vasut
2024-11-21 1:39 ` Marek Vasut [this message]
2024-10-23 7:54 ` Alexis Lothoré
2024-10-23 14:26 ` Marek Vasut
2024-10-22 20:33 ` kernel test robot
2024-10-23 1:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d655d5-93d3-41dd-a958-c9305ab82fcd@denx.de \
--to=marex@denx.de \
--cc=Ajay.Kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=alexis.lothore@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).