From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 621F3EE3F35 for ; Mon, 11 Sep 2023 20:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237829AbjIKUvq (ORCPT ); Mon, 11 Sep 2023 16:51:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236992AbjIKLtr (ORCPT ); Mon, 11 Sep 2023 07:49:47 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 311E2CEB for ; Mon, 11 Sep 2023 04:49:43 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-31c5a2e8501so4278965f8f.0 for ; Mon, 11 Sep 2023 04:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694432981; x=1695037781; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7uTE277R9IUMWfpcxvhVYcRRY/+i4lXQdoTCf3ndW5s=; b=t6Wi/J03+QMNMqFU13HnVUdBpoX65x6JdV8UeKZGz5mgA6/D2MJdYB1kuZX/tjO1Pv DCyz+oSoTjYMC2jCcEqFxQatUqe2HQTw/X1UnuRJmE8eHLEcDLRtsIVdl5e56Yh0M0lq +SVp3JPEQ6YrOkU0MpRz9K6wqVlHmzkWdLRc4KnnavlDx5WRc3jBxmuzrsZ+53RSFVGt JYPBDvtuQr9QnUGP+Qp7CiFnqOyug8LVEhdMFhKd7Bc8OIXI6Bz05hYL+nipncUrnq79 5lSwq1wn1RujgAjVhUb6ky/dvihQeXX1Oav2rLvpDRPBUdxePgp4XgdnQZEwds2s2j5P HzvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694432981; x=1695037781; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7uTE277R9IUMWfpcxvhVYcRRY/+i4lXQdoTCf3ndW5s=; b=YhoOGR1wUhkcVPqmlPrkCwf/fAai6ljpIvLPL4Pyd29vo4QDFSNgTD6c4p0r7VIifP n36Qt13Kdd8j/Ecn3omP/uSotH9zCQSVKYExmJSMXpBoCASA5QZf6zqtqywl+6nj7Gxo DdjjUI8z3YW714mYPi90WsB5QUGEccTwzbbpys0BPMEhLPwgrGgb91oF/P2HOPlb7+y4 +S+Hc17zQm2+0nDzm3K+yQat6lC4WaFXbc++e7H/JILkaks4IU6tVynp6Q13Koa42RNL fuLKqFEhVSKnXsAFR4qYeFQyd6W5NT7kauJApAIsM0oJyOx9XfrESPPDsCZb+465JdHq 9NjA== X-Gm-Message-State: AOJu0YzpMBpCtKRDiZWY+I6egHyFqrZfwo7XCo2rqL4SOqbMLZMrKYVl P/tayBRM+Ax1VT3LPEZ1VnsiXQ== X-Google-Smtp-Source: AGHT+IHLnKxjUB/zLnPuoIMc1DDrZGTbUd7F4GSTdG7pPu1CvVlKzmeIQ604ecyru6GcFidOBOTjFA== X-Received: by 2002:adf:ef8d:0:b0:319:6e6a:66e with SMTP id d13-20020adfef8d000000b003196e6a066emr8388505wro.14.1694432981598; Mon, 11 Sep 2023 04:49:41 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id u24-20020adfa198000000b0031f8a59dbeasm6957022wru.62.2023.09.11.04.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 04:49:40 -0700 (PDT) Message-ID: Date: Mon, 11 Sep 2023 13:49:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek FS035VG158 panel Content-Language: en-US To: John Watts Cc: dri-devel@lists.freedesktop.org, Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Shawn Guo , Chris Morgan , Jagan Teki , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230911090206.3121440-1-contact@jookia.org> <20230911090206.3121440-9-contact@jookia.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/09/2023 11:49, John Watts wrote: > Hello again, > > On Mon, Sep 11, 2023 at 11:41:12AM +0200, Krzysztof Kozlowski wrote: >>> +maintainers: >>> + - John Watts >>> + >>> +allOf: >>> + - $ref: panel-common.yaml# >>> + - $ref: /schemas/spi/spi-peripheral-props.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: fascontek,fs035vg158 >>> + >>> + backlight: true >>> + port: true >>> + power-supply: true >>> + reg: true >>> + reset-gpios: true >> >> Why do you need all these 5? They are allowed by panel-common. >> >>> + >>> + spi-3wire: true >>> + >>> +required: >>> + - compatible >> >> Missing reg. Probably also port. >> >> >>> + - power-supply >>> + - reset-gpios >>> + > > I have just copy pasted the other panel's yaml, so these issues apply > there too. Should I fix that panel's yaml up first then re-copy? If the other panel has exactly the same case, then yes, you can do like this. But it depends on the bindings - to which ones do you refer as your tmeplate? Best regards, Krzysztof