From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89A0233086 for ; Fri, 24 Oct 2025 00:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761264247; cv=none; b=kTWr1N4CyV66a2y5/+EZ8scEYxec2QaAWB0r1aIDP8Xcwi9Z6mm01OHW8a//j3PTfZ+YaNbDb9srH9s13VqNzrXc3qznYoqcm4p2nvBKLKi7XKB8+Ihi0YeLNA/I5RFxk1+nLKaZ9A8gsHSpxTJyvGiTz6Y2LBl6I68xpQyNuG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761264247; c=relaxed/simple; bh=C1jkv51ztRxfrNfz0d7YqP/iXJQqsBRzL9QozwFBY9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZCfjCdCZWM1npVHAAmyq9h+ysee2+9nA151gD20RRGM3K++HCw7OA+6QEoMsFS1DZ/96RU+9Ffr9megEasgYzq4ak/DtL5kxlfwyTg5o6Pn55oq7NQbl/vZGAiD4jmgIYyzhugWyhw5xV9kId0AzRGWKKjyFBR5pwInzS78MPW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=wJmPVWx6; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="wJmPVWx6" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-33e27a3b153so1476662a91.3 for ; Thu, 23 Oct 2025 17:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1761264245; x=1761869045; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JDIR1c+Ak+2fqutJiwvCBnlZ0v5UftOa0ifZP/2OQnc=; b=wJmPVWx62tCC5wRokHJeKJtjKXrd3lBjhygVoiCLYc/GfseIDsdhfzQraXKO2eVj/7 HoiBhb0QXjEqycCGZ52aqOMjQ5ZSw1BGb4JTGsWQ5qQvCDS+nwENGa2EBgtI1ibcJDyz fH5wOXhB2cx/Sx2OrNUjRB0Nv1d3bCx0O6+WNyhbzt94K38vu+D7xFTbIKpOHBPDliG7 z4ZYDPV/CTCbHN3ACxEDiT8yvQBpvMK1EZkguEr/IipFCv3z+9s0zw7EXkvRsIZyReso 4Lukyw9D1ywKzv60umIi2t4Jn40fkqC0dVhKgsP5by5TNKH3a2G5tmfdKRXgwpYnPROv xPhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761264245; x=1761869045; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JDIR1c+Ak+2fqutJiwvCBnlZ0v5UftOa0ifZP/2OQnc=; b=D0xShitJ1pPS6kdP6PL6blbNNNe1cVK5hJdXend/yR2QN7YEznSJ1zsFLYAKnqKVYb TPG+ykD5Pth4262x3nzpkySlN1u1ggPkev7tVwXf/Z2JrRJYR62m1Pzbie8/bVHHCwDj 1DI1jtDnlhmM2iWZY7f5CkcCixHbSIbY0SqDy04OZNC8VmESzLD7H3ZpPXI/n+2g80yf +mhk4LacFoWXFg0q9pYkvAFVtMqCKzfXeh5OJo8pWGkzbtYdvmD5bV7qnhto54COHb/o yvEo4LePI/Vo6ntWWr08DIH4IVs/tfjsUxuzaQwe0cVkeBr+9+lrMkStCWnt2DqPuQqY hzQg== X-Forwarded-Encrypted: i=1; AJvYcCUpvmyqGRLZC2qhP/X0DYWEHoErTZts00JGHLKxcCuph0iyWbcIbkjYlSMsQiV/kiEcuEeJL55buKq/@vger.kernel.org X-Gm-Message-State: AOJu0Yy3bpaUHb1fv95/qp7f1zPa3R7pLeu4GtokRSXWPeOZnAT+xcyg s5r3Km+fNZrDJlN3NgZHg+ZIGa1HE+VVLBMRyWOGWxGH/PmzCz4ka6b6+g4R3CCun5o= X-Gm-Gg: ASbGncu9578uD8hIrN0OZ7w4CwH6QAS5rixASw+hyCYD8EHxLUp7EHTZbj6Zb0F/O5G HjPXZKVgHm6VXPjz9YchNs5x41ukFQfn+7Q4RJPy962LBu7uzczpulGPsFS8JQnpfxtzjzuvLaL HD/aYpQUxL3QrfZein7qGD/amNPKVbc6ehAH7syADJMyIZhsflC9yDptXHZjtzfxyfD8yRUI/Wi epZzjBSPJbDG0yqoxF1N8u9ZzBO7ehQhUPZa+ZjC31wJPynMLYsbZhMiNPdEvSUHU/RKulO3q3a /HPNQAYyl8r9RKU+Lu6rxyhuAn//ZMtrv+YinqKWhhpvWrhaohDYqsBw2FDhoQEIri7qjyCSROv FkJOAQxSFTUweVQLlrd/sije72xSctAQSekyPyOU8YXIP2tdQUqK2fQsqDaWl9fuh+5t+iRnVE5 HNbHv9x0xNGQDp0egN X-Google-Smtp-Source: AGHT+IH/sqOkgJHPoJp0C3PRAnpePjJuvBDUdrVuB7xX2bh8XQc9etMQIVsugloCyKqrfw/GQPbVxw== X-Received: by 2002:a17:903:38c8:b0:276:76e1:2e87 with SMTP id d9443c01a7336-2946e22bbcfmr48197185ad.44.1761264244857; Thu, 23 Oct 2025 17:04:04 -0700 (PDT) Received: from [10.211.55.5] ([208.115.86.146]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33faff373easm3702460a91.5.2025.10.23.17.04.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 17:04:04 -0700 (PDT) Message-ID: Date: Thu, 23 Oct 2025 19:04:02 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/9] dt-bindings: spi: fsl-qspi: add optional resets To: Frank Li Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, han.xu@nxp.com, broonie@kernel.org, dlan@gentoo.org, guodong@riscstar.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251023175922.528868-1-elder@riscstar.com> <20251023175922.528868-3-elder@riscstar.com> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/23/25 6:32 PM, Frank Li wrote: > On Thu, Oct 23, 2025 at 12:59:14PM -0500, Alex Elder wrote: >> Allow two resets to be defined to support the SpacemiT K1 SoC QSPI IP. >> >> Signed-off-by: Alex Elder >> --- >> v2: - The "reset" property now only applies to spacemit,k1-qspi compatible >> >> .../devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml >> index 5e6aff1bc2ed3..edd3158a6f2e8 100644 >> --- a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml >> @@ -55,6 +55,21 @@ properties: >> - const: qspi_en >> - const: qspi >> >> + resets: >> + items: >> + - description: SoC QSPI reset >> + - description: SoC QSPI bus reset >> + >> +if: >> + properties: >> + compatible: >> + not: >> + contains: >> + const: spacemit,k1-qspi >> +then: >> + properties: >> + resets: false >> + > > strange, if-then should be under allOf, I have not seen you add allOf. And > original file have not allOf. The file currently has allOf at the top, to reference spi-controller.yaml. I'll include this next time within that allOf. -Alex > > Frank > >> required: >> - compatible >> - reg >> -- >> 2.43.0 >>