From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: dianders@chromium.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: sc7180: Add sku_id for lazor/limozeen
Date: Mon, 7 Aug 2023 08:35:22 +0200 [thread overview]
Message-ID: <c4e1a5ed-cfdd-6d5d-7749-846ca27a8b94@linaro.org> (raw)
In-Reply-To: <20230804175734.v2.2.Ia4e268a027980f00c8fb0451a29938d76b765487@changeid>
On 04/08/2023 11:58, Sheng-Liang Pan wrote:
> SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0)
> SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0)
> SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0)
>
> Even though the "no esim" boards are strapped differently than
> ones that have an esim, the esim isn't represented in the
> device tree so the same device tree can be used for LTE w/ esim
> and LTE w/out esim.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v1)
>
> .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts
> index 913b5fc3ba76..cef57c15b70b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts
> @@ -14,7 +14,7 @@
>
> / {
> model = "Google Lazor Limozeen without Touchscreen (rev9+)";
> - compatible = "google,lazor-sku6", "qcom,sc7180";
> + compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180";
NAK, you really did not test it. At all.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-07 6:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 9:58 [PATCH v2 0/3] Add no-esim sku for sc7180-lazor family and new board version Sheng-Liang Pan
2023-08-04 9:58 ` [PATCH v2 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings Sheng-Liang Pan
2023-08-04 16:30 ` Doug Anderson
2023-08-07 13:37 ` Konrad Dybcio
2023-08-07 6:32 ` Krzysztof Kozlowski
2023-08-15 20:41 ` Doug Anderson
2023-08-15 20:46 ` Krzysztof Kozlowski
2023-08-04 9:58 ` [PATCH v2 2/3] arm64: dts: qcom: sc7180: Add sku_id for lazor/limozeen Sheng-Liang Pan
2023-08-07 6:35 ` Krzysztof Kozlowski [this message]
2023-08-04 9:58 ` [PATCH v2 3/3] arm64: dts: qcom: sc7180: Add board id " Sheng-Liang Pan
2023-08-04 16:30 ` Doug Anderson
2023-08-07 6:34 ` Krzysztof Kozlowski
2023-08-15 21:10 ` Doug Anderson
2023-08-15 21:22 ` Krzysztof Kozlowski
[not found] ` <eb082e10-efc2-0f5f-95e1-4d2707c87c59@linaro.org/>
[not found] ` <20230816095910.41305-1-sheng-liang.pan@quanta.corp-partner.google.com>
2023-08-16 18:31 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4e1a5ed-cfdd-6d5d-7749-846ca27a8b94@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sheng-liang.pan@quanta.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).