From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71CFEEB64DD for ; Mon, 7 Aug 2023 06:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230140AbjHGGf2 (ORCPT ); Mon, 7 Aug 2023 02:35:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjHGGf1 (ORCPT ); Mon, 7 Aug 2023 02:35:27 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AF99171A for ; Sun, 6 Aug 2023 23:35:25 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-51e429e1eabso5667823a12.2 for ; Sun, 06 Aug 2023 23:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691390124; x=1691994924; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ln71qb1Upy27G8ZY4+b/kRfYYp2es9bMhQqMxgaZOrQ=; b=Ezwn6IdcE09uCXoc5w324qjVikVOOl4+nIahqRmSpsjOHDep5NmH+J9OQ0B8iznsBd OyOAAySocuNz6j2BJCnwZe1xKFKOuEr9bMAn0khE5k6VsChyuM5DbYOwjoX5tKWnh7oZ ShOL2q4SZXE7EVLNHSDPHINq8Xyg2wzF83TAEr3cFUMC802PdGKvotcOG68QWpl09Ho3 R/W6kDBlCTuVGSiwoP1dvYP6oyCCYlcIzuCYslf2Vmy+Ff5Z+S1hmyVHdqQtFaesdAd+ 1vsUlv+H9FeThxpBLXcAlYYnp2QevjeOjH7+j79QgXUfDifkjvUsXY5OooZl8rdSffwy mx+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691390124; x=1691994924; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ln71qb1Upy27G8ZY4+b/kRfYYp2es9bMhQqMxgaZOrQ=; b=GvEkJNkiUmP+Cv8hjc+jwrTqBqP9SnQViVdSftH+5Iz206szuyaYqzhOaOBv0WH4qN ykp+ei7N9whIjtFOQKfVy7rt9swez+4NASicwbAkHpIME2vgwYrjIMz6MAqZMHxW3be4 omkNkg49QkDdYg1Jjkhoz1solQ6qgtXr3SlxHUhTM9YNw+bxJFrZwhChTjEFa9AoWbKp Koy+ntwIYN34oPycwJl1zuqZJXsz7XyF08iF0XpDb5bmUwfwCEuBmkOj/zPIIxijldHd IOmcVTxcleF7z+v8MKu+q+SteuElgDGOq7H8+jAWTUIeQgZoafan0WhMG9vYqu5+wY0I 6Zog== X-Gm-Message-State: AOJu0Yy2hlJLuTLPmVQbSOlkxYFyW5E6JMTk5DThuG/U5YfLmEKfR0iv ciFkcAAkSnjJtP2h50FT9QPBGQ== X-Google-Smtp-Source: AGHT+IEEz65KpLi4QI0UNj/bsk/5/iVIqJEtST2rHfNNxMWgMWGL3FL2Vjt6+1xPvI1JLRfhEjPj2Q== X-Received: by 2002:aa7:df0a:0:b0:522:1d80:7549 with SMTP id c10-20020aa7df0a000000b005221d807549mr5785501edy.26.1691390123973; Sun, 06 Aug 2023 23:35:23 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id c18-20020aa7c752000000b0052228721f84sm4763706eds.77.2023.08.06.23.35.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Aug 2023 23:35:23 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 08:35:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: sc7180: Add sku_id for lazor/limozeen Content-Language: en-US To: Sheng-Liang Pan , LKML Cc: dianders@chromium.org, Andy Gross , Bjorn Andersson , Conor Dooley , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230804095836.39551-1-sheng-liang.pan@quanta.corp-partner.google.com> <20230804175734.v2.2.Ia4e268a027980f00c8fb0451a29938d76b765487@changeid> From: Krzysztof Kozlowski In-Reply-To: <20230804175734.v2.2.Ia4e268a027980f00c8fb0451a29938d76b765487@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/08/2023 11:58, Sheng-Liang Pan wrote: > SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0) > SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0) > SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0) > > Even though the "no esim" boards are strapped differently than > ones that have an esim, the esim isn't represented in the > device tree so the same device tree can be used for LTE w/ esim > and LTE w/out esim. > > Signed-off-by: Sheng-Liang Pan > Reviewed-by: Douglas Anderson > --- > > (no changes since v1) > > .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts > index 913b5fc3ba76..cef57c15b70b 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts > @@ -14,7 +14,7 @@ > > / { > model = "Google Lazor Limozeen without Touchscreen (rev9+)"; > - compatible = "google,lazor-sku6", "qcom,sc7180"; > + compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180"; NAK, you really did not test it. At all. Best regards, Krzysztof