From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04704C43334 for ; Tue, 26 Jul 2022 09:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238100AbiGZJ3Y (ORCPT ); Tue, 26 Jul 2022 05:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237807AbiGZJ3X (ORCPT ); Tue, 26 Jul 2022 05:29:23 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40C0F2FFFA for ; Tue, 26 Jul 2022 02:29:22 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id q7so423318ljp.13 for ; Tue, 26 Jul 2022 02:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=C73GH9ihVQid8BYkT3Sa1NsZogeb4NXbL4mmn1ehaOE=; b=V5/W5DZLiKaTrI/gH/Wifh0YwVboE5Rt39xduS8KfMtLKsQB8CsUPW/ToeVabJjwJX iJreOYQFgEL3D0c5VdyfHyN1ZWvZCYQ3VwFPTGEMF2y4uTBXSykMine3MxQljjkShXw+ tjMwp2iVq0M8Vrqm3ZVOs2fIl6kupIPgO8M7qjqZjsPHojcPiSTSM6jovX1eqUOpiB9I 5uYzzC+P3b/hceQUfTdRPw+ZqshnZT3jLhdCwF6acqSxQQiLkNEJAVplGo6hXvvehUGq L6CmqS925cgyKKYzMGu+2AtFJuKOONfWe/jMQ9lK0mllU7EjxyauocPo06HgZIuhVDGX JBUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=C73GH9ihVQid8BYkT3Sa1NsZogeb4NXbL4mmn1ehaOE=; b=08VweijsaexjqrQT4fVleP2LnDF3rNS37KEOQqjDQf6NcdLOBt9Dn6BoSGTZnF7HIL gGzvODzhyr3oVlmIpzQ/SCg+U90ZzXm3ktTQUA05dLJOX0lrOfr3RTPNdin4A+GJsjwU npGGdtJZ7MJm5moWaEfVPI5cdHSzxwfBsj/JMi7ir45KGa9L+NEdreGsCCUV9NGq400r sFWgqUq21J2GH+kmj2crMwviA7zJxYqya+8djwSay0U5WMpya7mgyZfv+d/IF6VGzGHc oKifYRJvD4wW7izGlCS5IaqVJOu4S0fwvbFTiN6OwTct95S48P3KEznxQyh0m6VWJC4h xF0g== X-Gm-Message-State: AJIora/evYN80o1IJgCA+B3sEcS35PVXBvr3b/Cg5opEuV/06ZINrIZi PWHvmAkkS2ddABa1Ahw8xPmSFQ== X-Google-Smtp-Source: AGRyM1uQdBfRCK0JOiJbIzWqsixI71GKQA/6XmfE4JdFdLP4KzdKbUhd2rP0hztesLdVcjEBnAqqPA== X-Received: by 2002:a2e:bd85:0:b0:25d:d750:7ac8 with SMTP id o5-20020a2ebd85000000b0025dd7507ac8mr5301578ljq.387.1658827760529; Tue, 26 Jul 2022 02:29:20 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id w5-20020ac25985000000b0048a8a4540d4sm1152563lfn.101.2022.07.26.02.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 02:29:19 -0700 (PDT) Message-ID: Date: Tue, 26 Jul 2022 11:29:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1 2/2] dt-binding: iio: time: add capture-tiecap.yaml Content-Language: en-US To: Julien Panis , jic23@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: lars@metafoo.de, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mranostay@ti.com References: <20220726072553.5136-1-jpanis@baylibre.com> <20220726072553.5136-3-jpanis@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220726072553.5136-3-jpanis@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/07/2022 09:25, Julien Panis wrote: > This commit adds a YAML binding for TI ECAP used in capture operating mode. > > Signed-off-by: Julien Panis > --- > .../bindings/iio/time/capture-tiecap.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml > > diff --git a/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml b/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml > new file mode 100644 > index 000000000000..4f08e49a8506 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml Use filename based on compatible, so: ti,am62-ecap-capture.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/capture-tiecap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments Enhanced Capture (eCAP) Module > + > +maintainers: > + - Julien Panis > + > +description: | > + The eCAP module resources can be used to capture timestamps > + on input signal events (falling/rising edges). > + > +properties: > + compatible: > + const: ti,am62-ecap-capture > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: fck > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + ecap0: capture@23100000 { /* eCAP in capture mode on am62x */ > + compatible = "ti,am62-ecap-capture"; > + reg = <0x00 0x23100000 0x00 0x100>; > + interrupts = ; > + power-domains = <&k3_pds 51 TI_SCI_PD_EXCLUSIVE>; Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + clocks = <&k3_clks 51 0>; > + clock-names = "fck"; > + }; Best regards, Krzysztof