From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5BFC001B2 for ; Wed, 14 Dec 2022 08:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237375AbiLNIMR (ORCPT ); Wed, 14 Dec 2022 03:12:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237515AbiLNILi (ORCPT ); Wed, 14 Dec 2022 03:11:38 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FFBA1EC4E for ; Wed, 14 Dec 2022 00:09:10 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id g7so9157626lfv.5 for ; Wed, 14 Dec 2022 00:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OpxduO24RNKiHe7qgJOcOcCob/2sJ/YLTZskR12FTNA=; b=BeVHY8eEoIKiIZpXg/sfmOQ4jlKDpPHhWyAhDMWNpXLZ4442OJXmgb6yfpAPrH/drL 8dEtmBRLQ8VXtcNHcMarxqm7r+Cx01k+E+VRi3+9QgAVNO7DZIdKe90IQ6fmnLdxAWZS E9GIcv+tPgYLuoELD6C2awAYDxglz1nTg7ycrLqxfEQVV3Ufk1OJbSERfQn8o4kLuKLL GXVxRkrwx0akTCUZ4tIMx5yuRubk4T2aek4YXHywxdJpFmkqUvLmwbua5R75ii20vvfy gajh/9wzRxyKoKYiO8rjb7oT0RPxC97aZvjH8YPJ8xGTKLuLvBv2ESqOOJpUm2ZHDNFU YoFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OpxduO24RNKiHe7qgJOcOcCob/2sJ/YLTZskR12FTNA=; b=VG72AVf4djxena6JdPRBUIIHeD8rtzQC9D1C3KJjcADCjZESDETiTgUsCLxUam8UWS dZgLuJwJYuQgr5A0OvyxdGsH/w7tAUsSKmOZdZ/bprZ+TA+txWYES70F9ARpPLCOie8E /GYL8Sm9kKAllBUqTyIQwnblh8fsEwd0T1VXnSAbb6o6MSvL+AuZiqFbjxWYUbba7nCm l9VrjImkLiSiPHww/059a8e//QLYHEXlOqYVx+FO5lvWJ1YwM/pSmr4HbHz7jvetC9az ETGh9g58IheowQdSFLOXF9U1p17P1kJ3iSMa99dZdlKOjTK7tomFMZsHCRNtFjZYSBUf rL6Q== X-Gm-Message-State: ANoB5pkvRbYuzL113tK188plGMirPD9XZqog8vwpVIwx2lzxuM870qNG Ejcb5oQ+k0zrPpqhgKAdmxmBSg== X-Google-Smtp-Source: AA0mqf5ORcU2VhODrzF1Mr8QjolUDvL4SNlSAy9EI75Xqlqtp44H45VTH4pKT45haDrIPNCNoEki6A== X-Received: by 2002:a05:6512:1329:b0:4b5:853c:ed30 with SMTP id x41-20020a056512132900b004b5853ced30mr9575872lfu.23.1671005348688; Wed, 14 Dec 2022 00:09:08 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id n13-20020a056512310d00b004b59c9b7fb4sm707250lfb.126.2022.12.14.00.09.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 00:09:08 -0800 (PST) Message-ID: Date: Wed, 14 Dec 2022 09:09:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/4] arm64: dts: qcom: Introduce a carveout for modem metadata Content-Language: en-US To: Sibi Sankar , andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, manivannan.sadhasivam@linaro.org Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, amit.pundir@linaro.org, regressions@leemhuis.info, sumit.semwal@linaro.org, will@kernel.org, catalin.marinas@arm.com, robin.murphy@arm.com References: <20221213140724.8612-1-quic_sibis@quicinc.com> <20221213140724.8612-2-quic_sibis@quicinc.com> <7ea03855-4806-f4ca-e0c3-4044e1095d6b@linaro.org> <96c1e60d-de12-5e60-4c06-70ea4b9c49f8@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <96c1e60d-de12-5e60-4c06-70ea4b9c49f8@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/12/2022 07:49, Sibi Sankar wrote: > Hey Krzysztof, > > Thanks for taking time to review the series. > > On 12/14/22 01:10, Krzysztof Kozlowski wrote: >> On 13/12/2022 15:07, Sibi Sankar wrote: >>> Introduce a new carveout for modem metadata. This will serve as a >>> replacement for the memory region used by MSA to authenticate modem >>> ELF headers. >>> >>> Signed-off-by: Sibi Sankar >> >> Thank you for your patch. There is something to discuss/improve. >> >>> >>> aliases { >>> @@ -865,7 +870,7 @@ hp_i2c: &i2c9 { >>> clock-names = "iface", "bus", "nav", "snoc_axi", "mnoc_axi", "xo"; >>> >>> iommus = <&apps_smmu 0x461 0x0>, <&apps_smmu 0x444 0x3>; >>> - memory-region = <&mba_mem &mpss_mem>; >>> + memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>; >>> >>> /* This gets overridden for SKUs with LTE support. */ >>> firmware-name = "qcom/sc7180-trogdor/modem-nolte/mba.mbn", >>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >>> index bf522a64b172..bda0495aa0b5 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >>> @@ -17,6 +17,11 @@ >>> reg = <0x0 0x9c700000 0x0 0x200000>; >>> no-map; >>> }; >>> + >>> + mdata_mem: memory@9d100000 { >>> + reg = <0x0 0x9d100000 0x0 0x4000>; >>> + no-map; >>> + }; >>> }; >>> }; >>> >>> @@ -32,7 +37,7 @@ >>> >>> iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; >>> interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>; >>> - memory-region = <&mba_mem>, <&mpss_mem>; >>> + memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>; >> >> Only two memory regions are allowed by bindings... unless you fix it in >> further patchset. If so, please re-order to have the bindings first. It >> helps reviewers not to have such questions. :) > > I felt that Rob's dt_bindings check bot might report an error > if the dt changes weren't placed before the bindings changes. > But since you asked for the logical order I guess the bindings > check are done only after the entire series is applied. I'll > change the order in the next re-spin. AFAIR, Rob's bot ignores DTS patches anyway. Best regards, Krzysztof