From: Daniel Drake <ddrake@baylibre.com>
To: Jiaxing Hu <gahing@gahingwoo.com>,
tomeu@tomeuvizoso.net, heiko@sntech.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, joro@8bytes.org,
will@kernel.org, robin.murphy@arm.com, p.zabel@pengutronix.de,
ogabbay@kernel.org, zhangqing@rock-chips.com
Cc: royalnet026@gmail.com, ulf.hansson@oss.qualcomm.com,
abel.vesa@oss.qualcomm.com, sebastian.reichel@collabora.com,
sidong.yang@furiosa.ai, u.kleine-koenig@baylibre.com,
chaoyi.chen@rock-chips.com, shawn.lin@rock-chips.com,
finley.xiao@rock-chips.com, diederik@cknow-tech.com,
alchark@flipper.net, leonard@lausen.nl, vlwwwwww@gmail.com,
jeff.hugo@oss.qualcomm.com, rfoss@kernel.org,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v17 09/12] accel/rocket: add RK3576 NPU (RKNN) support
Date: Wed, 18 Nov 2026 12:28:02 +0000 [thread overview]
Message-ID: <c5068359-e155-4374-9f3a-1b89106c6fb4@baylibre.com> (raw)
In-Reply-To: <57874e7459ed84ad47b2e31a62871ff535da249b.1794615323.git.gahing@gahingwoo.com>
Hi,
On 14/11/2026 03:05, Jiaxing Hu wrote:
> # Conflicts:
> # drivers/accel/rocket/rocket_core.c
> # drivers/accel/rocket/rocket_core.h
This needs to be removed from the commit message.
> diff --git a/drivers/accel/rocket/rocket_device.c b/drivers/accel/rocket/rocket_device.c
> index db137e2ec15e..868af86d00ce 100644
> --- a/drivers/accel/rocket/rocket_device.c
> +++ b/drivers/accel/rocket/rocket_device.c
> @@ -9,6 +9,7 @@
> #include <linux/of.h>
>
> #include "rocket_device.h"
> +#include "rocket_drv.h"
>
> struct rocket_device *rocket_device_init(struct platform_device *pdev,
> const struct drm_driver *rocket_drm_driver)
> @@ -27,7 +28,7 @@ struct rocket_device *rocket_device_init(struct platform_device *pdev,
> ddev = &rdev->ddev;
> dev_set_drvdata(dev, rdev);
>
> - for_each_compatible_node(core_node, NULL, "rockchip,rk3588-rknn-core")
> + for_each_matching_node(core_node, rocket_dt_match)
> if (of_device_is_available(core_node))
> num_cores++;
I think it would be a little cleaner to do the counting in rocket_drv.c,
and pass it in as a parameter to rocket_device_init().
Then you don't need to share the dt_match over two files.
> diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c
> index 68df1596014e..59a6f548e108 100644
> --- a/drivers/accel/rocket/rocket_job.c
> +++ b/drivers/accel/rocket/rocket_job.c
> @@ -31,6 +31,11 @@
> /* Bits 3:0 of PC_BASE_ADDRESS hold the mode selection bit and reserved bits */
> #define ROCKET_REGCMD_ALIGN 16
>
> +#define RK3576_PC_TASK_CON_TASK_NUMBER(n) ((n) & 0xffff)
> +#define RK3576_PC_TASK_CON_PP_EN BIT(16)
> +#define RK3576_PC_TASK_CON_COUNT_CLEAR BIT(17)
> +#define RK3576_PC_TASK_CON_LAST_LAYER_CLEAR BIT(18)
This introduces an inconsistency in the way registers are handled. All
other reg definitions are in rocket_registers.h (originating from mesa
xml) but this one is placed here.
I think you should add it to mesa as some kind of register variant, and
then regenerate rocket_registers.h
next prev parent reply other threads:[~2026-11-18 12:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 3:05 [PATCH v17 00/12] accel/rocket: RK3576 NPU (RKNN) enablement Jiaxing Hu
2026-11-14 3:05 ` [PATCH v17 01/12] accel/rocket: request the core clocks by name Jiaxing Hu
2026-11-14 3:05 ` [PATCH v17 02/12] accel/rocket: take the completion register writes under job_lock Jiaxing Hu
2026-11-14 3:05 ` [PATCH v17 03/12] accel/rocket: wait for a running IRQ handler before resetting a core Jiaxing Hu
2026-11-14 3:31 ` sashiko-bot
2026-11-15 13:16 ` Heiko Stübner
2026-11-14 3:05 ` [PATCH v17 04/12] accel/rocket: let the core suspend after a reset Jiaxing Hu
2026-11-14 3:24 ` sashiko-bot
2026-11-18 12:27 ` Daniel Drake
2026-11-14 3:05 ` [PATCH v17 05/12] accel/rocket: factor the completion tail out of the IRQ handler Jiaxing Hu
2026-11-14 3:05 ` [PATCH v17 06/12] dt-bindings: npu: rockchip: add rockchip,rk3576-rknn-core Jiaxing Hu
2026-11-14 3:13 ` sashiko-bot
2026-11-14 3:05 ` [PATCH v17 07/12] dt-bindings: iommu: rockchip: describe the RK3576 NPU MMU Jiaxing Hu
2026-11-14 3:05 ` [PATCH v17 08/12] accel/rocket: select the per-core clock and reset counts from match data Jiaxing Hu
2026-11-18 12:27 ` Daniel Drake
2026-11-14 3:05 ` [PATCH v17 09/12] accel/rocket: add RK3576 NPU (RKNN) support Jiaxing Hu
2026-11-18 12:28 ` Daniel Drake [this message]
2026-11-14 3:05 ` [PATCH v17 10/12] accel/rocket: add a GET_PARAM ioctl for the hardware version Jiaxing Hu
2026-11-18 12:28 ` Daniel Drake
2026-11-14 3:05 ` [PATCH v17 11/12] arm64: dts: rockchip: add NPU (RKNN) nodes to rk3576 Jiaxing Hu
2026-11-14 3:27 ` sashiko-bot
2026-11-18 12:28 ` Daniel Drake
2026-11-14 3:05 ` [PATCH v17 12/12] arm64: dts: rockchip: enable the NPU on rk3576-rock-4d Jiaxing Hu
2026-11-18 12:28 ` Daniel Drake
2026-11-14 12:54 ` [PATCH v17 00/12] accel/rocket: RK3576 NPU (RKNN) enablement Sidong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5068359-e155-4374-9f3a-1b89106c6fb4@baylibre.com \
--to=ddrake@baylibre.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=alchark@flipper.net \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diederik@cknow-tech.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=finley.xiao@rock-chips.com \
--cc=gahing@gahingwoo.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=leonard@lausen.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ogabbay@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=royalnet026@gmail.com \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=sidong.yang@furiosa.ai \
--cc=tomeu@tomeuvizoso.net \
--cc=u.kleine-koenig@baylibre.com \
--cc=ulf.hansson@oss.qualcomm.com \
--cc=vlwwwwww@gmail.com \
--cc=will@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox